From: Hans Zhang <18255117159@163.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com,
jingoohan1@gmail.com, cassel@kernel.org, robh@kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Standardize link status check to return bool
Date: Sat, 3 May 2025 00:10:33 +0800 [thread overview]
Message-ID: <d4adb108-5762-41d3-897f-217b8e7666e5@163.com> (raw)
In-Reply-To: <7oxb4uviwnpnkdjacihwjrzqhxpd7nk244ivpwml5372jsiimm@5hgnnfjlfkr3>
On 2025/5/2 23:36, Manivannan Sadhasivam wrote:
> On Tue, Apr 29, 2025 at 01:10:24AM +0800, Hans Zhang wrote:
>> 1. PCI: dwc: Standardize link status check to return bool.
>> 2. PCI: mobiveil: Refactor link status check.
>> 3. PCI: cadence: Simplify j721e link status check.
>>
>
> Thanks for the cleanup. Looks good to me except the redundancy conversion that
> Niklas noted. So with that change,
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
Dear Mani,
Thank you very much for your reply. I have sent version v2 to resolve
Niklas' review opinions.
Best regards,
Hans
> - Mani
>
>> Hans Zhang (3):
>> PCI: dwc: Standardize link status check to return bool.
>> PCI: mobiveil: Refactor link status check.
>> PCI: cadence: Simplify j721e link status check.
>>
>> drivers/pci/controller/cadence/pci-j721e.c | 6 +-----
>> drivers/pci/controller/dwc/pci-dra7xx.c | 2 +-
>> drivers/pci/controller/dwc/pci-exynos.c | 4 ++--
>> drivers/pci/controller/dwc/pci-keystone.c | 5 ++---
>> drivers/pci/controller/dwc/pci-meson.c | 6 +++---
>> drivers/pci/controller/dwc/pcie-armada8k.c | 6 +++---
>> drivers/pci/controller/dwc/pcie-designware.c | 2 +-
>> drivers/pci/controller/dwc/pcie-designware.h | 4 ++--
>> drivers/pci/controller/dwc/pcie-dw-rockchip.c | 2 +-
>> drivers/pci/controller/dwc/pcie-histb.c | 9 +++------
>> drivers/pci/controller/dwc/pcie-keembay.c | 2 +-
>> drivers/pci/controller/dwc/pcie-kirin.c | 7 ++-----
>> drivers/pci/controller/dwc/pcie-qcom-ep.c | 4 ++--
>> drivers/pci/controller/dwc/pcie-qcom.c | 2 +-
>> drivers/pci/controller/dwc/pcie-rcar-gen4.c | 2 +-
>> drivers/pci/controller/dwc/pcie-spear13xx.c | 7 ++-----
>> drivers/pci/controller/dwc/pcie-tegra194.c | 2 +-
>> drivers/pci/controller/dwc/pcie-uniphier.c | 2 +-
>> drivers/pci/controller/dwc/pcie-visconti.c | 2 +-
>> drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c | 9 ++-------
>> drivers/pci/controller/mobiveil/pcie-mobiveil.h | 2 +-
>> 21 files changed, 34 insertions(+), 53 deletions(-)
>>
>>
>> base-commit: 286ed198b899739862456f451eda884558526a9d
>> --
>> 2.25.1
>>
>
prev parent reply other threads:[~2025-05-02 16:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 17:10 Hans Zhang
2025-04-28 17:10 ` [PATCH 1/3] PCI: dwc: " Hans Zhang
2025-04-29 8:05 ` Niklas Cassel
2025-04-29 8:21 ` Hans Zhang
2025-04-28 17:10 ` [PATCH 2/3] PCI: mobiveil: Refactor link status check Hans Zhang
2025-04-28 17:10 ` [PATCH 3/3] PCI: cadence: Simplify j721e " Hans Zhang
2025-05-02 15:36 ` [PATCH 0/3] Standardize link status check to return bool Manivannan Sadhasivam
2025-05-02 16:10 ` Hans Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4adb108-5762-41d3-897f-217b8e7666e5@163.com \
--to=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®