From: Phillip Lougher <phillip@squashfs.org.uk>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] squashfs: Fix a NULL vs IS_ERR() bug
Date: Tue, 14 Jan 2025 21:06:05 +0000 [thread overview]
Message-ID: <d4adbf20-2d14-4a0f-9f2d-5132f87ec493@squashfs.org.uk> (raw)
In-Reply-To: <7b7f44d6-9153-4d7c-b65b-2d78febe6c7a@stanley.mountain>
On 1/8/25 09:16, Dan Carpenter wrote:
> The __filemap_get_folio() functoin never returns NULL, it returns
> error pointers. This incorrect check would lead to an Oops on the
> following line when we pass "push_folio" to folio_test_uptodate().
>
> Fixes: 43c73ba98b2c ("squashfs; convert squashfs_copy_cache() to take a folio")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Phillip Lougher <phillip@squashfs.org.uk>
prev parent reply other threads:[~2025-01-14 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 9:16 Dan Carpenter
2025-01-14 21:06 ` Phillip Lougher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4adbf20-2d14-4a0f-9f2d-5132f87ec493@squashfs.org.uk \
--to=phillip@squashfs.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®