From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6F4F1E98EA for ; Wed, 15 Jan 2025 11:12:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736939541; cv=none; b=tsKcITXfBUiHq3EpQ9No3YOPw+S/oNL0V9XFfVw3vzS1lIiXZl/1AfvBnJrIiTt/wuEPXMjLyVHhoSQXMEmCOiSgO4Ah5ouMJuzqDp/BTqB5vHIAG+DRraN1AewcKkEhUYLgGScz1aCXoFEXVWPxhTg0e87sDXCdrE7SyFXsihc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736939541; c=relaxed/simple; bh=ncN/6GUyiJWBB7eCcc51tg1zrUiwdh2XnxAt6ZN4BoM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hHCmqkEPVd26gW2t0toDIxpvlwjhngsOEaen0bUOzzUEJsJMu1Chu8AZ8pSLj8AJBLvq6VfI1zlfsbdDS+/FxYKct5Wxyxs+7zZy3uq72KODQAGBbXO4K1KpZXNtGG/CnwkrAaJV+7doKBuTjlW1SYa4zVSUHVK7CyK0K4nFa3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pr0dqjLH; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pr0dqjLH" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-aaecf50578eso1267302466b.2 for ; Wed, 15 Jan 2025 03:12:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736939537; x=1737544337; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zgaAOweQb71OwFhtIsVZvOPhjn8Kd9vaQDqquf4yuhE=; b=pr0dqjLHHrOnVOr/6cV4n4509CnF4cCVUNh6CvC/sanxWWa3g9859/IdYYzWwaT5TP BGq5kaGQiFzghkUQHatNI3NZQ7Uyd23X7bbQXeaGxRvSJut8XSsAWan/kkMr3sUOdGnt Ljs3P9aPFfG+7Ba76+iVHmQZduorlS+EVl9+T75WtT9dF4wU84F/OvcK/RlmQILy1Gld zxzxgNfktawiPewy4QE7C54O7pyzfJJSOGjrhc6+0wXSW/PRJH5fSL6w3DOI8fZXgp3J T06Fw+7eV4ktRRLU/4qJnaCwrqPb/A+Lf6BK/It9pIgyZ9c3SshorrSHEZobTQ/D1ceI 5reQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736939537; x=1737544337; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zgaAOweQb71OwFhtIsVZvOPhjn8Kd9vaQDqquf4yuhE=; b=HEMyX+/O5/hAoK6nxlTcb8Bjo1OtIfGRshLP/CDsiHXaVDHr2LGtuf60aCHQxYN1JJ rQHoTWKBrsO7QOdV1Qpmdy0Ijg/jXTar0xEt/1CDhKMOwpKQBN2pe2MbMDLTCI+HAR19 6xj84g2swNMns7k0p2AGDxbs+vYLnsmrZ3U3BxmJOuhxNEseZ2J9lY6zX06ry/Y3543J NaTj0n8ao8fnyzGY/gVTWzcABDAAXqdESUlFXYXg/U3utHtXH+xs1Kf01Gf+t/flo9Vl e+esxO6wOlY4kkcq4z0zGQpMhnvcoO6q+CczDsv88kUkPaDvhaiIk9VMThHvX0ofJ5H0 xOBA== X-Forwarded-Encrypted: i=1; AJvYcCVN6MQihBkPIVTQrbJrUYO2qu3fq9OJFv4/xlGL7LfTv9Ekjkn5KzhizRYtqvXvW+VCRtMXlgkYVh/DHi0=@vger.kernel.org X-Gm-Message-State: AOJu0Yyw7N0eZQ6CFlc0voBcqnOD9C/R4PNs1HCtJM1ya8eqFD3pmHX4 rn+uKtT2CjYq/VkJf3M6qljn+jkUmhcrLfL04wBsDHrO6fJuSDwA42mCgLUEUnU= X-Gm-Gg: ASbGnct9ayOq5/eqJ/GHZ4QFjM5AjDrjfVobd9SfNutLL0ZfgoykrPpHidRK325MqUQ MUGhOut4jz6USWK0tPDDkZTsrZDNewETlYwNKAZWPUKf6cgoChqRHQmQwPL9AdAJUmknECrjzUE KVTnafAlCV3jpDq53QFf0yql6UX/973mr6LGR8qierbFVTrkQLd8BpDZ/raSc70nUFKF7RCaLxh /65So40XsIL5+jY0/MXmzPJIrQNyvwfOqmBALRizAoPpU7hbGc4fH4FXte3lA== X-Google-Smtp-Source: AGHT+IHJr6V+PPhdzpc+SbrFprkZ471QbDOH3WILGCE4sK4Gu0UuGCEFsPEB6d5nsHlakr+3W70JmA== X-Received: by 2002:a17:906:7f84:b0:ab2:d96d:6364 with SMTP id a640c23a62f3a-ab2d96d888fmr1776570766b.18.1736939536889; Wed, 15 Jan 2025 03:12:16 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c90d7432sm738738966b.49.2025.01.15.03.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 03:12:16 -0800 (PST) Date: Wed, 15 Jan 2025 14:12:13 +0300 From: Dan Carpenter To: Costa Shulyupin Cc: Steven Rostedt , Daniel Bristot de Oliveira , John Kacur , "Luis Claudio R. Goncalves" , Eder Zulian , Tomas Glozar , Gabriele Monaco , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Fix bug and add osnoise_trace_is_off() Message-ID: References: <20250115081157.1274398-1-costa.shul@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250115081157.1274398-1-costa.shul@redhat.com> On Wed, Jan 15, 2025 at 10:09:56AM +0200, Costa Shulyupin wrote: > diff --git a/tools/tracing/rtla/src/osnoise.c b/tools/tracing/rtla/src/osnoise.c > index 245e9344932bc..20275642a74cd 100644 > --- a/tools/tracing/rtla/src/osnoise.c > +++ b/tools/tracing/rtla/src/osnoise.c > @@ -1079,6 +1079,25 @@ struct osnoise_tool *osnoise_init_trace_tool(char *tracer) > return NULL; > } > > +int osnoise_trace_is_off(struct osnoise_tool *tool, struct osnoise_tool *record) > +{ > + /* > + * The tool instance is always present, it is the one used to collect > + * data. > + */ > + if (!tracefs_trace_is_on(tool->trace.inst)) > + return 1; > + > + /* > + * The trace record instance is only enabled when -t is set. IOW, when the system > + * is tracing. > + */ > + if (record && !tracefs_trace_is_on(record->trace.inst)) > + return 1; > + > + return 0; > +} Also this function should be declared as type bool and return true/false instead of 1/0. regards, dan carpenter