From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D30840D57C for ; Wed, 24 Jun 2026 05:22:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782278569; cv=none; b=DavFws7BgqJeGK8RPYlhfP5Zgb16hq4y+Z7VmsB6GdXbejivtAvLy+uMlSpK/HatdRRZFCOPpFNOg02YM/IP5zSXzzEf9ldPf9CiULwS8tzhDE1su4BgSHbMN1ZNFkAbrdMGNMAGKhJDf+8bBCPcoBH2VFaDqZjrKXGBVUHce0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782278569; c=relaxed/simple; bh=hIXUOL4fGMi4swSJbx+aZ+2m9+M7yu7xbm87OoowSbI=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=CwcNkQZPCUmHz5zLtm5SNnLhY0jKDs936cKoPQEUqxbjWTrI0dKssFIoPjmcjqxz5Zr+rPJMbFqUH/DHbJOgbxTB4AeVd8bVMg1iSX8NseAcL9tVKJ/p1WIpH4E9xxxGUO5hqwv/N6TAMD0madB/ywf8FHj+zHXqQ72HezVmoVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oGAH9RQv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oGAH9RQv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B67771F000E9; Wed, 24 Jun 2026 05:22:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782278568; bh=TpJQ4kj/Wi2sLR2FmshDH2uPJgKrR08cjdzGJ/R+mFQ=; h=Date:Subject:To:References:From:In-Reply-To; b=oGAH9RQvwcKZfk4Cs9DkpNe9XxNkakNCTJI6NFAhBZPRI54XS4JwrJnH3m04/PEym N9711YO3VXGxfav2opiS7JzM/A0Sbr+olbeD2whcgPTfCaDh2SjUNzUXnW9fcGtfca McKq5XEgshU/lce0XOwmqBY58bZpYh9oDr0BAUT7m6qK0aQpsAR4nzPtACwM0QdrCo dt+pEQ/ZKjX+6INgd8MkFmA9hx3j0GTgRwb1p0y2cL15UTHB7IjE7gBQ6VUqOgLsy2 hs8KJIL/t2/giN2G0Z7HeWM3716AaWw4GTx7WBdSsFwzpLaWIthKuRdrzDXlRiwG71 phhvZDHTIAidA== Message-ID: Date: Wed, 24 Jun 2026 00:22:47 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] firmware: stratix10-svc: fix memory leaks and list corruption bugs Content-Language: en-US To: tze.yee.ng@altera.com, Richard Gong , Greg Kroah-Hartman , Alan Tull , linux-kernel@vger.kernel.org References: From: Dinh Nguyen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/23/26 22:47, tze.yee.ng@altera.com wrote: > From: Tze Yee Ng > > Fix a memory leak when gen_pool_alloc() fails by freeing pmem on the error > path. Switch pmem allocation from devm_kzalloc() to kzalloc() with > explicit kfree() in the free path to match its list-managed lifetime. > Remove the erroneous list_del(&svc_data_mem) which corrupted the list head > on failed lookups. > > Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver") > Cc: stable@vger.kernel.org # 5.0+ > Remove blank line. > Signed-off-by: Tze Yee Ng > --- > Changes in v2: > - Remove if (!chan || !kaddr) early return from stratix10_svc_free_memory() > per review; failed lookup is handled by dropping list_del(&svc_data_mem). > - Add Cc: stable@vger.kernel.org # 5.0+. > - Minor commit message cleanup (lifetime spelling, subject line). > --- Dinh