mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Fritz <chf.fritz@googlemail.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] regulator: fan53880: Convert to use .probe_new
Date: Tue, 18 May 2021 14:00:28 +0200	[thread overview]
Message-ID: <d4b936d1de6a1ad6d43fe9070ab5c712851eec52.camel@googlemail.com> (raw)
In-Reply-To: <20210517105325.1227393-2-axel.lin@ingics.com>

On Mon, 2021-05-17 at 18:53 +0800, Axel Lin wrote:
> Use the new .probe_new for fan53880.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Christoph Fritz <chf.fritz@googlemail.com>

> ---
> v2: no change
>  drivers/regulator/fan53880.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/regulator/fan53880.c b/drivers/regulator/fan53880.c
> index 1684faf82ed2..f3268b4d5066 100644
> --- a/drivers/regulator/fan53880.c
> +++ b/drivers/regulator/fan53880.c
> @@ -114,8 +114,7 @@ static const struct regmap_config fan53880_regmap = {
>  	.max_register = FAN53880_ENABLE_BOOST,
>  };
>  
> -static int fan53880_i2c_probe(struct i2c_client *i2c,
> -			     const struct i2c_device_id *id)
> +static int fan53880_i2c_probe(struct i2c_client *i2c)
>  {
>  	struct regulator_config config = { };
>  	struct regulator_dev *rdev;
> @@ -177,7 +176,7 @@ static struct i2c_driver fan53880_regulator_driver =
> {
>  		.name = "fan53880",
>  		.of_match_table	= of_match_ptr(fan53880_dt_ids),
>  	},
> -	.probe = fan53880_i2c_probe,
> +	.probe_new = fan53880_i2c_probe,
>  	.id_table = fan53880_i2c_id,
>  };
>  module_i2c_driver(fan53880_regulator_driver);



  reply	other threads:[~2021-05-18 12:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 10:53 [PATCH v2 1/2] regulator: fan53880: Fix missing n_voltages setting Axel Lin
2021-05-17 10:53 ` [PATCH v2 2/2] regulator: fan53880: Convert to use .probe_new Axel Lin
2021-05-18 12:00   ` Christoph Fritz [this message]
2021-05-18 12:00 ` [PATCH v2 1/2] regulator: fan53880: Fix missing n_voltages setting Christoph Fritz
2021-05-18 16:31 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4b936d1de6a1ad6d43fe9070ab5c712851eec52.camel@googlemail.com \
    --to=chf.fritz@googlemail.com \
    --cc=axel.lin@ingics.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®