From: "Cédric Le Goater" <clg@kaod.org>
To: Pratyush Yadav <p.yadav@ti.com>, Patrick Williams <patrick@stwcx.xyz>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
<linux-aspeed@lists.ozlabs.org>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Richard Weinberger <richard@nod.at>,
Potin Lai <potin.lai@quantatw.com>,
<linux-kernel@vger.kernel.org>, Michael Walle <michael@walle.cc>,
<linux-mtd@lists.infradead.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] mtd: aspeed-smc: improve probe resilience
Date: Sun, 23 Jan 2022 23:44:05 +0100 [thread overview]
Message-ID: <d4ba6413-57ce-14c1-ed48-d00db2f74bd3@kaod.org> (raw)
In-Reply-To: <20220105063244.lno3xur64uepa7i5@ti.com>
>> I had an offline discussion with someone who knew more history on this driver.
>> My understanding is that the linux-aspeed team is aware of this being deprecated
>> but that there was some missing support for interface training that nobody has
>> gotten around to write? If that is the case this really isn't even a "simple"
>> port to a new API at this point.
>
> Unless the controller needs some unique feature (I don't think it does
> on a quick glance), the conversion should not be too difficult. For any
> experienced developer, even if they are unfamiliar with the SPI MEM API,
> I don't think it should take more than 2-3 days to do the conversion.
> The code to program the registers would stay the same, all that needs to
> change is the API through which it is accessed.
Writing a spimem driver is not a problem, I think people have done
that in house. Aspeed has one for AST2600. We have one for u-boot
I wrote sometime ago. I even have one for Linux but training comes
with ugly hacks to fit in the current stack.
All Aspeed SoCs need training and that has been the problem for the
last 4 years or so because we can not do training without knowing
a minimum about the flash being trained :/ The previous framework
offered a way to do a first scan and tune the delay settings
afterwards. It worked pretty well on AST2400, AST2500 and AST2600
even if more complex.
One alternative was to include the setting in the DT but the flash
modules are not always soldered on the boards, at least on OpenPOWER
systems which have sockets for them. The board are large, the wires
long, the need is real, some chips freak out if not tuned correctly.
spimem needs an extension I think. Sorry I have not been able to
push that forward. Lack of time and other tasks to address on the
host side of the machine. This is really a software problem, we
have the HW procedures ready. If a spimem expert could get involved
to make a few proposals, I would be happy to help and do some testing.
QEMU models are good enough for the software part. We can do the
training validation on real HW when ready.
Thanks,
C.
next prev parent reply other threads:[~2022-01-23 23:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 14:33 Patrick Williams
2021-12-29 17:34 ` Pratyush Yadav
2021-12-30 15:29 ` Patrick Williams
2021-12-31 10:26 ` Pratyush Yadav
2022-01-03 16:17 ` Miquel Raynal
2022-01-04 18:20 ` Patrick Williams
2022-01-05 6:32 ` Pratyush Yadav
2022-01-23 22:44 ` Cédric Le Goater [this message]
2022-01-24 15:36 ` Pratyush Yadav
2022-01-24 18:34 ` Cédric Le Goater
2022-01-24 20:37 ` Pratyush Yadav
2022-02-07 17:13 ` Cédric Le Goater
2022-02-08 19:06 ` Pratyush Yadav
2022-01-23 15:39 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4ba6413-57ce-14c1-ed48-d00db2f74bd3@kaod.org \
--to=clg@kaod.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=patrick@stwcx.xyz \
--cc=potin.lai@quantatw.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®