From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD29023BD1D for ; Fri, 17 Jul 2026 00:55:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784249725; cv=none; b=Wc+QY3bZpxwAq+AZ1mUnk84bJmZVHPYx7eZc2vhA1zPwzPPXdQRBYzmGURlhTVC8H4xW/qxpcSE+LfInrHMuUg9Y8c57CG9ibJ2PD7bFFjiEhCwUFcRltToncJyxgyZyPh/tdR2bF4MxZ3D/7ta1oeIAa2sJr/MBZyR+XCXN/qU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784249725; c=relaxed/simple; bh=y6mJcRy5SXp68aaWGT5+DGtvBSpSjbEtT/Tsyi4FBBE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KI8C7Kgn9aWCmU7eyagbwwF91nLC81gWeZ8Jm1hMjkYyxpQviWcyZYpVZa4m+hivTeja9ZKEuDu2FJUK9tTpw8qxDi8QoqSMTo9NuxkbFWznqMz2+RvrIkAJUHzzbV2RWtsG3+fLWvUQUPX04TvgLSniSUGrLdhOcR8vr+MQ6ds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XmINRbvz; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=TzLeKbO5; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XmINRbvz"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="TzLeKbO5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784249722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/3wHfrhG8FmNFUVWyPEvhZctAHFHZYrAF6KnLEZZvCQ=; b=XmINRbvzZ2Sp0frk+AzjiQnN8i5lS6gsTOZrs32so4qkzwzFFhY/DzrKagRTJV3OM0v0dx agZm/Xop8IPY/JDcxhn87jRm3DVDHy7gIViZTcnqIo3TTEl082VukfIdp/kXO+s2nkhcUO tlEg6vmCBeRIvptrn7UJ/E+2AGHzvfk= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-686-YPCgoy6JMc-s8fInVaeCFQ-1; Thu, 16 Jul 2026 20:55:20 -0400 X-MC-Unique: YPCgoy6JMc-s8fInVaeCFQ-1 X-Mimecast-MFC-AGG-ID: YPCgoy6JMc-s8fInVaeCFQ_1784249719 Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c96b4f58ddcso3904622a12.3 for ; Thu, 16 Jul 2026 17:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784249719; x=1784854519; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/3wHfrhG8FmNFUVWyPEvhZctAHFHZYrAF6KnLEZZvCQ=; b=TzLeKbO5TwYdxeO/2yJ2ZRLOR6y75UQ5fDUytpkKW1e8BEDy8F96KuL/8cwIGcS1b9 bN36ihy9jAd29F20phWlZvf6+XiOSbM0QJ3ANVNW83e5ffnSZHBTG641Nx6pHdxfwIxI qD8LA2Vcr8F2e7sQbClj54w7JdNH9dUzfYuz629ZDaMCOKiI2B7fLCdr+bVzm+MxKGV5 Osxj5tWjObRc1rGL1AdZa9ZpkhMDivMwJByYIDsC8562PcsvbRM3f1CxgsgQyKmqhsjB 1L3SOejqTgZxcTxfy7IDqTjkUsF23fLgpLy6if85KnM1LldO/uEw7jgW4nrI7vC77QjA ke/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784249719; x=1784854519; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/3wHfrhG8FmNFUVWyPEvhZctAHFHZYrAF6KnLEZZvCQ=; b=dS+lBGCc644XFbz19FT1GFDgVxb3OllhFlulMHM65VCcSwMI0xHNnsphVo7oZ8L+hE GFzb4Tl36VEZPqa6hKlrN6FWGVBVR7kK4chnsFrGqxcLjU4NXLquvXPUrk4X0A6St8/z 90uUveWbVw0voOJsttpvqeXnXH7Bth9iSCpKrXNCUM2puK8gGyRHB2VG8pt/Vs9BRR24 OyoNOlUJZRElpSkLHs9jekd+EtUcspoq7TTzvIaHqvF3hXowqKoG9MocA9fXzZUi54K0 C6nY+aFzgw4OK7cgndjN2o+HyOd+eFimulZeAFIqnfI7GFafNT9XAwWhy6T+b3oFcI6C tBnw== X-Forwarded-Encrypted: i=1; AHgh+RobaQzaSJTBZ1dE5xxcdsj4IXTo7W1fii7pyO8YwhyhDrtDD+9hfoKLz7OdnEda84ZZJoI09PrqBY9dmms=@vger.kernel.org X-Gm-Message-State: AOJu0YwkWDeQHklhwsufRR3yuYJC4WpYB7jzkZcswiCJ2VKY5FD9FLnM 92p7Y4WbJ0SES/fJJJbzA/nzoZ7TCbhJcC+EhbvuxUJpwJcyqpVnlpyrPfvDqH3maW0obu6GCNx ojg+ujDxRql+EZtEktESbIUHBoG8fvArQUu9jjXerbbKbyBxjjRAaOIDoWsPaXpFA0A== X-Gm-Gg: AfdE7ckeVrHnNB1aRH9hVpmKUS0gycX30hkSDUCoBG2Or+FdmPUScqe9F8WUNTpsS7R sIUF753gDr/1F50OnIo+ioRVNYj4RvsFlzWckvg2ZlQZnwNzW4CIn6tOHERRZECJHfwCD2t1o+t vx0msf96/Y+2nPUbbFa5VqSAluA+lifvMzd5h8+46TdxDtP28aaQpcrDumRs34quQQDmEOtNTLX GeLAcIiQZno2oLIYMOYouz989d+UPfFEz50sPUbdKy84ThFcY2UZ6TndF9gLXS+3Z7ElQ+8pa+Q GqY/mVfdZDimeMo9M/JC9sjGhG9GU5PswXsrI8zw0AmU1xw4CPvPd23dB5dz3WNCAVeHHMnPCXp 053SXIQ0cY/c06e/F9fmzNlBQ9dM5iMmqpP75LYG6Rtk= X-Received: by 2002:a05:6a20:4326:b0:3c3:76f7:d66a with SMTP id adf61e73a8af0-3c3ad665994mr318193637.13.1784249719185; Thu, 16 Jul 2026 17:55:19 -0700 (PDT) X-Received: by 2002:a05:6a20:4326:b0:3c3:76f7:d66a with SMTP id adf61e73a8af0-3c3ad665994mr318163637.13.1784249718707; Thu, 16 Jul 2026 17:55:18 -0700 (PDT) Received: from [192.168.68.51] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429fdcb09sm793009eec.9.2026.07.16.17.55.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 17:55:18 -0700 (PDT) Message-ID: Date: Fri, 17 Jul 2026 10:55:12 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 07/11] arm_mpam: Initialize all of struct mon_read in mpam_restore_mbwu_state() To: Ben Horgan Cc: james.morse@arm.com, reinette.chatre@intel.com, fenghuay@nvidia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dave.martin@arm.com, andre.przywara@arm.com References: <20260710115546.29644-1-ben.horgan@arm.com> <20260710115546.29644-8-ben.horgan@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20260710115546.29644-8-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/10/26 9:55 PM, Ben Horgan wrote: > m->err may be read before initialization in __ris_msmon_read() when called > from mpam_restore_mbwu_state(). > > Initialize the whole struct mon_read in mpam_restore_mbwu_state() and fix > the spelling of mbwu in the name. > > Fixes: 41e8a14950e1 ("arm_mpam: Track bandwidth counter state for power management") > Signed-off-by: Ben Horgan > --- > drivers/resctrl/mpam_devices.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > Reviewed-by: Gavin Shan