From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: host: omap: Do not enable by default during compile testing
Date: Thu, 17 Apr 2025 10:27:28 +0200 [thread overview]
Message-ID: <d4bfefc7-cdd0-46d7-aa0e-d038f3c43e36@linaro.org> (raw)
In-Reply-To: <2025041747-cruncher-exposure-590c@gregkh>
On 17/04/2025 10:22, Greg Kroah-Hartman wrote:
> On Thu, Apr 17, 2025 at 09:46:34AM +0200, Krzysztof Kozlowski wrote:
>> Enabling the compile test should not cause automatic enabling of all
>> drivers, but only allow to choose to compile them.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> For longer rationale:
>> https://lore.kernel.org/all/191543a8-2e2e-4ac4-9b2b-d253820a0c9f@app.fastmail.com/
>> ---
>> drivers/usb/host/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>> index d011d6c753ed..6dedacba94b3 100644
>> --- a/drivers/usb/host/Kconfig
>> +++ b/drivers/usb/host/Kconfig
>> @@ -225,7 +225,7 @@ config USB_EHCI_HCD_OMAP
>> tristate "EHCI support for OMAP3 and later chips"
>> depends on ARCH_OMAP || COMPILE_TEST
>> depends on NOP_USB_XCEIV
>> - default y
>> + default ARCH_OMAP
>
> Should this get a "Fixes:" tag as well?
>
I think not, because some people's intention was to enable everything
during compile test, thus it was not a bug, but a feature.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-04-17 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 7:46 Krzysztof Kozlowski
2025-04-17 8:22 ` Greg Kroah-Hartman
2025-04-17 8:27 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4bfefc7-cdd0-46d7-aa0e-d038f3c43e36@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®