From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B5B7C433E0 for ; Thu, 4 Feb 2021 07:06:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA51F64DF4 for ; Thu, 4 Feb 2021 07:06:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232685AbhBDHGK (ORCPT ); Thu, 4 Feb 2021 02:06:10 -0500 Received: from smtprelay0235.hostedemail.com ([216.40.44.235]:43824 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229998AbhBDHGH (ORCPT ); Thu, 4 Feb 2021 02:06:07 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 45834180A911F; Thu, 4 Feb 2021 07:05:24 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: tank64_5c15dea275da X-Filterd-Recvd-Size: 1662 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Thu, 4 Feb 2021 07:05:23 +0000 (UTC) Message-ID: Subject: Re: [PATCH] firewire: convert sysfs sprintf/snprintf family to sysfs_emit From: Joe Perches To: Jiapeng Chong , stefanr@s5r6.in-berlin.de Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Date: Wed, 03 Feb 2021 23:05:22 -0800 In-Reply-To: <1612421432-39124-1-git-send-email-jiapeng.chong@linux.alibaba.com> References: <1612421432-39124-1-git-send-email-jiapeng.chong@linux.alibaba.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-02-04 at 14:50 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/firewire/core-device.c:375:8-16: WARNING: use scnprintf or > sprintf. [] > diff --git a/drivers/firewire/core-device.c b/drivers/firewire/core-device.c [] > @@ -372,8 +372,7 @@ static ssize_t rom_index_show(struct device *dev, >   struct fw_device *device = fw_device(dev->parent); >   struct fw_unit *unit = fw_unit(dev); >   > > - return snprintf(buf, PAGE_SIZE, "%d\n", > - (int)(unit->directory - device->config_rom)); > + return sysfs_emit(buf, "%d\n", (int)(unit->directory - device->config_rom)); Perhaps this should use the ptrdiff_t qualifier '%td' instead: return sysfs_emit(buf, "%td\n", unit->directory - device->config_rom);