From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA58C4363D for ; Thu, 24 Sep 2020 13:02:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 763E42220D for ; Thu, 24 Sep 2020 13:02:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727853AbgIXNCj (ORCPT ); Thu, 24 Sep 2020 09:02:39 -0400 Received: from mx3.molgen.mpg.de ([141.14.17.11]:47221 "EHLO mx1.molgen.mpg.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727475AbgIXNCj (ORCPT ); Thu, 24 Sep 2020 09:02:39 -0400 Received: from [141.14.13.128] (g383.RadioFreeInternet.molgen.mpg.de [141.14.13.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 2BF8220646203; Thu, 24 Sep 2020 15:02:36 +0200 (CEST) Subject: Re: [Intel-wired-lan] [PATCH] e1000e: Power cycle phy on PM resume To: Andrew Lunn Cc: Kai-Heng Feng , Jeff Kirsher , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Jakub Kicinski , "David S. Miller" References: <20200923074751.10527-1-kai.heng.feng@canonical.com> <17092088-86ff-2d31-b3de-2469419136a3@molgen.mpg.de> <79f01082-c9b1-f80a-7af4-b61bdbf40c90@molgen.mpg.de> <20200923192813.GE3764123@lunn.ch> From: Paul Menzel Message-ID: Date: Thu, 24 Sep 2020 15:02:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200923192813.GE3764123@lunn.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Andrew, Am 23.09.20 um 21:28 schrieb Andrew Lunn: >>>> How much does this increase the resume time? > > Define resume time? Until you get the display manager unlock screen? > Or do you need working networking? Until network is functional again. Currently, the speed negotiation alone takes three(?) seconds, so making it even longer is unacceptable. (You wrote it below.) > It takes around 1.5 seconds for auto negotiation to get a link. I know > it takes me longer than that to move my fingers to the keyboard and > type in my password to unlock the screen. So by the time you actually > get to see your desktop, you should have link. Not here. > I've no idea about how the e1000e driver does link negotiation. But > powering the PHY off means there is going to be a negotiation sometime > later. But if you don't turn it off, the driver might be able to avoid > doing an autoneg if the PHY has already done one when it got powered > up. Indeed. Kind regards, Paul