From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752123AbdBOP1Y (ORCPT ); Wed, 15 Feb 2017 10:27:24 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:38475 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751485AbdBOP1F (ORCPT ); Wed, 15 Feb 2017 10:27:05 -0500 Subject: Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible To: Felipe Balbi References: <1487158704-9006-1-git-send-email-rogerq@ti.com> <1487158704-9006-3-git-send-email-rogerq@ti.com> <87poijoez9.fsf@linux.intel.com> CC: , , , , From: Roger Quadros Message-ID: Date: Wed, 15 Feb 2017 17:25:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <87poijoez9.fsf@linux.intel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/02/17 13:44, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> To avoid checkpatch warnings with new patches let's >> start using the BIT() macro wherever possible. >> >> Signed-off-by: Roger Quadros >> --- >> drivers/usb/dwc3/core.h | 192 +++++++++++++++++++++---------------------- >> drivers/usb/dwc3/dwc3-omap.c | 48 +++++------ >> drivers/usb/dwc3/gadget.h | 20 ++--- >> 3 files changed, 130 insertions(+), 130 deletions(-) >> >> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h >> index 14b7602..d514dca 100644 >> --- a/drivers/usb/dwc3/core.h >> +++ b/drivers/usb/dwc3/core.h >> @@ -65,7 +65,7 @@ >> #define DWC3_DEVICE_EVENT_OVERFLOW 11 >> >> #define DWC3_GEVNTCOUNT_MASK 0xfffc >> -#define DWC3_GEVNTCOUNT_EHB (1 << 31) >> +#define DWC3_GEVNTCOUNT_EHB BIT(31) > > don't you need to include for this? > I didn't get any build errors though. -- cheers, -roger