From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49598282F3C for ; Wed, 17 Jun 2026 11:05:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781694315; cv=none; b=prLwutqNw+Hbg2iUTraoxG+/eP/PVh6TZpev7qTlzEzqFxxFSjbJPtgKedopTx+y+ozhPwqw1x/2YWhJH3zN8POUtX3801hmbLleAxRf1U1cKJbbmT1uyHssq0kudEL6kl0zuf5/9y68e282Hr7l/O7ieRkOSxte3YQbx7iJLrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781694315; c=relaxed/simple; bh=eEiU8vMu+5O1vd1w6lRUiGs5KR7SZ5QpDvtIFlNlRTo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IAGgzZJ77st0f2uIrshBzwtaF9MA9J9zLssQLm3gSYxJQqNXWZgiBnkyzvQ1c461BKIYO4WoXe39l+10oWssMVwZsHcNo03KAvhbm5AKFNpWMAKOMBq7v6Ad8yIxTHv6cOxIN06VvvnWQjE3Oeclq/NSpJK621/SyTst7EChEIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jGa+OMAW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ln+IoiOk; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jGa+OMAW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ln+IoiOk" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65H8V6852291343 for ; Wed, 17 Jun 2026 11:05:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qj70XiMRBk88XSknFY6Ir5XzqLm8axeDAtiCmENjOvs=; b=jGa+OMAWzW2QNASV RBhcQINUjagf0ZQcla7SH4cLO/fG4+60rqMscZWpAkwf/C2OMNtmHZxWWUKTtSv7 /oY/yXoeIcwDjr4AfJN1m9yHnfrDpCWN73Wc/iF0/q17X3FclXRdxDSjjKgCgzRM a1SnLoNeTUbyhEhMhDckcuLOZK6rA6c5SajdnW4DXcEgR84qlcSFBfhxpPkZvqp6 GVahBusdh/Ui43hOBMHHX4qt66W5GBK5JOI2Yzvu4mfGTh8CLWDaH+jW8NoaWHWE X1Y0j1xXRuwj+n6/CHANhdCHMWwqRE0FJRODDTaVgX7ra/KtaqyDCiO/XCBVH275 fBNA9w== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eueevjuf8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Jun 2026 11:05:12 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-915a4ca0a4aso74301085a.1 for ; Wed, 17 Jun 2026 04:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781694311; x=1782299111; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qj70XiMRBk88XSknFY6Ir5XzqLm8axeDAtiCmENjOvs=; b=Ln+IoiOkYz6u+PEe5FIvnPwIBKZDYH09Lk3fX5rxjfXoBM7zKHtkNydcS2KxeJ9jmS 0oTcSx5SRPQ0uIoSk+Y87QDDHtid7vy5jEwrUPuGpZD8nI/usTG8hgKThSk8gE9rgRMC KzJ8Uyp2CG1Ub2mHGBX9uNgu4AXHNHEt/PRtG2nlgGIdkXBcqP6yu+0WMq5BLE7v8y5A H2dnOSG738ktKlkLDvXTVSVoZk8hnpS0vQDBfCHjwz/TnXfgJSEPhlIULTr4JDo3HwBF hrZrTrQApnxSw6kXxT9vpft54etS9DuH9nG4hw6sQXYpHTVdG7CdRu6maPRdiVfKnxda 0eRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781694311; x=1782299111; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qj70XiMRBk88XSknFY6Ir5XzqLm8axeDAtiCmENjOvs=; b=rpJNT9OSlyth9Q4pxFjhRUTCpv/YSC4yrg++b9AO3WTmj6dGvfr3fsFBD8Ts6hKqs+ Z+FLEAK7m/h1iZwe+xiM7BSzA1cCFmILi0y70FdU8SEld1loqinl0VEM67GPYYm48I7W 1+ISsJ7QUFkzld2zqX6aOxd1RQfWe4BoJ2nwy5H/YU33/sHmnZBR+OARXfMZ6a553yc6 B1FekSwsM0zZHPBy9gDCQf/OgWtuhP0FFOCgdh7YJUU8VjkpmAa5cdfijAz+qwAWBI9e axPBDPsYghIlN4vuf8KK6K+Z9X3h2aYQ5LVDdan9EVSDrutY8iLPa/DbLHtU4YQHa+ga ie7w== X-Forwarded-Encrypted: i=1; AFNElJ8USTiQVwyYbnNGqCLvXwfI1CvK6E6EQKwCSkfQWKKGBr6YEpeNVRjNKuC0edGi8nsWwVRoufFEpp9wlWI=@vger.kernel.org X-Gm-Message-State: AOJu0YygmWn4lQV9Exq8CmiETrxHEp2YSBeYOcULuiP/miM4LpvJgoq/ WAQjLBHfizDn9rYEDgnRkVcN4Fx6rur5v42gw9yY67r8D3Z7jZH+TVCCaUsR6LYsMEFGXF1GTTF FTz3zFB6mTtvdtxxZoB6XE3IqAyqy3f3ohQ0GNkuYAA1aaGFysPhBaErZrmTDvojHdg4= X-Gm-Gg: Acq92OG8clc2BenWPkNEhqhy3plMLOgF3M8NOhaX/1wJqsfhIw1sYZeyvCCQ2Ij/Hjs VWpirhqzjhyhKAetDiwHX6rzxYJj/GCta1mt9PhmVtgYtgZb75Jx3N9x5/6hdktxNRYueSV1ZS0 xZZpJKL6bit7b41oWOnrwmicWjLM9szNXFmLr7GmEj42T9/wb2DjkPoNdj/fGRmabxUlPCHRd3p RTdQ+Kw9+KCMEXRhukMCC0k2EYD5ymsEiNLWxo+spQNo0BehDHt5szyd0K6LprtrbC7MppCvhGT pRF8w12soN4gPfPBdisJb2QMpYMnptPmy6a5RsY/66NlP1X3kzt6ND4C8GD3I+70KxVe/R3Ku+t BErXHGYS/dAAkFg3P8E/JAN9+SCPCf2bdNlk= X-Received: by 2002:a05:620a:6286:b0:914:ea37:6f14 with SMTP id af79cd13be357-91d8aae2593mr337700585a.1.1781694311555; Wed, 17 Jun 2026 04:05:11 -0700 (PDT) X-Received: by 2002:a05:620a:6286:b0:914:ea37:6f14 with SMTP id af79cd13be357-91d8aae2593mr337696685a.1.1781694311144; Wed, 17 Jun 2026 04:05:11 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb8b23f8fsm760459866b.53.2026.06.17.04.05.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2026 04:05:10 -0700 (PDT) Message-ID: Date: Wed, 17 Jun 2026 13:05:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] spi: qcom-geni: Enable SPI on SA8255p Qualcomm platforms To: Praveen Talari , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , bjorn.andersson@oss.qualcomm.com Cc: linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mukesh.savaliya@oss.qualcomm.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, chiluka.harish@oss.qualcomm.com References: <20260604-enable-spi-on-sa8255p-v3-0-43984eac4c67@oss.qualcomm.com> <20260604-enable-spi-on-sa8255p-v3-4-43984eac4c67@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260604-enable-spi-on-sa8255p-v3-4-43984eac4c67@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE3MDEwNCBTYWx0ZWRfX1Qa8bo4a5bv1 aq4JJWQUS8yMygrm6Sa75KB4GMLcDOq/dpqzXq8lk6r/KiY2L1MeVO4q+oca/r7G2mY3rEfqeQg B95pMoF9L1QJNcY0A328hadOpiB/IeIn+qWc6s+X7kref92BpmHGmSVo41ur+E0YtDMcLaIWKVU 6xVDXs10xMqyuNmhyBoqNHnUbOmynmdRm8ObDwUAmI/KRQmnFnu48pp8xAtnHEbsy9mfFN5LhDH FUdK0CxI9r7QU5UoFnpmAdSFc76xcuL8NRZAaH3h9U3kJG2bjojsqekyL97t43Kc5cvQUICQWyO d1t1AvFuy7Uw2XHh5oQILrMvb3sXCePqzc0e+L0EVD6Ta3BTPq7xY+Xa9+b3zi9EkZThkykL+Dk iuA971P8tQoAGA4S092FXxgkVnkAxrL6m4XNyxuODs+nXJC7KUh1DLxHY5L1GIW7yJG/u0ubxnM Rp856oYidE+huRzBa/Q== X-Authority-Analysis: v=2.4 cv=LM1WhpW9 c=1 sm=1 tr=0 ts=6a327f68 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=Ow8ltAAN0bl1iHkyYvMA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: YlYQlmqjQaFRahvHpGAG9CmtQtdFSieu X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE3MDEwNCBTYWx0ZWRfX7AVfbarLcjfI LP8ZJF+3u/iDNN3nzPpvDBVfvyT1GCwTNS5gEFYsYpOIDNOv086Eeekc7GUA/rA/eYlVzixI5jw wwV24Bc64wfIXjnwxtf6OebR2QTnAT0= X-Proofpoint-ORIG-GUID: YlYQlmqjQaFRahvHpGAG9CmtQtdFSieu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-17_01,2026-06-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 malwarescore=0 priorityscore=1501 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606170104 On 6/4/26 8:50 AM, Praveen Talari wrote: > The Qualcomm automotive SA8255p SoC relies on firmware to configure > platform resources, including clocks, interconnects and TLMM. > The driver requests resources operations over SCMI using power > and performance protocols. > > The SCMI power protocol enables or disables resources like clocks, > interconnect paths, and TLMM (GPIOs) using runtime PM framework APIs, > such as resume/suspend, to control power states(on/off). > > The SCMI performance protocol manages SPI frequency, with each > frequency rate represented by a performance level. The driver uses > geni_se_set_perf_opp() API to request the desired frequency rate. > > As part of geni_se_set_perf_opp(), the OPP for the requested frequency > is obtained using dev_pm_opp_find_freq_floor() and the performance > level is set using dev_pm_opp_set_opp(). > > Signed-off-by: Praveen Talari > --- [...] > - ret = geni_se_resources_init(&mas->se); > + mas->dev_data = device_get_match_data(&pdev->dev); This really needs to be null-checked Perhaps also the functions within that are called unconditionally Konrad