From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE49DC2BBC7 for ; Thu, 9 Apr 2020 08:49:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 260DA21973 for ; Thu, 9 Apr 2020 08:42:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726671AbgDIImS (ORCPT ); Thu, 9 Apr 2020 04:42:18 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:45390 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725987AbgDIImS (ORCPT ); Thu, 9 Apr 2020 04:42:18 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id AB59DAC02DEF2497F8AE; Thu, 9 Apr 2020 16:42:06 +0800 (CST) Received: from [127.0.0.1] (10.173.220.183) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Thu, 9 Apr 2020 16:41:58 +0800 Subject: Re: [PATCH] signal: check sig before setting info in kill_pid_usb_asyncio To: Christian Brauner CC: , , , , , , "linux-kernel@vger.kernel.org" , Mingfangsen , Yanxiaodan , linfeilong References: <20200330084415.p4v5g6s24innsjrc@wittgenstein> <2d00096f-94f7-753e-c05f-14860fed2abe@huawei.com> From: Zhiqiang Liu Message-ID: Date: Thu, 9 Apr 2020 16:41:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.220.183] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/9 14:53, Christian Brauner wrote: > On April 9, 2020 5:26:08 AM GMT+02:00, Zhiqiang Liu wrote: >> Friendly ping... >> >> On 2020/3/30 16:44, Christian Brauner wrote: >>> On Mon, Mar 30, 2020 at 10:18:33AM +0800, Zhiqiang Liu wrote: >>>> >>>> In kill_pid_usb_asyncio, if signal is not valid, we do not need to >>>> set info struct. >>>> >>>> Signed-off-by: Zhiqiang Liu >>> >>> I'd have done: >>> >>> if (!valid_signal(sig)) >>> return -EINVAL; >>> >>> instead of setting ret to EINVAL above but that's mostly a matter of >> style. >>> >>> Picking this up unless someone sees a problem with it. >>> >>> Thank you! >>> Acked-by: Christian Brauner >>> >>> . >>> > > The patches are queued for after rc1. So around next week. > They came too late to make it into the merge window. > > Christian > That is ok, thanks. Regards. Zhiqiang Liu. > . >