From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8C9334DCC7 for ; Thu, 21 May 2026 06:51:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779346313; cv=none; b=mmUQS2ri1aJ+BJ0udoLlo4HE0eBLHx/IYeoFPB+eVX8jrdbNuAlrQXQJ5DUwXJ8+Rs9nXZR1OAjVcuo/i77OYbjlEvpfl/vVDm2NvPve9Kul31mKt4OiE53YjODQhWW2ZglOcoZBEzejSuVTHBaigUCd7ZbNXT9UHnk6AXV5h3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779346313; c=relaxed/simple; bh=OzXvlTwqyg/LORhSSsvxHKnz+VzK+OsN50SGeyyrFmo=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=AHvJUwOKIgEfjbKbwVyC8J1nioDnGTSRPPR3vPS6ip+XbPfty6OSlVIK4ssZdXS2YKszWRi63U595ZkLYvDhut/muBpM+ywYXk2ttfW9KKM1Xg9kpxyAdD+RYZUL1nZVhDdqxq6X8HFiBoO3HaeTboFikx1oN3BIEl5iZlK/2Xo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B1vg3W/e; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fpy8BxmF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B1vg3W/e"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fpy8BxmF" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L1Inh32072188 for ; Thu, 21 May 2026 06:51:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ipaFgG3ogON0geuVOtzTG/KiPSvXW3QMvF4djvkApMQ=; b=B1vg3W/euwWpmXT0 mzK/ivX/06i+rfYeWpY4Q3W0jG7eYYXGdcOb/6CtlDz2zAtjyAC76ywiKXwQ2qGP G/FwwUPBgqXK4PMmDABwSM/Sa3l85HjCfxz7GMhau5d9oubwkrLSh+meSJV4yk+V btNs5mLaK9MwW/pJiKawRCMYxytvUy2+gDVCXG7Q8j+Jv0FrHqpBjNrUgZLlYp02 ex7sRnqXkCmwpHaMe13QVtppYiW2fASuriagul9HYgHOCXH351shb3fu0Vr4fC8x ggnd0nZp3NRv8z88HNpz4Sn3CRz73zpPTek9G9BfX1t7/0USEF4b8/SnK/k4BjNa cYEfgw== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9r961251-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 06:51:50 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8353df9bc7eso6710218b3a.2 for ; Wed, 20 May 2026 23:51:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779346309; x=1779951109; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=ipaFgG3ogON0geuVOtzTG/KiPSvXW3QMvF4djvkApMQ=; b=fpy8BxmF9If6zIOEIy9ghZXjRphg/WBy4FITj5ivZgX0Rsx7dybL3GH2xf5811tnBZ RNIbK7u9q4LSpEllAWoNO4iNqKoN4Sum8l86pYwECo521+jsHMXUkZdQqyOWP5Ohkyws ZFcRgJFyOJ0+k4p1na7qSo/iCnWTIlh1xAL8EXUu8Znfy2Ivg5ArwiJM220X/lElH9/y 568xquEDqj39P9dJ1kNCPh9+34OrnJEXxbfQMAwn663kIR6tGhs0SKt8Z2wTy9R0ofrg aBC68X/tkCR9ZmeLoA4cZjtl1kYZoMh4GcANXEJsU+LRlD9ZU6KlI7lEcSZMoiwQdygx F6SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779346309; x=1779951109; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ipaFgG3ogON0geuVOtzTG/KiPSvXW3QMvF4djvkApMQ=; b=rxB5QjtKxj7USosRHjDtHKTLywaSHIOT16p+lVHshXQfOaUsO1LSiGvqlWg2s8G7Zd 7oCZIO32YeklG7Y1nuu4j3rSTq3F8nTxc0hKIZHnr8XLYoU3ECPbBpwHJPEd6Wd937Zm xukSaGHFdgHyP8VN1178s7S8Zkay6kNkfkvsIVGEyKJpg9P8NJitWuF75pDeEuvMfnk6 ZrE0k4YamrATMvoucbSDqEmgENqFNKX3+0+WTL/VjiH8zfoMotd0cIikyeOC2+uT6CJV 0cHQNnUxQfyQHJ22Piv309in57rvxS3TVBep5NeGzTj9ECYI64ZOIxVMOPPu7f5s/9T3 uwtw== X-Forwarded-Encrypted: i=1; AFNElJ+e5RN/RHeo6i7v4Bl4G9UHhSIi5IIkTFgbU5uDcZWcPevULsgyLFsmCqeiW8Ves2tzkn/OnJSZCur1iQE=@vger.kernel.org X-Gm-Message-State: AOJu0YxRBvHCMvLTlvqNYW9IxrFt1RNtNtC73/du6ilcRtoT5HrTPUJa 9o0WEweO2B8ua5JyZA/bcBpV7Ah8DKhsJIpZTLQlCx9rKnDOdguYmd0WZkaEoqfFIiXe5fAo0Rv a5DL1k5W5m70FacPxwKtUMlX1XECspEvd+0Qh2sCY0baXzIeenEL6qo4PaJKjx0Rfcfw= X-Gm-Gg: Acq92OEjhskhvSE8L2uKQNt0/Kg8bxDz3iw2moFmH1J2zWQzVXDo5MOFOh3WUoT/eLv fyNVYAK8Uio4Yqea1xymc1BIhZhnMCBmLY/nXwD3+CYYt6HPcoICroPWSHa6rL5BVnRLLS0r/hW zhUfd/mBpUaR3qol1zcJ5PUTycYwxT/5Y7aq5h+s5jQQmcBLFcjDEZHvHgKv6FwNOnIVoWdGIYE LzpxlrDrDrvj3N0U2XQ3b39z1h/fdKztUrJyJGS+yvOodnDOY7F9oAYMwj2GFV/JS/d44c9nciL 9JQQ9f8FI5WH7E2Wm6f2A+DfQOQxc10NnLp3nX7jRt5u5hwAFkxhgwJXf13/+nT0GDrw6+lDs7M Jk/IH6vT/oYSMkexqO+z3emw8GMmEOuQBibyqjaLmXTjCswIjYdnqhriLPTlr4Q== X-Received: by 2002:a05:6a00:845:b0:835:6d99:3f94 with SMTP id d2e1a72fcca58-8414adf542bmr1746459b3a.25.1779346309529; Wed, 20 May 2026 23:51:49 -0700 (PDT) X-Received: by 2002:a05:6a00:845:b0:835:6d99:3f94 with SMTP id d2e1a72fcca58-8414adf542bmr1746442b3a.25.1779346309052; Wed, 20 May 2026 23:51:49 -0700 (PDT) Received: from [10.92.163.96] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84154e59ea9sm232016b3a.61.2026.05.20.23.51.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 23:51:48 -0700 (PDT) Message-ID: Date: Thu, 21 May 2026 12:21:41 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Kuldeep Singh Subject: Re: [PATCH 0/3] Add support for qcrypto on shikra To: Eric Biggers Cc: Thara Gopinath , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Frank Li , Andy Gross , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org References: <20260515-shikra_qcrypto-v1-0-80f07b345c29@oss.qualcomm.com> <20260514194735.GA1939213@google.com> Content-Language: en-US In-Reply-To: <20260514194735.GA1939213@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: xhZ9Ek0iJjT-pyNmyGLpHLvkcfAN0c8n X-Proofpoint-GUID: xhZ9Ek0iJjT-pyNmyGLpHLvkcfAN0c8n X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDA2NSBTYWx0ZWRfXx424RudUTTSN +Qbb5acpP5+eWATaAwzadNIUrLrjp8sNnaZqgCoX3NPr4ODoMUxlc3FpyRYjrmjg7+EHxskgmcu 69EKsQtgQZcXnHk+WejDjnfpUKDQ4Kksos0CNPUd1D+YSttA5WkeSWlB//ZXHwW76ZanQoRSSDy RLBoU5j1Mx9/z8lDFeeQTL2Mu+3uhU+u2WtaIFKFvK3rDttam3iQ2Y+fXg7ewTnCJZCr7dMDlq5 ZwvavmmSpJq2XbirsxZeLWkJiKOxATLDdiJXSV1zyGXo9OQaJXgRrj8LhzjevwSN8Sgj71YZMXL jNSoNk0JYTYZTE5ulMkFEZILLVhgyCfMlmedRGpxg7ktWeMplFH0+Zrdd9sMcO5r0WPl0mawIGZ mdnjHtOkpM1Aj+817bJuAjpurdgeIAb0CJNYDoVPcPss6zl9w2KdXMqXxFaGIGdxRir0Zie0rYl kSfSfwqDKJxJXjzWL2A== X-Authority-Analysis: v=2.4 cv=GqFyPE1C c=1 sm=1 tr=0 ts=6a0eab86 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=1cRb9DtoxWFOFH21OVAA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210065 On 15-05-2026 01:17, Eric Biggers wrote: > On Fri, May 15, 2026 at 12:53:35AM +0530, Kuldeep Singh wrote: >> Add qcrypto and cryptobam DT nodes for enabling qcrypto on kaanapali. >> Shikra bam dma supports 7 iommus so update dt-bindings accordingly. >> >> The patchset depends on below. There's recursive dependency so referred >> to base DT patch here. >> - https://lore.kernel.org/all/20260512-shikra-dt-v1-0-716438330dd0@oss.qualcomm.com/ >> >> Validations: >> - make ARCH=arm64 DT_CHECKER_FLAGS=-m DT_SCHEMA_FILES=Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml dt_binding_check >> - make ARCH=arm64 qcom/shikra-cqs-evk.dtb CHECK_DTBS=1 DT_SCHEMA_FILES=Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml >> - cryptobam and crypto driver probe >> - kcapi test >> >> Signed-off-by: Kuldeep Singh > > What specific kernel features would this be useful for, and what > specific performance improvements are you seeing with those features? I hope you mean 7 iommu entries. Please note, shikra is an old platform and differs with latest platforms like kaanapali in terms of iommus#. Kaanapali is optimised(in terms of iommus#) as same pipe index/sid i.e 4/5 can be used for general purpose or for any other usecase like DRM/HDCP etc. Whereas for shikra, there's dedicated iommu entry for each usecase and same pipe index/sid cannot be used for other usecases. The performance will be be effectively similar. -- Regards Kuldeep