From: "Arnd Bergmann" <arnd@arndb.de>
To: "Donald Robson" <Donald.Robson@imgtec.com>,
"Frank Binns" <Frank.Binns@imgtec.com>,
"Matt Coster" <Matt.Coster@imgtec.com>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Dave Airlie" <airlied@gmail.com>,
"Sarah Walker" <Sarah.Walker@imgtec.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Maxime Ripard" <mripard@kernel.org>
Subject: Re: [PATCH 2/2] drm/imagination: avoid -Woverflow warning
Date: Wed, 29 Nov 2023 13:04:53 +0100 [thread overview]
Message-ID: <d4d42b22-076b-4980-aa43-d5458a094873@app.fastmail.com> (raw)
In-Reply-To: <9df9e4f87727399928c068dbbf614c9895ae15f9.camel@imgtec.com>
On Wed, Nov 29, 2023, at 13:01, Donald Robson wrote:
> Hello Arnd,
>
> Thanks for the patch. I'm slightly concerned that we've not seen this
> warning when
> building here. I guess we need to check our CI settings...
>
> Reviewed-by: Donald Robson <donald.robson@imgtec.com>
This was previously enabled only when building with either
"make W=1" or "make C=1", but not the default build, which
explains why it only showed up after the merge into linux-next
that has the corresponding scripts/Makefile.extrawarn change.
It would still be a good idea to add the extra compiler (W=1)
and sparse (C=1) warnings in your CI system and address all
other issues that might uncover.
Arnd
next prev parent reply other threads:[~2023-11-29 12:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 11:33 [PATCH 1/2] drm/imagination: avoid -Wmissing-prototype warnings Arnd Bergmann
2023-11-29 11:33 ` [PATCH 2/2] drm/imagination: avoid -Woverflow warning Arnd Bergmann
2023-11-29 12:01 ` Donald Robson
2023-11-29 12:04 ` Arnd Bergmann [this message]
2023-11-29 12:15 ` [EXTERNAL] " Donald Robson
2023-11-29 12:07 ` [PATCH 1/2] drm/imagination: avoid -Wmissing-prototype warnings Donald Robson
2023-11-29 12:16 ` Arnd Bergmann
2023-11-29 12:21 ` [EXTERNAL] " Donald Robson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4d42b22-076b-4980-aa43-d5458a094873@app.fastmail.com \
--to=arnd@arndb.de \
--cc=Donald.Robson@imgtec.com \
--cc=Frank.Binns@imgtec.com \
--cc=Matt.Coster@imgtec.com \
--cc=Sarah.Walker@imgtec.com \
--cc=airlied@gmail.com \
--cc=arnd@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®