From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C81F5207A14 for ; Fri, 10 Jan 2025 08:13:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736496821; cv=none; b=R63y2iR9e2ZHoFPkd+Rl5MlXsayP3DiCIBDS84BZ8fA7fmZgVL7l+zpULa4nXK/wb3uUhzKb+S6ANBnvX1zFWFLnhpaWOD8fuTyzYoguRTaho/Ffe1KxdENXNhD6gmMtUrI3McGULzlnuccXm6LCU1fz6BFmboZ8oqAQmj0hekY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736496821; c=relaxed/simple; bh=lLjOkjf1wXpzYZ4sT4TWPRX6MLmiW6g8LMJeKNMGu00=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G1V82F0mMGVlMO9FsXcsN0EX3pxzINp7eM57LbLJeBWhhh+m74WOhE85N862c2xMZNu1zz5U6FOACuxhK5H6IUg9pxtYr/uNvdfr9uFe4b3K/ZWtNtj2xfKG1vvc84lP2ttkQfpKfRFL3al2MoQKSc/OInVZzNddbA9H+nc36Cc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=C+Upftb4; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C+Upftb4" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-43675b1155bso20528615e9.2 for ; Fri, 10 Jan 2025 00:13:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736496818; x=1737101618; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q0EV045k8CG4Yg/GfxO4KvlU6Rqe6kFmO58kVT3kSXY=; b=C+Upftb4+fldE5YMFoduCKTGwcGd6lGvAC4RqKSY7t7YkanJNZ30TprlPFbtYvNcQB mg+Wb7Hn2xbkkBUSuldr7tDWbEiKkNh8WVpsEeaILlQG46fYv9oAag8KICsMqkyaWr9e u+BG11MB7T43Ue9+htQZfyiiaXaM1F/M0xL7kq9jdizkOkdFnYCGr0UKAZtX3SFkUyKl 0gYwVTyltbJt+iZEgIUe7t0P4I4yhPebGk8AT07IaFmd3jczBym2NYpmUMXc9fkxgQGA YtT4zizuJIaGjhw59fokeUH+cVIzQKq9tJMGadf4ZYvbHnQcpJNn9by9yZo1AE/90lRj KNQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736496818; x=1737101618; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q0EV045k8CG4Yg/GfxO4KvlU6Rqe6kFmO58kVT3kSXY=; b=eXbL7LF+PzpkM7fvvU5D1/ywDpLBIvNEnL8p0E8gqGhkkZFlqfxaHmjC1GxLl/ToVx obUk1SfNOF5cO2JkJV7SM7ApwXVVuqENsV1JvFP37/b5IPf8Xa9oGLjqPFPSZIQyZoVo +JPgz2Qk8hznqRy8qGAhBCpAteb+hnMMjKCcB0eq+W1KBdeJKrxdY7XJXzsxWYwTBVQ2 TMUDlByLEFIJTIv18Gjd4x7A0p4a5wJFsqMBx9QXA9LFY4ozQkYpB17XrWikKTwCk054 Cy6IypeAg2pp6CiF0fUfdTC0WHUTvUF/nj3P0IZRrJOG/V2a9qD4L4tKW5XgGeEJgTB5 szUw== X-Gm-Message-State: AOJu0Yy8o+HFrlGEe2o9oP65GQCyFQjbV2F2DwoVxeKylpdjFKAoMdpP qbmmQmBDnJyGw83Ja2m6f3Y2d+J21wezOv9CnvBH/uVvxMED0oyjuTux6IuRzsM= X-Gm-Gg: ASbGncvK/0K5uV+X3l6DkzKhVBfL7YqFmWHrPkQX5n5EhkG/sxZtWJI8+Gh9dWMGbZW wcUQwgU+1CeZXkZvF989+7RSkS1KMn4k6gWrgYx4wxCS5dQSLibz6MdLIUvzfuZs/9FHqqAxM9M ha2aeGJEaSnrcaUCLywnsEYnWyxQoDPumCE93ryhhA8r28h7GNyXE/YgVIoreqXioM/PsuCuFpH aliMi5JHmWBU56gFuK4iXuXhdmXKrsiY771e6//hd7wbo996W53h9XtpuJhfuqj1yn4yvSWzW5q 1V4yn3qnVBbCt2wyaVLhfkh6Ljk= X-Google-Smtp-Source: AGHT+IFpjInhd33mWgPk1P2BS4pHVpZXIpbSheFxrXN+9gDHs3qr5/NnCurtOhyxygGxHMuzuxoe9w== X-Received: by 2002:a05:600c:46ce:b0:436:6ddf:7a27 with SMTP id 5b1f17b1804b1-436e27072a7mr80662725e9.23.1736496818143; Fri, 10 Jan 2025 00:13:38 -0800 (PST) Received: from [192.168.1.74] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9e6249csm43923755e9.38.2025.01.10.00.13.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 00:13:37 -0800 (PST) Message-ID: Date: Fri, 10 Jan 2025 09:13:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH] MIPS: ftrace: Declare ftrace_get_parent_ra_addr() as static To: WangYuli , rostedt@goodmis.org, mhiramat@kernel.org, mark.rutland@arm.com, tsbogend@alpha.franken.de Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mips@vger.kernel.org, xzhong86@163.com, wuzhangjin@gmail.com, srostedt@redhat.com, linux-mips@linux-mips.org, ralf@duck.linux-mips.net, jeffbai@aosc.io, zhanjun@uniontech.com, guanwentao@uniontech.com, jiaxun.yang@flygoat.com, gregory.clement@bootlin.com, tglx@linutronix.de, rppt@kernel.org References: <527F9AFF0430AB45+20250104144708.18438-1-wangyuli@uniontech.com> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <527F9AFF0430AB45+20250104144708.18438-1-wangyuli@uniontech.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/1/25 15:47, WangYuli wrote: > Declare ftrace_get_parent_ra_addr() as static to suppress clang > compiler warning that 'no previous prototype'. This function is > not intended to be called from other parts. Since 2009 in commit 29c5d3462f7c ("MIPS: Tracing: Add function graph tracer support for MIPS") eh :) > > Fix follow error with clang-19: > > arch/mips/kernel/ftrace.c:251:15: error: no previous prototype for function 'ftrace_get_parent_ra_addr' [-Werror,-Wmissing-prototypes] > 251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long > | ^ > arch/mips/kernel/ftrace.c:251:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > 251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long > | ^ > | static > 1 error generated. > > Signed-off-by: WangYuli > --- > arch/mips/kernel/ftrace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé