From: Stian Halseth <stian@itx.no>
To: Kees Cook <kees@kernel.org>
Cc: Andreas Larsson <andreas@gaisler.com>,
"David S . Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org, Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>, Oleg Nesterov <oleg@redhat.com>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: Re: [PATCH 2/2] selftests/seccomp: add sparc64 support
Date: Wed, 02 Sep 2026 09:15:14 +0200 [thread overview]
Message-ID: <d4d5d20bd3fd8bab30c1a28fd1eda374e62d9038.camel@itx.no> (raw)
In-Reply-To: <202609011700.E21C37761@keescook>
[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]
On Tue, 2026-09-01 at 17:02 -0700, Kees Cook wrote:
> Thanks for getting the working on sparc! :)
>
Thank you for the quick and friendly review! This is my first feature
submission to the kernel. I've only sent some bug fixes earlier, so
that's much appreciated.
>
> Is struct sparc64_user_regs not exported to userspace anywhere? We
> haven't normally needed to put the raw user_regs struct definition
> into
> the test before.
>
Good point.
Sparc has its own PTRACE_GETREGS64/PTRACE_SETREGS64 requests that
transfer the uapi struct pt_regs directly from <asm/ptrace.h>, so thel
ocal definition wasn't needed after all.
One small quirk I hit though. The requests use the historical layout
that omits %g0, so the transferred block starts at %g1 and every u_regs
index is one lower than the register number suggests (%g1 is u_regs[0],
%o0 is u_regs[7]).
Will post v2 with a comment saying so now. Re-ran the suite on
the T4-1 with the new version: still 95 of 95.
--
Best regards
Stian Halseth
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-09-02 7:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 22:08 [PATCH 0/2] sparc64: add seccomp filter support Stian Halseth
2026-09-01 22:08 ` [PATCH 1/2] " Stian Halseth
2026-09-01 22:08 ` [PATCH 2/2] selftests/seccomp: add sparc64 support Stian Halseth
2026-09-02 0:02 ` Kees Cook
2026-09-02 7:15 ` Stian Halseth [this message]
2026-09-02 7:21 ` Stian Halseth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4d5d20bd3fd8bab30c1a28fd1eda374e62d9038.camel@itx.no \
--to=stian@itx.no \
--cc=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=glaubitz@physik.fu-berlin.de \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=shuah@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®