From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0E86C4708E for ; Tue, 3 Jan 2023 00:36:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230460AbjACAgQ (ORCPT ); Mon, 2 Jan 2023 19:36:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231452AbjACAgL (ORCPT ); Mon, 2 Jan 2023 19:36:11 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2C386378 for ; Mon, 2 Jan 2023 16:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672706120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hM961epS0QDYelv54QomDRQGneiyQTUvFYbwkk0LVqI=; b=SZw2/BLZ0y9/h4CaoYCuELPjA6TWBpI+V5OniqZt/0Ig1X39Ra+epudIQowZzqHFfz3Qbs NIwVLmiR+d6Afa42K9bj8Tk6gO4TQ0g1hrbGmwQYOhCqJ5xLwk8ni+HOzw2HQMUdjFoaHH CHUPYsb3lNpx7QFTDYZK96ZYgkLgfoA= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-392-h5_64vVbMHeTxi3CNr854g-1; Mon, 02 Jan 2023 19:35:19 -0500 X-MC-Unique: h5_64vVbMHeTxi3CNr854g-1 Received: by mail-pf1-f200.google.com with SMTP id ca10-20020a056a00418a00b00581dff62bb7so4267667pfb.13 for ; Mon, 02 Jan 2023 16:35:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hM961epS0QDYelv54QomDRQGneiyQTUvFYbwkk0LVqI=; b=es7QFlXbwQPLKLW/fHegbRZiAsNjUZvkdfrHhyBuKaoiO9q/pNINYZaj5QYZYd9vwd 9oQ1hU3Knh0VUJDXS2DRnwQr+2SRwtPNEy7xfbRT050+HlghNsgZ+VMiOlsPcuDguHpR wOP6x9D4fMlfot6Ntfth4i5PaQLYAFK77XGq1eO9RRdxmlKYb9Jm81XVoMdec3B34vhP dkUdmrO6oKz/mrbvAQQRfiHh12n3ULQmUutjpkq0cvGBmm4CamMWEy4B7GwPywDdLoV+ BVUveVnHs4vq5i5z34D2zU8ULJSiHGbPgyonZtIDe2g4vw41ecfpUDiAQcrEwcFp2YXX P81g== X-Gm-Message-State: AFqh2kpsqm0+yYADSYCt02FmKXC79VW9yp2SaaHA4k/qdv1WqvDt8/1Z z47jwmHB18ZGn5Tn5hYzs3eYPDgsueldOhE3RVt830yBJhWjEjmBqstT0LchUhjRG4q8KSn3M66 78WeVaZagnm/vClS/LyoSH9l0 X-Received: by 2002:a05:6a21:6d9c:b0:b1:dac3:37b9 with SMTP id wl28-20020a056a216d9c00b000b1dac337b9mr66737356pzb.45.1672706118566; Mon, 02 Jan 2023 16:35:18 -0800 (PST) X-Google-Smtp-Source: AMrXdXt34ID3ilsl76gvpJ2MbHJDhVQg9RHTjR6sw3heFyyo65JAPCwOuqIy3s+HDQA484cOS8xSQQ== X-Received: by 2002:a05:6a21:6d9c:b0:b1:dac3:37b9 with SMTP id wl28-20020a056a216d9c00b000b1dac337b9mr66737344pzb.45.1672706118339; Mon, 02 Jan 2023 16:35:18 -0800 (PST) Received: from [10.72.12.16] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id i27-20020aa796fb000000b00581a5fd4fa7sm9889961pfq.212.2023.01.02.16.35.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jan 2023 16:35:17 -0800 (PST) Message-ID: Date: Tue, 3 Jan 2023 08:35:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v5 0/2] ceph: fix the use-after-free bug for file_lock Content-Language: en-US To: Ilya Dryomov Cc: jlayton@kernel.org, ceph-devel@vger.kernel.org, mchangir@redhat.com, lhenriques@suse.de, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20221214033512.659913-1-xiubli@redhat.com> From: Xiubo Li In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/01/2023 19:50, Ilya Dryomov wrote: > On Wed, Dec 14, 2022 at 4:35 AM wrote: >> From: Xiubo Li >> >> Changed in V5: >> - s/fl_inode/inode/ >> >> Changed in V4: >> - repeat the afs in fs.h instead of adding ceph specific header file >> >> Changed in V3: >> - switched to vfs_inode_has_locks() helper to fix another ceph file lock >> bug, thanks Jeff! >> - this patch series is based on Jeff's previous VFS lock patch: >> https://patchwork.kernel.org/project/ceph-devel/list/?series=695950 >> >> Changed in V2: >> - switch to file_lock.fl_u to fix the race bug >> - and the most code will be in the ceph layer >> >> >> Xiubo Li (2): >> ceph: switch to vfs_inode_has_locks() to fix file lock bug >> ceph: add ceph specific member support for file_lock >> >> fs/ceph/caps.c | 2 +- >> fs/ceph/locks.c | 24 ++++++++++++++++++------ >> fs/ceph/super.h | 1 - >> include/linux/fs.h | 3 +++ >> 4 files changed, 22 insertions(+), 8 deletions(-) >> >> -- >> 2.31.1 >> > Hi Xiubo, > > I have adjusted the title of the second patch to actually reflect its > purpose: "ceph: avoid use-after-free in ceph_fl_release_lock()". With > that: > > Reviewed-by: Ilya Dryomov Hi Ilya, Sure. Looks better. I will revise it. Thanks - Xiubo > Thanks, > > Ilya >