From: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>
To: Josh Cartwright <joshc@ni.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"rob@landley.net" <rob@landley.net>,
Michal Simek <michals@xilinx.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jason@lakedaemon.net" <jason@lakedaemon.net>,
"ezequiel.garcia@free-electrons.com"
<ezequiel.garcia@free-electrons.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"artem.bityutskiy@linux.intel.com"
<artem.bityutskiy@linux.intel.com>,
"jussi.kivilinna@iki.fi" <jussi.kivilinna@iki.fi>,
"acourbot@nvidia.com" <acourbot@nvidia.com>,
"ivan.khoronzhuk@ti.com" <ivan.khoronzhuk@ti.com>,
"joern@logfs.org" <joern@logfs.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"kpc528@gmail.com" <kpc528@gmail.com>,
"kalluripunnaiahchoudary@gmail.com"
<kalluripunnaiahchoudary@gmail.com>
Subject: RE: [PATCH v6 1/2] Devicetree: Add pl353 smc controller devicetree binding information
Date: Fri, 24 Apr 2015 00:46:21 +0000 [thread overview]
Message-ID: <d4e01acf-28c1-466f-a796-12f7ea339507@BN1AFFO11FD028.protection.gbl> (raw)
In-Reply-To: <20150423195043.GS27115@jcartwri.amer.corp.natinst.com>
Hi Josh,
> -----Original Message-----
> From: Josh Cartwright [mailto:joshc@ni.com]
> Sent: Friday, April 24, 2015 1:21 AM
> To: Punnaiah Choudary Kalluri
> Cc: robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com;
> ijc+devicetree@hellion.org.uk; galak@codeaurora.org; rob@landley.net;
> Michal Simek; grant.likely@linaro.org; gregkh@linuxfoundation.org;
> jason@lakedaemon.net; ezequiel.garcia@free-electrons.com;
> arnd@arndb.de; dwmw2@infradead.org; computersforpeace@gmail.com;
> artem.bityutskiy@linux.intel.com; jussi.kivilinna@iki.fi;
> acourbot@nvidia.com; ivan.khoronzhuk@ti.com; joern@logfs.org;
> devicetree@vger.kernel.org; linux-doc@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-mtd@lists.infradead.org; kpc528@gmail.com;
> kalluripunnaiahchoudary@gmail.com; Punnaiah Choudary Kalluri
> Subject: Re: [PATCH v6 1/2] Devicetree: Add pl353 smc controller devicetree
> binding information
>
> Hey Punnaiah-
>
> A few nitpicks here, in case you'll be spinning up a new version of your
> patchset.
>
> On Mon, Apr 13, 2015 at 09:41:51PM +0530, Punnaiah Choudary Kalluri wrote:
> > Add pl353 static memory controller devicetree binding information.
> >
> > Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
> [..]
> > @@ -0,0 +1,37 @@
> > +Device tree bindings for ARM PL353 static memory controller
> > +
> > +PL353 static memory controller supports two kinds of memory
> > +interfaces. i.e NAND and SRAM/NOR interfaces.
> > +The actual devices are instantiated from the child nodes of pl353 smc
> node.
> > +
> > +Required properties:
> > +- compatible : Should be "arm,pl353-smc-r2p1"
> > +- reg : Controller registers map and length.
> > +- clock-names : List of input clock names - "memclk", "aclk"
> > + (See clock bindings for details).
> > +- clocks : Clock phandles (see clock bindings for details).
>
> Technically not clock phandles, but clock specifiers.
>
> > +- address-cells : Address cells, must be 1.
> > +- size-cells : Size cells. Must be 1.
>
> These should have the leading '#' as in '#address-cells' and
> '#size-cells'.
Thanks for the review. I will take care of them new version
Regards,
Punnaiah
>
> Josh
next prev parent reply other threads:[~2015-04-24 0:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1428941512-26411-1-git-send-email-punnaia@xilinx.com>
2015-04-13 16:11 ` Punnaiah Choudary Kalluri
2015-04-23 19:50 ` Josh Cartwright
2015-04-24 0:46 ` Punnaiah Choudary Kalluri [this message]
2015-04-13 16:11 ` [PATCH v6 2/2] memory: pl353: Add driver for arm pl353 static memory controller Punnaiah Choudary Kalluri
2015-04-13 18:49 ` Paul Bolle
2015-04-14 6:44 ` punnaiah choudary kalluri
2015-04-28 15:11 ` Ben Shelton
2015-04-28 15:58 ` punnaiah choudary kalluri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4e01acf-28c1-466f-a796-12f7ea339507@BN1AFFO11FD028.protection.gbl \
--to=punnaiah.choudary.kalluri@xilinx.com \
--cc=acourbot@nvidia.com \
--cc=arnd@arndb.de \
--cc=artem.bityutskiy@linux.intel.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ivan.khoronzhuk@ti.com \
--cc=jason@lakedaemon.net \
--cc=joern@logfs.org \
--cc=joshc@ni.com \
--cc=jussi.kivilinna@iki.fi \
--cc=kalluripunnaiahchoudary@gmail.com \
--cc=kpc528@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=michals@xilinx.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®