From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756084AbdEKRUI (ORCPT ); Thu, 11 May 2017 13:20:08 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:34361 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752099AbdEKRUG (ORCPT ); Thu, 11 May 2017 13:20:06 -0400 Subject: Re: [PATCH] ARM: remove duplicate 'const' annotations' To: Arnd Bergmann , arm@kernel.org References: <20170511115059.2997141-1-arnd@arndb.de> Cc: Nicolas Pitre , Nicolas Ferre , Alexandre Belloni , Russell King , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Krzysztof Halasa , Rajendra Nayak , Paul Walmsley , Tony Lindgren , Viresh Kumar , Wenyou Yang , Olof Johansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org From: Florian Fainelli Message-ID: Date: Thu, 11 May 2017 10:20:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170511115059.2997141-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/2017 04:50 AM, Arnd Bergmann wrote: > gcc-7 warns about some declarations that are more 'const' than necessary: > > arch/arm/mach-at91/pm.c:338:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] > static const struct of_device_id const ramc_ids[] __initconst = { > arch/arm/mach-bcm/bcm_kona_smc.c:36:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] > static const struct of_device_id const bcm_kona_smc_ids[] __initconst = { > arch/arm/mach-spear/time.c:207:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] > static const struct of_device_id const timer_of_match[] __initconst = { > arch/arm/mach-omap2/prm_common.c:714:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] > static const struct of_device_id const omap_prcm_dt_match_table[] __initconst = { > arch/arm/mach-omap2/vc.c:562:35: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] > static const struct i2c_init_data const omap4_i2c_timing_data[] __initconst = { > > The ones in arch/arm were apparently all introduced accidentally by one > commit that correctly marked a lot of variables as __initconst. > > Cc: Nicolas Pitre > Fixes: 19c233b79d1a ("ARM: appropriate __init annotation for const data") > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-bcm/bcm_kona_smc.c | 2 +- Acked-by: Florian Fainelli -- Florian