From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94F0A219E8 for ; Mon, 6 Jul 2026 06:01:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783317669; cv=none; b=eZ8HKCvMg7OP1gmVyAdhj3Xl/w9+xHj42btQbXcpl1kfPy1sZAKtluufratUd4cgCv09kxValprhLUg1YpwlwrmvJ6YqNWJVgI+e5ir097OAZv5DPev1uZROOtWZQThdVXNCxgVwW+fUFS2A59t8xgTuVIp7AO2Pkv90SoXKsL4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783317669; c=relaxed/simple; bh=SodNyyc/QGixhPijgTyGlY58ow1pnTNxCJCZJPPg7g8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ntXK/y4XtrBTJUpKFZhk+PWh1TmMFkBrD+qwXwI5iZ5/rWdaRfmVFgmUKxlSuDSyx9hgmVoXO5JpBYL6wSUlNKpnzDc6wlbwU+6OcpdoqOPepMNMrNbsQOWK5uyEkbVXW9Y2WsotwV/ez+7viRpTNM1gNC6mwMpEAU43zEyLfzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SV44sDAt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YAIQP7Yb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SV44sDAt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YAIQP7Yb" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66641Tr73613953 for ; Mon, 6 Jul 2026 06:01:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= c80CyQ1ai9kFfoffrUa4oghZEtD+aE9oTf/NVYfyV4c=; b=SV44sDAtjAwD9aon Ol0mlcADZu4Lgs+ip72IDnJIRipFqjTribvpMYCpmyoi2WE3t1hz8twx7B4d3kWI bWghFvHL1LLyhuhGxdo5Lm93/W1l1qBHdeYEsdCpRRBHEVUUahD/bj2gWxFW/f49 B6xtnGTCSPO0EgC0IBZT0PTTGHRMAmqq7hJXiBa04VqovofPmbS/wed42OzaCtYB CDbJK3Jo3NRG35Ri2FUBwpRzE7MqaI1Sljo8U3/cm1y7e/CtiCOpdk40QcTbUx+P MpV8stzv7nTRDNBprkLafQRdj/dZLbA4YmZbqhW0X00QOh4MqksyspintPNm4oBt S9yXQg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6srvmnnq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 06:01:07 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e7ee64b25so456258985a.0 for ; Sun, 05 Jul 2026 23:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783317667; x=1783922467; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=c80CyQ1ai9kFfoffrUa4oghZEtD+aE9oTf/NVYfyV4c=; b=YAIQP7YbiF4MV1s/IktsaIsdk/s7Q20ye8aIooaWkucjw9ns542gqihNZYrz6rxo7G QJebhRfwCmtKELq61zOMFPAHmNytkzyVZaENj83lOK1izM+5NLOC0pOuvHCFwmdImQQm 2C0kozYTKVVGoy7d2cvsIPl0x6Q/csi+Lv6U/+CSc3VRbL8R1GT5URuO6PY9KNJ0Ycod 62AMp6CPqiDQU4VTJJOqaDimlKqxhcK62ag7GO8xZUxrXa/r/0jb65UV46IPQYltWjon uitQh9CHeZFGeUxF7X4c6+5RFkG0el8bVUt45BYnza/wlVRTN5D+40KK0OPUqZ2B8SSo keVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783317667; x=1783922467; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=c80CyQ1ai9kFfoffrUa4oghZEtD+aE9oTf/NVYfyV4c=; b=O9shOymOaJw0xLpyttH4Vgcc3N7gq/OkMIkyqowSs/0GV2joqYgB691G8TqheNi6oB 5bVIi5YTBeDTR4uittVZ7CrU4XAMEBAhiH/kepRZ3CPP7CPLAyOWdbJ+inAaslswrO5i s8KxZcJo6pImZtcnPRr0A68gFmCukYP+Zz5KivshRpSkVrW/neBjYguURrcDoyqSEWl9 7Q4Xi8EYIu7SF5/3B9VvKrL6p2tDqG+t9hWpp/W6Nt59yYATvUgHQ8pZZV/bnP2rGAbk JZQBiWS730dudYj8srAusVEoQWeg8ADkBVqRuDpQdas8TxPSc1cs3+xPg6L5qgZSF2/2 6AvQ== X-Forwarded-Encrypted: i=1; AHgh+RqZUa7+6NcHFuwsfc129PIGIBSQ5E+/B0NpbnvuKByZ2x+3QU4MraX3MpqvYWD3IfJO8Io1HhHVWffbFtk=@vger.kernel.org X-Gm-Message-State: AOJu0YyjEk/g+R3N5nodbJc0XPGWFYNeoAguChT1D8zD3RriaztnfmXP xc0kSbrbhPsoWKmZ8AOKHqOw22P74d2btX9opuwOy1tgjC8B8J+IF4+HJMCMNOI6IuLTiD38PAC JN1JZOYAyRmr9uoiaJK90sP39zPaXFCPNbHNNeiPEDMgbGKMecDvvv9Jj0VQ8miVcMVg= X-Gm-Gg: AfdE7cl5Zh2901G7yfExvPRzFXGzhj/fu9PoCw/ZHhShwUdQySVhsOalVIIWkjhGQT+ i6Ner1GiQvzlD067Ile+Qlo+i4TiMZTbSZ8b90htTbDMmAZYPHZCYnR2msvSv2+22bFJ4smKzPA pur8mAQPEuITkT256cJkdImfvjtAemPBEmQmWpNT7KGdFH6DPCdrvOnzXoY6xY8IoWfpsihBdWP dnAoEdqALSLfPnh8Bly/DkEPsDoqpgEcA8AtxJvkuczqYLuKcdfDxGYJb66zrGqjvDSH13yhbzW f1zVJlvxqViiJVa/V9jj5Nyg7/c2Ere8b5QlBu7zgVUEATKUA59VUxiU8dXSGiWtoXEG13keSbs CFQayT8Fy/4odP+6gJVE2nPIngAj6r+T3EBESX7Zi X-Received: by 2002:a05:620a:29c1:b0:914:afc1:c66d with SMTP id af79cd13be357-92e9a2f76e3mr1298319285a.11.1783317666513; Sun, 05 Jul 2026 23:01:06 -0700 (PDT) X-Received: by 2002:a05:620a:29c1:b0:914:afc1:c66d with SMTP id af79cd13be357-92e9a2f76e3mr1298315185a.11.1783317665980; Sun, 05 Jul 2026 23:01:05 -0700 (PDT) Received: from [192.168.1.110] ([178.197.223.174]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4a343csm309185715e9.0.2026.07.05.23.01.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jul 2026 23:01:05 -0700 (PDT) Message-ID: Date: Mon, 6 Jul 2026 08:01:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] iio: adc: ti-ads131m02: Drop redundant NULL check on devm_clk_get_enabled() To: Jonathan Cameron Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Michael Hennerich , Antoniu Miclaus , David Lechner , Andy Shevchenko , linux@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260705172438.119204-3-krzysztof.kozlowski@oss.qualcomm.com> <20260706003712.753a5870@jic23-huawei> From: Krzysztof Kozlowski Content-Language: en-US In-Reply-To: <20260706003712.753a5870@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=TcamcxQh c=1 sm=1 tr=0 ts=6a4b44a3 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=N6niishs+lR9UBL1FN3Qrw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=vK5tWUMUpN7KhCZact8A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: j7R8DnDKMCf2xAvOu1I9CAjKVdOCdPM1 X-Proofpoint-GUID: j7R8DnDKMCf2xAvOu1I9CAjKVdOCdPM1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDA1NiBTYWx0ZWRfX8Oaw6VGu1gsq aRkfjlJzDA+6UIO5yv1xozhNMTT+llKvUQ4ch2nF0JyUgzySOnfwyqdODQLBNaw5Hutnl4xhqaT QQcqEgAQysY+5N7+pDlBtRGwzjCLgQ0INJqMKjmOTvzoNivQiG08Uakz2LaFZioHwB1gqaK9618 WxyBdpunakUWjHc8+EgxJtaaJbhPvqQn6/hOhYtfTDJJTXaZfS0p/qTsjjFGqpf6b6z9kW/D1Hx XUSFZ1KZB8Wr5CfOSUjNY4N6eS28MoEA8k2kDNNtGjMfpmMURN0k9Ji+6xWB7EvM1dgJrl8ge/v 3p2AFvnPVNdKKh9ea314v8X3fC5/zMYdzYOi5kSpdKSkLbWFPvjebZ7QIXM316hFmInlO1YAqpH JK1Ns/lx+YcpU+U0o94hlkIkpXefejuAfX/+QU2T1FelzHH9B7xinAjoguD0wvBhsBqCRRh1j8t yPWv9LMEO3s3wvPsWbg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDA1NiBTYWx0ZWRfX1Iz+8fYI9Dr0 pRp7ZnOQcjWi5sV9iYIhlc8HnSwW9Zu5hM/rvk9VLe57aYvLp2vFfomZInpuG1w/94MTAAEF3ng mr+sB+UITb99SjN2o28SnrUrCoADUkA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 suspectscore=0 bulkscore=0 phishscore=0 impostorscore=0 adultscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060056 On 06/07/2026 01:37, Jonathan Cameron wrote: > On Sun, 5 Jul 2026 19:24:39 +0200 > Krzysztof Kozlowski wrote: > >> devm_clk_get_enabled() does not return NULL (only valid clock or ERR >> pointer), so simplify the code to drop redundant IS_ERR_OR_NULL(). >> >> Signed-off-by: Krzysztof Kozlowski > See the stub. > > static inline struct clk *devm_clk_get_enabled(struct device *dev, > const char *id) > { > return NULL; > } > Not sure what the reasoning behind that is. Maybe that > clock could be already on? > > We could I guess make this driver depend on one of the clk > related configs, but today it doesn't. So to me this NULL check smells > of protection we don't need so I think the change is fine, but the > patch description should reflect that stub and it being considered > reasonable to plough on regardless. Oh, I missed the stub. Stub is wrong and should be fixed (and then this patch makes more sense). Best regards, Krzysztof