From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC392C4167B for ; Fri, 1 Dec 2023 10:46:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378426AbjLAKqf (ORCPT ); Fri, 1 Dec 2023 05:46:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378423AbjLAKqa (ORCPT ); Fri, 1 Dec 2023 05:46:30 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96B8C1726 for ; Fri, 1 Dec 2023 02:46:29 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F6A3C433C7; Fri, 1 Dec 2023 10:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701427589; bh=5zjayL88soz+UgJbryPsfFfFuCruLUpe7CIqCl/SLV8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SWPKPFHsSk8v67r+wzTQi1CO6hcbjUUpZE3vnilfgHHfZwu4IJFOQ5+rwbUdgPmLc yWtMqvr0cxc2sdZrbCSHK568MaEExBRSfpDet74hIw2pKTCMegAO8qkO+wBD57U//9 730HNIMRIxuWCCJFQNjzcbx58JHzDGYi6owXtMvfOhgcSIwgOpoBgzUhFTnyt4XCDN e7Syzbndkz/v/VLblq4L9o8kSEXECELQ08REb4v+RuY+aRar9yp//iKZVGMv256t73 o71Zp0tFHEerRmrytXpPlbRTZhyt+4VDNMgczQDGar2JHc9H5WbBlArbEMH4DACuda pFCJdIzQ48ioA== Message-ID: Date: Fri, 1 Dec 2023 11:46:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next v2 0/3] xsk: TX metadata txtime support Content-Language: en-US To: Song Yoong Siang , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Stanislav Fomichev , Lorenzo Bianconi , Tariq Toukan , Willem de Bruijn , Maxime Coquelin , Andrii Nakryiko , Mykola Lysenko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Alexandre Torgue , Jose Abreu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, bpf@vger.kernel.org, xdp-hints@xdp-project.net, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org References: <20231201062421.1074768-1-yoong.siang.song@intel.com> From: Jesper Dangaard Brouer In-Reply-To: <20231201062421.1074768-1-yoong.siang.song@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/1/23 07:24, Song Yoong Siang wrote: > This series expands XDP TX metadata framework to include ETF HW offload. > > Changes since v1: > - rename Time-Based Scheduling (TBS) to Earliest TxTime First (ETF) > - rename launch-time to txtime > I strongly disagree with this renaming (sorry to disagree with Willem). The i210 and i225 chips call this LaunchTime in their programmers datasheets, and even in the driver code[1]. Using this "txtime" name in the code is also confusing, because how can people reading the code know the difference between: - tmo_request_timestamp and tmo_request_txtime [1] https://github.com/xdp-project/xdp-project/blob/master/areas/tsn/code01_follow_qdisc_TSN_offload.org > v1: https://patchwork.kernel.org/project/netdevbpf/cover/20231130162028.852006-1-yoong.siang.song@intel.com/ > > Song Yoong Siang (3): > xsk: add ETF support to XDP Tx metadata > net: stmmac: Add txtime support to XDP ZC > selftests/bpf: Add txtime to xdp_hw_metadata > > Documentation/netlink/specs/netdev.yaml | 4 ++++ > Documentation/networking/xsk-tx-metadata.rst | 5 +++++ > drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ > .../net/ethernet/stmicro/stmmac/stmmac_main.c | 13 +++++++++++++ > include/net/xdp_sock.h | 9 +++++++++ > include/net/xdp_sock_drv.h | 1 + > include/uapi/linux/if_xdp.h | 9 +++++++++ > include/uapi/linux/netdev.h | 3 +++ > net/core/netdev-genl.c | 2 ++ > net/xdp/xsk.c | 3 +++ > tools/include/uapi/linux/if_xdp.h | 9 +++++++++ > tools/include/uapi/linux/netdev.h | 3 +++ > tools/net/ynl/generated/netdev-user.c | 1 + > tools/testing/selftests/bpf/xdp_hw_metadata.c | 18 +++++++++++++++++- > 14 files changed, 81 insertions(+), 1 deletion(-) >