From: Nandor Han <nandor.han@vaisala.com>
To: Sebastian Reichel <sre@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Sebastian Reichel <sebastian.reichel@collabora.com>,
kbuild test robot <lkp@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmem: core: fix nvmem_cell_write inline function
Date: Mon, 9 Sep 2019 12:26:06 +0300 [thread overview]
Message-ID: <d5017670-5622-283e-1376-8161d6e39dcd@vaisala.com> (raw)
In-Reply-To: <20190908121038.6877-1-sre@kernel.org>
On 9/8/19 3:10 PM, Sebastian Reichel wrote:
> From: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> nvmem_cell_write's buf argument uses different types based on
> the configuration of CONFIG_NVMEM. The function prototype for
> enabled NVMEM uses 'void *' type, but the static dummy function
> for disabled NVMEM uses 'const char *' instead. Fix the different
> behaviour by always expecting a 'void *' typed buf argument.
>
> Fixes: 7a78a7f7695b ("power: reset: nvmem-reboot-mode: use NVMEM as reboot mode write interface")
> Reported-by: kbuild test robot <lkp@intel.com>
> Cc: Han Nandor <nandor.han@vaisala.com>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> include/linux/nvmem-consumer.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/nvmem-consumer.h b/include/linux/nvmem-consumer.h
> index 8f8be5b00060..5c17cb733224 100644
> --- a/include/linux/nvmem-consumer.h
> +++ b/include/linux/nvmem-consumer.h
> @@ -118,7 +118,7 @@ static inline void *nvmem_cell_read(struct nvmem_cell *cell, size_t *len)
> }
>
> static inline int nvmem_cell_write(struct nvmem_cell *cell,
> - const char *buf, size_t len)
> + void *buf, size_t len)
nitpick: alignment issue?
Review-By: Han Nandor <nandor.han@vaisala.com>
Nandor
next prev parent reply other threads:[~2019-09-09 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 12:10 Sebastian Reichel
2019-09-09 9:26 ` Nandor Han [this message]
2019-09-09 10:18 ` Sebastian Reichel
2019-09-09 12:00 ` Nandor Han
2019-09-17 7:57 ` Arnd Bergmann
2019-09-17 8:20 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5017670-5622-283e-1376-8161d6e39dcd@vaisala.com \
--to=nandor.han@vaisala.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®