From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0786158DA3 for ; Sun, 1 Mar 2026 19:40:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772394020; cv=none; b=Gb1yAQ+XgLYqGrQry3BuHAGamlw+yOjPyf0fh1HonJ5Pj7hs9bwod7Jo3aTmcXEfLdRMqC31Jl7VsZ3BwNVIrKYAbuAFzg701DmMcGgB+7r15ZDt3hPFgNOKmQhwJ7NOhIc707a9GLa9JFC3VIEvQRuzquz/nzhBBITEh3TG9w0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772394020; c=relaxed/simple; bh=19nXduuhUEXa/o7HGpve065m+M1Y3LbjdQM08iXQT+A=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=M00RUzMh9q9kEm6L8nCs7Fi1TeejNYWY/5geVZb83+WztrBymD9/GZl+0SFMhtPXPG2UEqvDlrFebzZoO5yWgWvhxmBYBN2l6zPh57mVngT4mV8rtunAHIscVLP7Ca+lB+oTa8tpWOODZlwOogi5OBIkaNmbkUClO65jdFvLU+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y5B75DiX; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y5B75DiX" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-48371119eacso46620145e9.2 for ; Sun, 01 Mar 2026 11:40:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772394018; x=1772998818; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=19nXduuhUEXa/o7HGpve065m+M1Y3LbjdQM08iXQT+A=; b=Y5B75DiXXa4T9uPGgcJ23tGEtnSzXk64nozgkMAGI4IyqWclqs0F+nYONTdquNsd6C IoS+/h/pqlZf7xoiEje4WLFtSeF4KACrCJ4I6fUCBiiileo4afKj5jZA8xuPKBj0Opio D3QtzrJbJ6DFNjmeHM1fO+vRefALajEhIGkKcqvLGOFW+Ehcp25wT2okQ0UgZlc9xDXn xVrOh23vKy5opbq9fh1Ow0ewqrnPIvO5Tg6rdIn8P8fLn0x3U1ilFWyZgsjYH9ONb3IP wirRUuMOW0vYoVJt75HZ/8htURRqTVGPdzWReVz9FQZrZvE+wfvcAK/x8mcSklmMaH5w lwXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772394018; x=1772998818; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=19nXduuhUEXa/o7HGpve065m+M1Y3LbjdQM08iXQT+A=; b=GNE5LclNY9mtNUetNF2Y+SyQr5qTrJAkw27zfm5iYCVBeBc3n1t8d2Sw6jyWCHPrA4 x8f3KbHWNlJwjXdPmqNBCGJnWRFCbwR38392hX5kWpuhVJ3riQ+hM+j6ZIB+fxUciG28 Foas7Ld4bqMiGhiTjsGWab+cwxoVpKpVPWaCj8IIs3+bisIquSsBpT2CDgYSZxfp7Axp l9DPnrvR/VMtF6PA1k4QCyoEzjIYUCQotwVIF07xATU6zudt1MXrph5XOALuPBZsNhMB QVsPrpYicrIhoOd6N6N/OGEhRuz36Ld5e3vzA9rp+FGtXKeGeZxTOGmtyNRaRw6xXyIY eD8g== X-Gm-Message-State: AOJu0Yx3aUT6937X0ayUXQHs3nhkD61hERdpTqLHVxGh1ZcqErTzHzoe Mh4TLlAaGsak1655331FrWGJ8Dj7hXuKbqyU8QJQmmyxnufHhVRWslKN X-Gm-Gg: ATEYQzxt2muA7MvFKr7jHfMIpDWGjT5alPeNxL0YzlUxC10urouBpDImvwBTy3wqXxW pbVrErpsW0nrpUom0ss1VjxdEVuzavWXgon5XVmCj4b1Z4mNWmOIRADDGGOURtWdQzQ21AF/bHC g14WQC8zY96WDU1dwAu1VdcPTHO+qnqrqaS0+45MEa4CEN3ClX1MOcVbOiIvVufG4cEzMX05Xcg EfCRrAvrUSrdXLJMCdTPkXyWnoHtAtfCeIUDowMxyKTQD7wah1ADBb/ptonkVXQaW8QSJvb3ziR LdRZ6mjsUtTPGWFfkCvcQHZwmWsPK4ZGFI+ECAPOoRZBn5RvMD0JiLCx/4M28aw9ifhiucJ1bOo kNkBZb8bSSTl4izAyIr6uhTuo3S7ntqvgfY+oDtCGKWwHdBzC+oINwPcevQsUO+cY9xmUo+gRJN f2HVRoiXmhCJ87lBBb X-Received: by 2002:a05:600c:3f16:b0:477:79c7:8994 with SMTP id 5b1f17b1804b1-483c9c22e11mr172787865e9.30.1772394017731; Sun, 01 Mar 2026 11:40:17 -0800 (PST) Received: from [127.0.0.1] ([86.1.69.5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfcd0b14sm112023855e9.27.2026.03.01.11.40.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Mar 2026 11:40:17 -0800 (PST) Date: Sun, 1 Mar 2026 19:40:16 +0000 From: Josh Law To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Josh Law Message-ID: In-Reply-To: <20260301112542.0d915c2388febccf0294b880@linux-foundation.org> References: <20260301152143.2572137-1-objecting@objecting.org> <20260301152143.2572137-2-objecting@objecting.org> <20260301112542.0d915c2388febccf0294b880@linux-foundation.org> Subject: Re: [PATCH 2/2] lib: glob: replace bitwise OR with logical operation on boolean Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: Hm, I see that, I am sorry about that haha, I tested the functionality of t= he code and it seems all fine, if anything major happens, I'll release anot= her patch fixing this, I am sorry V/R 1 Mar 2026 19:25:44 Andrew Morton : > On Sun,=C2=A0 1 Mar 2026 15:21:42 +0000 Josh Law = wrote: >=20 >> Using bitwise OR (|=3D) on a boolean variable is valid C, but replacing = it with a direct logical assignment makes the intent clearer and appeases s= trict static analysis tools. >>=20 >=20 > Fair enough. >=20 >> --- a/lib/glob.c >> +++ b/lib/glob.c >> @@ -96,7 +96,8 @@ bool __pure glob_match(char const *pat, char const *st= r) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 class +=3D 2; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Any special action if a > b? = */ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 } >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 match |=3D (a <=3D c && c <=3D b); >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 if (a <=3D c && c <=3D b) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 match =3D true; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } whi= le ((a =3D *class++) !=3D ']'); >>=20 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (m= atch =3D=3D inverted) >=20 > But if we're concerned about bool abuse, what's this? >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bool m= atch =3D false, inverted =3D (*pat =3D=3D '!'); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 char c= onst *class =3D pat + inverted;