From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31351385D88 for ; Mon, 1 Jun 2026 08:59:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780304389; cv=none; b=ZiUOiS75hy0pZCm2Bt6gvRaLgg42P4rV23YdKZ7cIgNDpWQWo2cjCtqF2WU/6LLaW0JmDrv9d2M5pw+qneopRa1YvSHfSYs7rl+aifgUe0oow7yYgElJYxOh6C4ujd3x6b/qDLHdd/Z+4gt8dvHKU1cLWESLV90LZAyN7WTMYGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780304389; c=relaxed/simple; bh=TVScjomRSl5LC4nYX6rpuR5ukHlnDDLqc89RHEGAHhk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KWKdIUv195HL39vEo4L1g3uqLb+8JLx26xdBPfFzcKTq14uAt2RblQwdWvLpm1PNHdQNIsNmmZQ+j1maidX28aDZL1DBMiKC8dT02QnED3xAHF75EPQ/F5hE4vJQQGw2BxwBusBgkT4jHR10dR5BBqmIhF1MDQ9OI84sl+d1RrI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GD7GI+AA; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=tHSjnK4B; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GD7GI+AA"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="tHSjnK4B" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780304387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dh3UalaMjz0IAlXO6aVjAsVqA/VpmRztwPbl3KV7dus=; b=GD7GI+AAK6CTkJHy2wiGIHb6Ndj55thF4qjrkDknpfTpnLQmwmBs9/PKuBSDHTs8r90VGF wCTiBlWcRGbs96C46CmbpsL31jREF/bvrJL08TvIFK+Tw4jmJg37CQy9H+IOJ+X1ObEd2V 5EiXrMT+J/0h0+M4om4vWhXTQ3iCQrQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-416-HHXDI1MtMJ6w2NqwRflsxQ-1; Mon, 01 Jun 2026 04:59:46 -0400 X-MC-Unique: HHXDI1MtMJ6w2NqwRflsxQ-1 X-Mimecast-MFC-AGG-ID: HHXDI1MtMJ6w2NqwRflsxQ_1780304385 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4904ee02e72so78630895e9.1 for ; Mon, 01 Jun 2026 01:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780304385; x=1780909185; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Dh3UalaMjz0IAlXO6aVjAsVqA/VpmRztwPbl3KV7dus=; b=tHSjnK4BE1Ea1rHLWmt0SOxeVJSYpyUGoEqd16swGyVcPngWzbOMKg28FZ8DKjB5FX jeBVoOWx+IKhouqvvZCM3EaW4n8NRw4iBhQv2JnZe1lBdtE7ALzF7IxNiVaR3U45QRHZ FnQQw5zU58cvjXw0IMXVieO3sWdLaxPJWhzm+nd5O4swSHOZkTHS0a3u1kLvixz2096S jxuYjPcUN/v1MjQIxZ+p0BaPgA/42nVWdU7OiW6jjw8OvAcOHnB0fiWCbzwrumuO1WeF 1ZHLEzbRryFfDSpXLqVG1Lia49WXOeSWI6+fMeFqQ0X3w+oBbbky0hJnxUCIJusHRGto /K7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780304385; x=1780909185; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Dh3UalaMjz0IAlXO6aVjAsVqA/VpmRztwPbl3KV7dus=; b=IK3UacZi6U4Ez5bcfGQu3cE6RF9f2PYF0FiOJz9l7FbxEuoNurYyDxxY9v+rXr+Gvg nLg9zdBJjZsurzwfQb3sZNayGmRrgYHkhZU5B2CDT2dxuDtRnW2OH+aNvi+YyG1Y2I0A PG4klbBL+YBOm1beveo95PsNLO0YVEYU/R4y8afIIY55vtFNeBLHhmlk9tS8EsYzZkNS 2U4eAXE/NthIDsFgJwUqfG3HOsp5hXBlwtpMnCbtqTNiGI54w7yzhIz8mrAkx6kMb1MY O+qXgnZbb73qanJKnTE3S6lhyDHCCNkb+THVEOkkWLlvICWIIkW0iHr20Eaz3bzeVXjM TMFQ== X-Forwarded-Encrypted: i=1; AFNElJ+EvOvw9TtHA4bPwa7Nu5ycVIH11sJnHLJGgEV62nbxrMqqZNI1ui/B7Hhu1AvKV12csrFKsnvcQ9uOngY=@vger.kernel.org X-Gm-Message-State: AOJu0YzrZJT1E/xbUdHmzQyKK0oxbXA1civhAkcc93BttdJnvuBLV5FR 0+v8e0DiQlQLRlG8ujk5nfEVLc6bxeR26RyN34XvKrOvVtTOffYbtjFbO9+gLsaNA+h2xQfHWPC qXmrs2Rsqu/RYAIf5Ru0mN/L55JUbPPZ83X80aWCQbvxhFclx/us0ojqg+REqT9GZpg== X-Gm-Gg: Acq92OGa88kU3NPPazHzUf5+j9OLmu0OXD0US1KxPSBThfjh2o6oLwNjJNunKFe11UC lu0pV1oShaWzrABGjybxopIecAcgI2Tf2r/kYERxE56r9F5ItgetP1/PIvYCtdP8i94JLDcbdWa OJGOFIkxYVKR7p281+wgg8NOaTtrpgcpG7UjwBH9Y8n18OlLPcWAfFx0m82EHh4QW10gPAdCF8d FvktOefvx70Kiyut0/YD67PkM/RlaswJR3hV+AUqwTrvmn4otWa1FVkHT/N1RT0jjXA3ykEeS0X awprZFpEJqyCa0nm0afeemxgvD2EJ4+IpwLn1O/foBjFrc3LWQ36iC8iM3VGQcCY1vMak5lz8vD BlLA3aWmYyr86VmlfP2mZUYp8ueAcsmzXwiP9HnSvKzafzCidRaZ8azQoVGSxqRBPFgXS X-Received: by 2002:a05:600c:6214:b0:490:44eb:c1d7 with SMTP id 5b1f17b1804b1-490a297e571mr227396035e9.30.1780304384922; Mon, 01 Jun 2026 01:59:44 -0700 (PDT) X-Received: by 2002:a05:600c:6214:b0:490:44eb:c1d7 with SMTP id 5b1f17b1804b1-490a297e571mr227395355e9.30.1780304384483; Mon, 01 Jun 2026 01:59:44 -0700 (PDT) Received: from [192.168.88.32] ([169.155.232.197]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909d6a0a89sm252667425e9.7.2026.06.01.01.59.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2026 01:59:43 -0700 (PDT) Message-ID: Date: Mon, 1 Jun 2026 10:59:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 6/9] net: dsa: microchip: implement .{get/set}_wol only if needed To: "Bastien Curutchet (Schneider Electric)" , Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Russell King Cc: Pascal Eberhard , =?UTF-8?Q?Miqu=C3=A8l_Raynal?= , Thomas Petazzoni , Tristram Ha , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260526-clean-ksz-3rd-v1-0-5b63e732149a@bootlin.com> <20260526-clean-ksz-3rd-v1-6-5b63e732149a@bootlin.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260526-clean-ksz-3rd-v1-6-5b63e732149a@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/26/26 11:47 AM, Bastien Curutchet (Schneider Electric) wrote: > @@ -3798,9 +3795,6 @@ int ksz_set_wol(struct dsa_switch *ds, int port, > if (wol->wolopts & ~(WAKE_PHY | WAKE_MAGIC)) > return -EINVAL; > > - if (!is_ksz9477(dev) && !ksz_is_ksz87xx(dev)) > - return -EOPNOTSUPP; Sashiko noted there is still a ksz_is_ksz87xx(dev) check in ksz_wol_pre_shutdown() which would probably keep WoL broken for the newly enabled switches. /P