From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03074C433F5 for ; Wed, 25 May 2022 14:15:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244733AbiEYOO4 (ORCPT ); Wed, 25 May 2022 10:14:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244111AbiEYOOw (ORCPT ); Wed, 25 May 2022 10:14:52 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 75696ABF79 for ; Wed, 25 May 2022 07:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653488090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wM9x4B2z5qH/AhZypEbIZLZ9L9qM+TiDof1TvDE3R8I=; b=DiwoCDHY0bTsvjojy12OekRANEYMuWzJA+buu2U80YxiO0E/+6NJumlT6kn9T7ntupg8Kv wvivs/JjDNLd0oBae6dkHXPMlyYhd34kl0xdDlr7Ymjv3el+FtcHeqMjht2w0KfYss+xcc pXhvMEa9+bSFURNw1/pQgYxWdR/U4l8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-613-aKo3TEKsO7mXUocalVHJtQ-1; Wed, 25 May 2022 10:14:49 -0400 X-MC-Unique: aKo3TEKsO7mXUocalVHJtQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B2AE5185A794; Wed, 25 May 2022 14:14:48 +0000 (UTC) Received: from starship (unknown [10.40.192.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9794A1121315; Wed, 25 May 2022 14:14:46 +0000 (UTC) Message-ID: Subject: Re: [PATCH RESEND v12 00/17] KVM: x86/pmu: Add basic support to enable guest PEBS via DS From: Maxim Levitsky To: Paolo Bonzini , Like Xu Cc: Sean Christopherson , Wanpeng Li , Joerg Roedel , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Jim Mattson , Vitaly Kuznetsov Date: Wed, 25 May 2022 17:14:45 +0300 In-Reply-To: References: <20220411101946.20262-1-likexu@tencent.com> <87fsl5u3bg.fsf@redhat.com> <874k1ltw9y.fsf@redhat.com> <0848a2da-c9cf-6973-c774-ff16c3e8a248@redhat.com> <289d0c88-36a0-afd4-4d47-f2db3fb63654@gmail.com> <48b495c5610d25596a268c71b627b2e2136ac0bd.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2022-05-25 at 16:13 +0200, Paolo Bonzini wrote: > On 5/25/22 16:12, Maxim Levitsky wrote: > > FYI, this patch series also break 'msr' test in kvm-unit tests. > > (kvm/queue of today, and master of the kvm-unit-tests repo) > > > > The test tries to set the MSR_IA32_MISC_ENABLE to 0x400c51889 and gets #GP. > > > > > > Commenting this out, gets rid of #GP, but test still fails with unexpected result > > > > if (!msr_info->host_initiated && > > ((old_val ^ data) & MSR_IA32_MISC_ENABLE_PEBS_UNAVAIL)) > > return 1; > > > > > > > > > > It is very possible that the test is broken, I'll check this later. > > Yes, for that I've sent a patch already: > > https://lore.kernel.org/kvm/20220520183207.7952-1-pbonzini@redhat.com/ > > Paolo > Thank you very much! Best regards, Maxim Levitsky