From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 694F7C4708F for ; Wed, 2 Jun 2021 22:10:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38998613E4 for ; Wed, 2 Jun 2021 22:10:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229746AbhFBWM1 (ORCPT ); Wed, 2 Jun 2021 18:12:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57976 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbhFBWM0 (ORCPT ); Wed, 2 Jun 2021 18:12:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622671842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KUjPsHJ5PuL6/0to9YlDMTSAeVkKxMJlKUQySExiimw=; b=PPnd7cbdSdZnyQkwBUNBpTBXHrFVLM+FxRphCu+vSx/o390jD3up818s70L0FDeSJFzUWz vchmeJqF6JLDSZEBxivSYcIaC03yTfHdmGFpPtZBtVTJLZS/fzblZoS35YQrlE5JuI7ieZ gpfD2pPPSf4RPSro6t9R3OczFVQttlA= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-308-3JE4iHMPNFSFqKAB6R_wjg-1; Wed, 02 Jun 2021 18:10:41 -0400 X-MC-Unique: 3JE4iHMPNFSFqKAB6R_wjg-1 Received: by mail-ot1-f72.google.com with SMTP id y2-20020a0568301082b02903b5696f0a64so2352221oto.2 for ; Wed, 02 Jun 2021 15:10:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=KUjPsHJ5PuL6/0to9YlDMTSAeVkKxMJlKUQySExiimw=; b=KqH1uV37qtEPqqe/99Q5WN0WCtIcbQDDY67Is9EbcuNamnZLpiE8XtKa2Orf8Rgu4y +R5aZ7AqTc444cj2tbTV3cXCJR4uWtYtpoBlK8s2eSOC1ikaUw0iFxkyA8viJhS9v8tr vh2S9JCY1YlUHKREVROUlHtTNNK6+GrEWYU48BOOnmp3B4zYs1dqxm5u9vE3TXCZ4mjK sjlTZi2/O9Z26bYrfVkAmlmUmhKp4edDMklAJsjMCVNASmas5Mbe+SEJZ85UQGtgXC8I RbT/xnuCXSg8hmsd1i0UXwmUd4hzvj4EvHcW219/uosULiqEaF1zUcOGfhVoNwqeGlmv wfAw== X-Gm-Message-State: AOAM533whtNnt83TZYyRSDY87sMC9RNYptoRmmxA6sHFiX9BLX8mYElP JKHrnoYD62P7l8IXZO13DfUEtJKd6qEtE08E+2ujC5/4kW6IvQ3ALukLe856nCEfc+DVMEzBjhZ EW/Tj96hf9lda47ufIyAdw1sCujWdRU+YpGFk59iH9phwUWeJV9hY5IzuNtwQGYA8nAAc8BY= X-Received: by 2002:a4a:250e:: with SMTP id g14mr26331509ooa.31.1622671840247; Wed, 02 Jun 2021 15:10:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3zxkPypJY+pMoZE8TmBBmrm3L1q7RwDYe8CB03JX/l9KFF+IfYbxpLYjT9JpPttLssjAZEg== X-Received: by 2002:a4a:250e:: with SMTP id g14mr26331490ooa.31.1622671840004; Wed, 02 Jun 2021 15:10:40 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id 15sm283172oij.26.2021.06.02.15.10.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 15:10:39 -0700 (PDT) Subject: Re: [PATCH] powerpc/8xx: select CPM1 for MPC8XXFADS To: Christophe Leroy , mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20210601175304.2634549-1-trix@redhat.com> <50ed000a-c1af-8552-9d35-771b3bc131e5@csgroup.eu> From: Tom Rix Message-ID: Date: Wed, 2 Jun 2021 15:10:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <50ed000a-c1af-8552-9d35-771b3bc131e5@csgroup.eu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/2/21 12:44 AM, Christophe Leroy wrote: > > > Le 01/06/2021 à 19:53, trix@redhat.com a écrit : >> From: Tom Rix >> >> With MPC8XXFADS, there is this linker error >> ppc64-linux-ld: m8xx_setup.o: in function `cpm_cascade': >> m8xx_setup.c: undefined reference to `cpm_get_irq' > > It looks like this config item is stale, it doesn't build any board > support, there is no define_machine() for this config item, no file is > linked to that config item. > > I think you should just remove that item from the possible choices. > Yes, this looks like a dead config and removing it is what to do. I withdraw this change. I am looking at sweeping the tree of dead configs. Up a dir, my finder shows PPC_MMU_NOHASH_32 is another (maybe) dead config. Thanks for pointing this out, Tom > Christophe > > >> >> cpm_get_irq() is conditionally complied by CPM1 >> So add a select, like the other plaforms >> >> Signed-off-by: Tom Rix >> --- >>   arch/powerpc/platforms/8xx/Kconfig | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/arch/powerpc/platforms/8xx/Kconfig >> b/arch/powerpc/platforms/8xx/Kconfig >> index 60cc5b537a98..919082cdb2f1 100644 >> --- a/arch/powerpc/platforms/8xx/Kconfig >> +++ b/arch/powerpc/platforms/8xx/Kconfig >> @@ -10,6 +10,7 @@ choice >>     config MPC8XXFADS >>       bool "FADS" >> +    select CPM1 >>     config MPC86XADS >>       bool "MPC86XADS" >> >