From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A191D3EC686 for ; Mon, 24 Aug 2026 07:05:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787555132; cv=none; b=UZqi7gB1xjEj582qkrC9VhYnPKPWiYOnhtYU5StvTYH/8gjkNpCkp1utucXlluxizKxK7qHPOfp+VMA78PsoTadS1/Wsimp3okKsCIlu0EMxU4LQ9ceQhKwLzQulAaY92RHd3yuXINj2bX72/lheDzOtqZbGD1CB7v9tYGWvcnw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787555132; c=relaxed/simple; bh=o6kv97c2BzQjYfdoD2Oo7dnr+9bQwYqI5VXz8Ti7HwQ=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=bZuBNTfL7BZszeCg24rsoTjo77JJaqsaPcUVzQZz0C3mYadMab7RYqvLO03Wc/N7C7SL/Y0qs5EhyAuqZMCcR/sSMqOcgdTrnDcen7LSC2G7IF3VajE+j2hu+hJTnany0hAUV7IkY5TNLJpXsRZdQ7NzJ+JG5Mpin7h6StG5S5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mdtT6ya4; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mdtT6ya4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 279D51F000E9; Mon, 24 Aug 2026 07:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787555131; bh=t/xMoMYSD6XciRri3+suQ8PHhr1s8NaBhYq7YB/JY3Y=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=mdtT6ya4HbSImTjij/+puBesKzK3j9HRahVmvLqnnTOmWE6CekBp3cEpMXnQp7u71 L4UDH34TldJLSZupnUK+HKsIVwaQLNuSRnQcoHsEjX3Fdqu5wC6boOX5wv2q/waeeU ZJai8DLJ65tYb+ix1ZrkNHYYuV+h2QNZqmm9GWNRkq+8GySSS7BV7tVJHB1isJBJX1 4Rjw8M19cg1uytq/OfFIOvABUK/siU1jVrWKwQZwuZR+b8dt6+u1jU8IGEgyCe1r3h bFQYmypENl9YuoQ2fhETOBwp9si0flTWZ69Pt8si24YUHmGVlFQNZ9sSv0tjEHu0Uh XRunhBkHn7sfA== Message-ID: Date: Mon, 24 Aug 2026 15:05:28 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, Wenjie Qi , Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v1 05/12] f2fs: cache: use meta cache To: Wenjie Qi References: <20260820031721.12218-1-chao@kernel.org> <20260820031721.12218-6-chao@kernel.org> <20260823125546.3229535-1-qiwenjie@xiaomi.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260823125546.3229535-1-qiwenjie@xiaomi.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/23/26 20:55, Wenjie Qi wrote: > Hi Chao, > >> struct f2fs_cached_block *f2fs_get_sum_cache(struct f2fs_sb_info *sbi, >> unsigned int segno) >> { >> if (unlikely(f2fs_cp_error(sbi))) >> return ERR_PTR(-EIO); >> return f2fs_get_meta_cache_retry(sbi, GET_SUM_BLOCK(sbi, segno)); >> } >> >> entry = f2fs_get_sum_cache(sbi, GET_SUM_BLOCK(sbi, segno)); > > `f2fs_get_sum_cache()` applies `GET_SUM_BLOCK()` to its argument. Its other > callers pass a logical segment number, while this packed-SSA path passes an > already translated value. > > Is the argument contract of `f2fs_get_sum_cache()` a logical segment number > or an already translated block address? Oops, should use f2fs_get_sum_cache(sbi, segno) here. Thanks,