From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756828AbdLOPZn (ORCPT ); Fri, 15 Dec 2017 10:25:43 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34409 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756767AbdLOPZh (ORCPT ); Fri, 15 Dec 2017 10:25:37 -0500 X-Google-Smtp-Source: ACJfBov9CcpeLMDAUS6+/qadTv4Ds9XYPU2zeAM4LaGskfmxDy5CTUptmduNepoHtP0suRoqjL8MIg== Subject: Re: [PATCH] drm/tegra: mark t186 display hub PM functions __maybe_unused To: Thierry Reding , Arnd Bergmann Cc: David Airlie , Jonathan Hunter , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171215125205.2969211-1-arnd@arndb.de> <20171215133340.GA353@ulmo> From: Dmitry Osipenko Message-ID: Date: Fri, 15 Dec 2017 18:25:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171215133340.GA353@ulmo> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15.12.2017 16:33, Thierry Reding wrote: > On Fri, Dec 15, 2017 at 01:51:52PM +0100, Arnd Bergmann wrote: >> The newly introduced driver has optional suspend/resume functions, >> causing a warning when CONFIG_PM is disabled: >> >> drivers/gpu/drm/tegra/hub.c:749:12: error: 'tegra_display_hub_resume' defined but not used [-Werror=unused-function] >> drivers/gpu/drm/tegra/hub.c:733:12: error: 'tegra_display_hub_suspend' defined but not used [-Werror=unused-function] >> >> This marks them __maybe_unused to shut up the warnings. >> >> Fixes: c4755fb9064f ("drm/tegra: Add Tegra186 display hub support") >> Signed-off-by: Arnd Bergmann >> --- >> drivers/gpu/drm/tegra/hub.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > We had touched on this topic in a different thread. The Tegra DRM driver > currently relies on runtime PM to work properly. I don't see a reason to > not make that official by adding a select PM to menuconfig ARCH_TEGRA on > 32-bit ARM just like we already do on 64-bit ARM. Since you've repeated the third time that you 'don't see a reason', I'll take it as NAK for my patch that made drm/tegra to work with the disabled PM and drop it. Next time please state it clearly if you oppose to something strongly. Thanks.