Re: [PATCH RFT v2] driver/scsi/mpi3mr: Fix build warning for mpi3mr_start_watchdog

[Bart Van Assche <bvanassche@acm.org>]

On 11/15/25 6:31 AM, Bartłomiej Kubik wrote:
>>> diff --git a/drivers/scsi/mpi3mr/mpi3mr_fw.c b/drivers/scsi/mpi3mr/mpi3mr_fw.c
>>> index 8fe6e0bf342e..18b176e358c5 100644
>>> --- a/drivers/scsi/mpi3mr/mpi3mr_fw.c
>>> +++ b/drivers/scsi/mpi3mr/mpi3mr_fw.c
>>> @@ -2879,8 +2879,7 @@ void mpi3mr_start_watchdog(struct mpi3mr_ioc *mrioc)
>>>
>>>        INIT_DELAYED_WORK(&mrioc->watchdog_work, mpi3mr_watchdog_work);
>>>        snprintf(mrioc->watchdog_work_q_name,
>>> -         sizeof(mrioc->watchdog_work_q_name), "watchdog_%s%d", mrioc->name,
>>> -         mrioc->id);
>>> +         sizeof(mrioc->watchdog_work_q_name), "watchdog_%s", mrioc->name);
>>>        mrioc->watchdog_work_q = alloc_ordered_workqueue(
>>>                "%s", WQ_MEM_RECLAIM, mrioc->watchdog_work_q_name);
>>>        if (!mrioc->watchdog_work_q) {
>> Leaving out mrioc->id from the workqueue name seems like an unacceptable
>> behavior change to me.
> 
> Add twice the same ID one after one. Is it not a mistake ??
> If mrioc->name has that same ID at the end.
> 
> sprintf(mrioc->name, "%s%d", mrioc->driver_name, mrioc->id)
> 
> watchdog_work_q_name is built from mrioc->name which has this ID at the end.
> If I see correctly, if mrioc->id will be 1 then  watchdog_work_q_name
> will look like
> watchdog_mpi3mr11, but I think it should be watchdog_mpi3mr1, or am I missing
> something??

I'm not sure - I'm not familiar myself with the mpi3mr driver. I will
let someone who is familiar with this driver comment on this.

Thanks,

Bart.