From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751514AbdAaKlq (ORCPT ); Tue, 31 Jan 2017 05:41:46 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:8132 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751367AbdAaKlj (ORCPT ); Tue, 31 Jan 2017 05:41:39 -0500 Subject: Re: [PATCH 01/17] net: stmmac: fix the typo on MAC_RNABLE_RX To: Corentin Labbe , , References: <20170131091152.13842-1-clabbe.montjoie@gmail.com> <20170131091152.13842-2-clabbe.montjoie@gmail.com> CC: , From: Giuseppe CAVALLARO Message-ID: Date: Tue, 31 Jan 2017 11:03:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20170131091152.13842-2-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG4NODE3.st.com (10.75.127.12) To SFHDAG4NODE1.st.com (10.75.127.10) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-31_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/31/2017 10:11 AM, Corentin Labbe wrote: > the define MAC_RNABLE_RX have a typo, rename it to MAC_ENABLE_RX > > Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro > --- > drivers/net/ethernet/stmicro/stmmac/common.h | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h > index b13a144..0f90f91 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/common.h > +++ b/drivers/net/ethernet/stmicro/stmmac/common.h > @@ -340,7 +340,7 @@ struct dma_features { > /* Common MAC defines */ > #define MAC_CTRL_REG 0x00000000 /* MAC Control */ > #define MAC_ENABLE_TX 0x00000008 /* Transmitter Enable */ > -#define MAC_RNABLE_RX 0x00000004 /* Receiver Enable */ > +#define MAC_ENABLE_RX 0x00000004 /* Receiver Enable */ > > /* Default LPI timers */ > #define STMMAC_DEFAULT_LIT_LS 0x3E8 > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c b/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c > index 84e3e84..a414bde 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c > @@ -261,9 +261,9 @@ void stmmac_set_mac(void __iomem *ioaddr, bool enable) > u32 value = readl(ioaddr + MAC_CTRL_REG); > > if (enable) > - value |= MAC_RNABLE_RX | MAC_ENABLE_TX; > + value |= MAC_ENABLE_RX | MAC_ENABLE_TX; > else > - value &= ~(MAC_ENABLE_TX | MAC_RNABLE_RX); > + value &= ~(MAC_ENABLE_TX | MAC_ENABLE_RX); > > writel(value, ioaddr + MAC_CTRL_REG); > } >