mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Jamie Iles <jamie@jamieiles.com>, <maz@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] irqchip/xilinx: add explicit dependency on OF_ADDRESS
Date: Thu, 30 Jun 2022 14:33:25 +0200	[thread overview]
Message-ID: <d51b5494-66db-69a8-cd34-40d33f4f212b@amd.com> (raw)
In-Reply-To: <20220630111008.3838307-1-jamie@jamieiles.com>



On 6/30/22 13:10, Jamie Iles wrote:
> Commit b84dc7f0e364 ("irqchip/xilinx: Remove microblaze+zynq
> dependency") relaxed the dependencies on the Xilinx interrupt controller
> to be OF only, but some OF architectures (s390 for example) do not
> support OF_ADDRESS and so a build of the driver will result in undefined
> references to of_iomap/iounmap and friends.
> 

Can you please add here fixed tag?

> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jamie Iles <jamie@jamieiles.com>
> ---
>   drivers/irqchip/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 1f23a6be7d88..bbb11cb8b0f7 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -298,7 +298,7 @@ config XTENSA_MX
>   
>   config XILINX_INTC
>   	bool "Xilinx Interrupt Controller IP"
> -	depends on OF
> +	depends on OF_ADDRESS
>   	select IRQ_DOMAIN
>   	help
>   	  Support for the Xilinx Interrupt Controller IP core.

When above added feel free to add my
Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal

  reply	other threads:[~2022-06-30 12:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-30 11:10 Jamie Iles
2022-06-30 12:33 ` Michal Simek [this message]
2022-07-01 13:29 ` [irqchip: irq/irqchip-fixes] irqchip/xilinx: Add " irqchip-bot for Jamie Iles
2022-06-30 13:26 [PATCH] irqchip/xilinx: add " Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d51b5494-66db-69a8-cd34-40d33f4f212b@amd.com \
    --to=michal.simek@amd.com \
    --cc=jamie@jamieiles.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=maz@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®