From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751609AbdBUUXC (ORCPT <rfc822;w@1wt.eu>);
        Tue, 21 Feb 2017 15:23:02 -0500
Received: from mail-pg0-f47.google.com ([74.125.83.47]:36847 "EHLO
        mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751127AbdBUUW4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 21 Feb 2017 15:22:56 -0500
Subject: Re: [PATCH v2 5/6] DT bindings documentation for Broadcom IPROC USB
 Device controller.
To: Raviteja Garimella <raviteja.garimella@broadcom.com>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Felipe Balbi <balbi@kernel.org>
References: <1487677384-6115-1-git-send-email-raviteja.garimella@broadcom.com>
 <1487677384-6115-6-git-send-email-raviteja.garimella@broadcom.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com, linux-usb@vger.kernel.org
From: Scott Branden <scott.branden@broadcom.com>
Message-ID: <d51ea8d3-2355-e77b-3ad6-b5dc71436744@broadcom.com>
Date: Tue, 21 Feb 2017 12:22:52 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <1487677384-6115-6-git-send-email-raviteja.garimella@broadcom.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Raviteja,

updates inline

On 17-02-21 03:43 AM, Raviteja Garimella wrote:
> The device node is used for UDCs integrated into Broadcom's
> iProc family of SoCs'. The UDC is based on Synopsys Designware
> Cores AHB Subsystem USB Device Controller IP.
>
> Signed-off-by: Raviteja Garimella <raviteja.garimella@broadcom.com>
> ---
>  Documentation/devicetree/bindings/usb/iproc-udc.txt | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/iproc-udc.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/iproc-udc.txt b/Documentation/devicetree/bindings/usb/iproc-udc.txt
> new file mode 100644
> index 0000000..c2ce803
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/iproc-udc.txt
> @@ -0,0 +1,21 @@
> +Broadcom IPROC USB Device controller.
> +
> +The device node is used for UDCs integrated into Broadcom's
> +iProc family (Northstar2, Cygnus) of SoCs'. The UDC is based
> +on Synopsys Designware Cores AHB Subsystem Device Controller
> +IP.
> +
> +Required properties:
> + - compatible: Add the compatibility strings for supported platforms.
> +   For Broadcom NS2 platform, add "brcm,ns2-udc".
    For Broadcom NS2 platform, add "brcm,ns2-udc", "brcm,iproc-udc".
> +   For Broadcom Cygnus platform, add "brcm,cygnus-udc".
    For Broadcom Cygnus platform, add "brcm,cygnus-udc", "brcm,iproc-udc".
> + - reg: Offset and length of UDC register set
> + - interrupts: description of interrupt line
> + - phys: phandle to phy node.
> +
> +Example:
> +	udc_dwc: usb@664e0000 {
> +		compatible = "brcm,ns2-udc", "brcm,cygnus-udc";
		compatible = "brcm,ns2-udc", "brcm,iproc-udc";
> +		reg = <0x664e0000 0x2000>;
> +		interrupts = <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>;
> +		phys = <&usbdrd_phy>;
>
Regards,
  Scott