mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: rohit verma <rohit.170309@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: issue with epoll syscall
Date: Fri, 8 May 2009 09:36:52 +0530	[thread overview]
Message-ID: <d51f89b0905072106q6f4c3eb8n663798c485f2ec44@mail.gmail.com> (raw)

hi all,

The man pages of epoll_create says - "Since Linux 2.6.8, the size
argument is unused.  (The kernel dynamically sizes the required data
structures without needing this initial hint.)" .

Also, it says that the syscall returns EINVAL , when size is not
positive. (i.e For, any value greater than 0, the kernel dynamically
sizes the required data stuctures). When size is zero or less than
zero, it has to return with error as EINVAL.

the latest patch of the epoll syscall tells:

asmlinkage long sys_epoll_create(int size)
{
- return sys_epoll_create2(size,0);
+ if (size < 0)
+  return -EINVAL;
+
+return sys_epoll_create1(0);
}

So if size = 0, it returns success which might not be the expected
result. So i feel that the condition check should be
" if (size <= 0) ". could u please check on this and reply me..

Thank you,

Regards,
rohit

                 reply	other threads:[~2009-05-08  4:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d51f89b0905072106q6f4c3eb8n663798c485f2ec44@mail.gmail.com \
    --to=rohit.170309@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®