From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D159C4360C for ; Mon, 10 May 2021 13:02:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3627C611BD for ; Mon, 10 May 2021 13:02:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349871AbhEJMzV (ORCPT ); Mon, 10 May 2021 08:55:21 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:43292 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244293AbhEJMT5 (ORCPT ); Mon, 10 May 2021 08:19:57 -0400 Received: from mail-qk1-f199.google.com ([209.85.222.199]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lg4s8-00039O-3b for linux-kernel@vger.kernel.org; Mon, 10 May 2021 12:18:52 +0000 Received: by mail-qk1-f199.google.com with SMTP id p17-20020a05620a1131b02902e45c6e4d33so11499323qkk.0 for ; Mon, 10 May 2021 05:18:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qw2xIhE1YQPqR0OG1inwWyXnTht9gARQqIiYkO8Zeek=; b=Mh4QqOjheqrQx0f1nwzDOPkEYixbrU0HFaHJj3vF8MGZKbvSt5renhYdGl/TmEmXrq RE93b9CAk4sz5lAPR+qMSPQuHkv/tEA4YL/UgFvhX2mWlkUoIcdevw0d6J8yVVbOUUjO NfBEouxmIzHSH7UahdOyzC2v2B+VMua74LNJQoNWHNskSHrJxmDntWjMeB5HAxSRuvtl fpOeTWGiqwza29PVlcACewtghw41ScZXguCSpUY2Uc9v74JtsstJsMSicxyAlVWxdP7K lScvTJi/wRuBEgA5rHQK8Ivt2bP6PfRQaOQrsbyO+lAKgWNmLUov45DZA8R7+kEoY6qg l/Rg== X-Gm-Message-State: AOAM531ApY+PVPU33ImvmU7HprdKcGTFrInv3uC/FB/MqC72EZVazXkd EcXOvHGernKfdONHKl6rMb6mhT7PKrpZ4iUL91UHuQsglOiMBl54Fli4vaOe8rhGGW+bc5v/0ef SrxKy7FU8f8/BO6cqT5GmCbfhGxeTwIA9ob7NYC7Ung== X-Received: by 2002:a37:61cd:: with SMTP id v196mr19056886qkb.454.1620649131209; Mon, 10 May 2021 05:18:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyunxzu4B8x+Dts17JtJ41BIvhjuofWIqji9fp6Sm5lxjBnUuVITR4zQbsN+I/u5NwXYtqC6Q== X-Received: by 2002:a37:61cd:: with SMTP id v196mr19056870qkb.454.1620649131056; Mon, 10 May 2021 05:18:51 -0700 (PDT) Received: from [192.168.1.4] ([45.237.49.2]) by smtp.gmail.com with ESMTPSA id m205sm4051312qke.2.2021.05.10.05.18.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 05:18:50 -0700 (PDT) Subject: Re: [PATCH] rtc: max77686: Remove some dead code To: Christophe JAILLET , cw00.choi@samsung.com, b.zolnierkie@samsung.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: Krzysztof Kozlowski Message-ID: Date: Mon, 10 May 2021 08:18:48 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/05/2021 01:43, Christophe JAILLET wrote: > 'ret' is known to be an error pointer here, so it can't be 0. > Remove this dead code. > > Signed-off-by: Christophe JAILLET > --- > drivers/rtc/rtc-max77686.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c > index d51cc12114cb..ce089ed934ad 100644 > --- a/drivers/rtc/rtc-max77686.c > +++ b/drivers/rtc/rtc-max77686.c > @@ -764,8 +764,6 @@ static int max77686_rtc_probe(struct platform_device *pdev) > if (IS_ERR(info->rtc_dev)) { > ret = PTR_ERR(info->rtc_dev); > dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret); > - if (ret == 0) > - ret = -EINVAL; > goto err_rtc; Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof