From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35210C433F5 for ; Tue, 8 Feb 2022 08:00:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348721AbiBHIAt (ORCPT ); Tue, 8 Feb 2022 03:00:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348723AbiBHIAp (ORCPT ); Tue, 8 Feb 2022 03:00:45 -0500 Received: from out199-12.us.a.mail.aliyun.com (out199-12.us.a.mail.aliyun.com [47.90.199.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CA86C0401F6 for ; Tue, 8 Feb 2022 00:00:44 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R931e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=kanie@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0V3vYOvJ_1644307232; Received: from 30.178.81.201(mailfrom:kanie@linux.alibaba.com fp:SMTPD_---0V3vYOvJ_1644307232) by smtp.aliyun-inc.com(127.0.0.1); Tue, 08 Feb 2022 16:00:40 +0800 Message-ID: Date: Tue, 8 Feb 2022 16:00:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: kanie Subject: Re: [PATCH] uio: Replace mutex info_lock with percpu_ref to improve performance To: Greg KH Cc: xiaoguang.wang@linux.alibaba.com, xlpang@linux.alibaba.com, linux-kernel@vger.kernel.org References: <1644304760-11862-1-git-send-email-kanie@linux.alibaba.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/2/8 15:25, Greg KH 写道: > On Tue, Feb 08, 2022 at 03:19:20PM +0800, Guixin Liu wrote: >> This patch includes a modification to repace mutex info_lock with >> percpu_ref, in order to improve uio performance. > How does it improve performance? What benchmark are you using and what > are the results? > > These changes are quite complex, you need to better describe these in > order to be able to have them accepted. > > thanks, > > greg k-h okay, I will supplement the performance-test result later. Guixin Liu