From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: David Yang <mmyangfl@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] clk: hisilicon: Add CRG driver for Hi3798MV100 SoC
Date: Fri, 3 Mar 2023 21:24:45 +0100 [thread overview]
Message-ID: <d529206a-ef17-44cd-1ef5-17badad711f4@linaro.org> (raw)
In-Reply-To: <20230303151417.104321-6-mmyangfl@gmail.com>
On 03/03/2023 16:14, David Yang wrote:
> Add CRG driver for Hi3798MV100 SoC. CRG (Clock and Reset Generator) module
> generates clock and reset signals used by other module blocks on SoC.
>
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---
> .../devicetree/bindings/clock/hisi-crg.txt | 2 +
> drivers/clk/hisilicon/crg-hi3798.c | 193 ++++++++++++++++--
> include/dt-bindings/clock/histb-clock.h | 11 +
No. Don't mix bindings and code.
Run checkpatch - you should get warnings for this (and such you must
fix, not ignore).
Best regards,
Krzysztof
prev parent reply other threads:[~2023-03-03 20:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 15:14 [PATCH 0/5] " David Yang
2023-03-03 15:14 ` [PATCH 1/5] clk: hisilicon: Rename Hi3798CV200 to Hi3798 David Yang
2023-03-03 15:14 ` [PATCH 2/5] clk: hisilicon: Extract common functions David Yang
2023-03-03 15:14 ` [PATCH 3/5] clk: hisilicon: Rename some symbols for Hi3798CV200 David Yang
2023-03-03 20:24 ` Krzysztof Kozlowski
2023-03-03 15:14 ` [PATCH 4/5] clk: hisilicon: Add inner clocks for Hi3798MV100 David Yang
2023-03-03 15:14 ` [PATCH 5/5] clk: hisilicon: Add CRG driver for Hi3798MV100 SoC David Yang
2023-03-03 20:24 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d529206a-ef17-44cd-1ef5-17badad711f4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®