From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 526D51411EB; Tue, 17 Dec 2024 05:43:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734414209; cv=none; b=S5DgZQBgh80hTRhWCgv4p0VfHp7BnMZa/+uUEEjEDDp3iBAMRjt9uj9FgXJ/W3m/fJP7Ywx2BkOKGD2r9QRAXTKFhLVN4Ucuif3mXWxM0S6RgGl6xg4ZELahX88wCrE/uDWsd6u3Okm8G97tG3s5u8AsPFz/tDg4vC/CQnjaQwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734414209; c=relaxed/simple; bh=GF72uodN9Zq6P+OkRp5RAxXAPD/nElPUq/MurGzorkw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RiCqj8sSIU6KYKHm7W+tOc3CPEKeIUx7B32hqegyuI/NU7bVyCIqwsj58ZTP1N8D6pyRZLIHEIe+J+ROfDvomxeGOePMhUmZW7FC7FLvn2zaAnsmNzF1/7eej80t2S0jQH2blj0Xcbj/mu8Kx07Y5VJr0DLHi5JkRgRFHi1qJVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NNifS0Bs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NNifS0Bs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4689C4CED3; Tue, 17 Dec 2024 05:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734414208; bh=GF72uodN9Zq6P+OkRp5RAxXAPD/nElPUq/MurGzorkw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NNifS0BsCOdwg4g3+3+u64apaf1CgLe8nQsN0jcQ76OvxokIVAp9XzSwazDnKdKM9 t4vn+Ek42Ox8bfp4Nl6nQWZkIHCCdIjodesKIRqBjWOlyVb8+mx8yomJgWBzux3If9 jNqsDn78Dp4fNZjWGEVyZdMI4eCY8PgwyR/Fl3evvHmp9kvFw1SE/KVGg6xWbAXYF9 s/6SRTGeydtWG4yPh4e0MASDUJ9/BfaHC0zSmYetU3dnmABzPUbkde1j1k++nqRg/S HHRjbG5HCEjezS5Qr+v+p4jopJ5bPvye7SbqIWzipn3yRCkyah3aKTPOEdHP07MEyj gGG7XWSl52B9w== Message-ID: Date: Tue, 17 Dec 2024 06:43:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 2/8] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface To: yuji2.ishikawa@toshiba.co.jp, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, sakari.ailus@linux.intel.com, hverkuil-cisco@xs4all.nl, nobuhiro1.iwamatsu@toshiba.co.jp Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <20241125092146.1561901-1-yuji2.ishikawa@toshiba.co.jp> <20241125092146.1561901-3-yuji2.ishikawa@toshiba.co.jp> <04a7ebf7-2924-4894-bc53-ba77e2f64fae@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 17/12/2024 01:00, yuji2.ishikawa@toshiba.co.jp wrote: > Hello Krzysztof > > Thank you for your review > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Monday, November 25, 2024 7:08 PM >> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開) >> ; Laurent Pinchart >> ; Mauro Carvalho Chehab >> ; Rob Herring ; Krzysztof Kozlowski >> ; Conor Dooley ; Sakari Ailus >> ; Hans Verkuil ; >> iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ) >> >> Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; >> linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org >> Subject: Re: [PATCH v12 2/8] dt-bindings: media: platform: visconti: Add >> Toshiba Visconti Video Input Interface >> >> On 25/11/2024 10:21, Yuji Ishikawa wrote: >>> Adds the Device Tree binding documentation that allows to describe the >>> Video Input Interface found in Toshiba Visconti SoCs. >>> >>> Signed-off-by: Yuji Ishikawa >>> Reviewed-by: Nobuhiro Iwamatsu >> >> Why this tag stayed and other was removed? What was the reason of tag >> removal? >> > > The stayed tag is due to internal review. Did the internal review really happened? How is it that immediately new version has internal review without any traces? I have doubts this review happened in the context of reviewer's statement of oversight. > The removed tag is due to code's change (split of csi2rx part) after the last review. > If the code is largely changed following the instruction of another reviewer > after obtaining the tags, how should the tags be handled? Drop all reviews and perform reviews on the list. Such internal review appearing afterwards is rather a proof it you are adding just the tags to satisfy your process. I have no way to even verify whether that person performed any reasonable review or maybe just acked your patch. I cannot even verify that that person understands the reviewer's statement of oversight. ... >>> >>> Changelog v11: >>> - no change >>> >>> Changelog v12: >>> - remove property "clock-noncontinuous" as VIIF switches both modes >>> automatically >>> - remove property "link-frequencies" as VIIF does not use the >>> information >> >> Driver does not use or hardware supports only one frequency? >> > > My comment was incorrect. > It should be "Driver does not use the information" Then this is not that helping. Maybe hardware supports only one frequency? Best regards, Krzysztof