From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2923A3D902F for ; Tue, 24 Mar 2026 09:53:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774346001; cv=none; b=t4dPR484NaeoNiFo7DQyaurtZQxZzoJZknBE6ov9PWZuZC/GKc+euLsO/C7A7wbw2FWb6RDEyWs3v2E+Vy9ywaoNv2LUaQIea5Qto0JtcTm4vDi270su3p4SFn8nMOgFZZqHuQnRenkooCZKH11R1nzFfuFXSoLAprRfbGgYw+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774346001; c=relaxed/simple; bh=QW7hI61s5bnzSm5UzyZYkq/3AHhD5Y78qxPuqee2cf4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MJZ03atixgvU5ht9dLUJMQ0LXOAz48CGstQdglBLky603MOxJ05uuAlCe8L8b0rTQn7cq7u+W8hCKFk6FvJ1TPACZggOHLYtI10pZM5DW7EoEEPSqqVybNsfJ0K+yd7LF5tri/tsqe07FxoC9q1yR5KxYt6/PlKiuEp3dICiFqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AzVGb0Tx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=beeB9yGl; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AzVGb0Tx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="beeB9yGl" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62O9dpVA1762212 for ; Tue, 24 Mar 2026 09:53:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iapTK+TrQmONmVoW3zX5R7ZoU2XaR1AWJC4yYw/a8uk=; b=AzVGb0Tx5agp8Z49 C8lmGpKsqFZYFO1aXh/EmJ8ngMIYdQFqimPDL0tHsxM4/9BECYn8sRwmPOnUlofA AMmqnp8nPDMpvWye2VWoWmmbo40hPYkLescIl9dTERx9GWPvHDF/2IPzHyjTUOCV djBA0SiJdlaze1ctLXSMacF5Hy/RQkpbrdB6Zodws6IEO/CaAFYOwz5y0O0OaQaB 2nyz+5vT8HHYLlW53+sKCPH+oIGizHHKcQb+O0chRzdsG+rMatOBGxc9c+tgPMHO gLLWSklZEmhPhMe16M8oD5MfFA7IRyJjrA+OfnzeN27tVEE8bOJ3meIAcJQPfhgq Xaa3uA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d36f0bwgf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 09:53:18 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50b2d15c360so39986871cf.2 for ; Tue, 24 Mar 2026 02:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774345998; x=1774950798; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iapTK+TrQmONmVoW3zX5R7ZoU2XaR1AWJC4yYw/a8uk=; b=beeB9yGlsEU77ByOMj54YB5L/WihdG9WBpJNT1ZobmobD5xfMEPsIJzvj1qTUrIBd9 pT+Wuam+K6ZKq0ukFtF326tLNVFpH62VD46zHVUMVyi+4kp3iR3w04/xK5gFHv8hz08+ /zDAdYOLb16SPRBtgzH6J2rHPIusLouEeg6+LqaPPY/LQUsQ/+o1k+UuBdnExDvTPAEh EWjfMNk9+/XmZgLqb327pFuAfNMk0ZG6lSEhNPLCioJUUt6+noJEWISy3E8RQ+JRPmh1 Se6Vp0dQPmKoM3/tCjqnYbR/sVnsUJlscu9whAu48OczBZWrhYqY1zTkk2y4LlpPd8Sn KXcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774345998; x=1774950798; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iapTK+TrQmONmVoW3zX5R7ZoU2XaR1AWJC4yYw/a8uk=; b=AMGQcI4wFvy3nVcVd6RvcVc9sk3HARnFzhyefrwPyfAX7OltYFMG0Du8KblYrpRU+U vD8nWYxXP48Y0KTIEWPTq8G3Udea/42sYQwwgkoyyfjtuyxsy9VwlAA3stS2f5hZAD1k MmDrSaMyUNwIBn/llkz3uYRUCknkcpiarIbxDl0vCI2NjPK0vAGrt4LYIYFZFdfzSLXU ksbyp6gLy4zs3v38EUH+q4WxA6NQuG3YhYrFlcTWVgPyGarUvDXRPJxNYvjxnfCs9HKo VXN/ScpY9fCJQjQAxEWnd3uaf5qzPAJyYl8GPcCkA+zLxRR/C8eIdFfKIwz3xL9a6tij QBJg== X-Forwarded-Encrypted: i=1; AJvYcCUI18xRUyg7m8t7UG+aTgijqcu+IzqdKPieTQGzdpAKfUsY36Tq1K38Bw+1WiPVD4L/sMYnSHj06/PO7jg=@vger.kernel.org X-Gm-Message-State: AOJu0YxfLRpFA6YWvuXBgqVSqPu5sdAItCnVuAGo8C7L+Cnd4ynXYDJy G8J0OBQVpGeWA8NGJP90Tfa0EOGGRLKwtnGJK+Qb20xs6uMjby4Qhd4Nd7uJIdJ/QZXuRMUIxvm L9HGy1cZTy72aV/kap2r0E/sm91ZLDX3ucAxP7v5mwHr8j2jtV3G9Qu1lhRq0egZBPL0= X-Gm-Gg: ATEYQzxPVkUG+ICwtXJOmHfp63tIh8N7tiQV8rarF4UhKTlP3d5zdUF4MAv5zOwz0oZ hF6NUmxP2k+6XzfV7DWjH6KbLmkUUj06MMjJ9PbiA3ikm9RQJZbFWFWbXEUp0AADZx81QSrGr5o XZGMPEknfl2B007cFDb64R9cyKgeMm+PJox7RlBUaB9oYh7vOGBvXyxMSarMq6rBlY5Pc3gQBoH M+8McTr0R5ekIH5WMNwRQV9dUNJxITfalWpiqXGLVyGnbkFM1G201o4nQO8dkM5SRaZQ711dpD3 diZzjujN/J25q83mNA6lTSp82hILY0THqzRW71Sh4eCbmP/M5u5CGfbIWa00ZGnHd4r28rLwniT GM0XFJJq5SuS1H2/NNP7lrj2wtWMYCHKAYOILE79JoGU9FbhDlzmeiuD4XDtafKtNf26pm49d28 QQArs= X-Received: by 2002:ac8:7d09:0:b0:509:bed:db5 with SMTP id d75a77b69052e-50b37518e31mr180228311cf.7.1774345998291; Tue, 24 Mar 2026 02:53:18 -0700 (PDT) X-Received: by 2002:ac8:7d09:0:b0:509:bed:db5 with SMTP id d75a77b69052e-50b37518e31mr180227951cf.7.1774345997739; Tue, 24 Mar 2026 02:53:17 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66a36996b12sm472185a12.25.2026.03.24.02.53.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 02:53:16 -0700 (PDT) Message-ID: Date: Tue, 24 Mar 2026 10:53:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/16] drm/msm/adreno: Coredump on GPU/GMU init failures To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-5-fc95b8d9c017@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260324-a8xx-gpu-batch2-v1-5-fc95b8d9c017@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=b+q/I9Gx c=1 sm=1 tr=0 ts=69c25f0e cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=3MGHxYdU-HpZmC8ccYkA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: rJsji6UKdm8ulhynDRSOMQqig5yI_L09 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDA3OSBTYWx0ZWRfX1cQ/HdxLpPiO Ge2LhSuvQdkQUrGLeou3j7IsRT2pVEjfGy1LjDPvQedhNkHlCfEYuFFUz/86c4isWsd+iH9dZ7R +0GBpj7z+Ma6PWFOkW8SsZHUgmJ+HYaE5NI7hhpO9sYHwQeiUAKNbCRunvr+NwwLF/pn1PFGuvc t0fHlyRbj5tl8LqpjAcOrSAuWByRSLsKSP5n6iZ2SGfwf5wUgE4BkhE9kjq6qw/Hh3sbMR7YwTn tRRhllsWUI/7MLn07SqMPKwsv9vHK0uHetE/7DiaMzBED7HWo94/Lw3fBJ+InNf9a4LscehJMiz 9omJIgn2iHgJ4cGrUQNRVEJNVKX+ju61vf2+V3SPsav4OEctnIuc0ylk4gVBZLWN4gHOWUuPQr8 WAJ5NDhZ7XHgW6K2rRg5Bvc3XZO84Po9ZHWUhZLfivBNnL+0u+N4HF6JlmeOBP1Vsoc1xNHicJ/ uqmA9Ln2NUsXyIr7jbQ== X-Proofpoint-GUID: rJsji6UKdm8ulhynDRSOMQqig5yI_L09 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_02,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240079 On 3/23/26 9:12 PM, Akhil P Oommen wrote: > Capture coredump on GPU or GMU errors during initialization to help in > debugging the issues. To be consistent with the locks while calling > msm_gpu_crashstate_capture(), call pm_runtime_get(gpu) always with > msm_gpu->lock. > > Signed-off-by: Akhil P Oommen > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 + > drivers/gpu/drm/msm/adreno/adreno_device.c | 7 +++++-- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 ++ > drivers/gpu/drm/msm/msm_gpu.c | 5 +++-- > drivers/gpu/drm/msm/msm_gpu.h | 2 ++ > 5 files changed, 13 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > index 690d3e53e273..6d511dc54e43 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > @@ -1240,6 +1240,7 @@ int a6xx_gmu_resume(struct a6xx_gpu *a6xx_gpu) > /* On failure, shut down the GMU to leave it in a good state */ > if (ret) { > disable_irq(gmu->gmu_irq); > + msm_gpu_crashstate_capture(gpu, NULL, NULL, NULL, NULL); > a6xx_rpmh_stop(gmu); > pm_runtime_put(gmu->gxpd); > pm_runtime_put(gmu->dev); > diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c > index 4edfe80c5be7..85b3e1f0e4fa 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_device.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c > @@ -105,6 +105,7 @@ struct msm_gpu *adreno_load_gpu(struct drm_device *dev) > */ > pm_runtime_enable(&pdev->dev); > > + mutex_lock(&gpu->lock); guared(mutex)(&gpu->lock) will let you drop the subsequent jump-to-unlock Konrad