From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792533299; b=tpFl4c9aCGxSFqaNlGfZ5S7FTJinYWwhjRToPV/1thDeQ1tgA1hd6eJxsPjpfZlWRUDd 4YjyZhOMPlnsdub64ARDjJdpVgS4NGrLvA0/nGH+s3JzHC5qKeRMNJ076wAePZTmel259 RJfTqjQgrNZFfDIVSaRgpCus/UnPZ5vxRlZRTk5MHZpksaUiGPOvMJMPRY6uERP+j2Uc2 6GV4ZZQ1NpNflWHX5Pnv1s46V8CDsTwzgr32w3QoYDigkIgNG1tZaijZOdYOLG2Q+dmo5 K/dAT2tQZLxqx64bVJojUGaEQzFNnIaTgobaw5PEjM1oBdXcD2Bdx2G3mi+XreLY6uw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792533299; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received: X-Received:Received:Message-ID:Subject:From:To:Cc:Date:In-Reply-To: References:Content-Type:Content-Transfer-Encoding:User-Agent: MIME-Version; bh=3OTPHtHhVUMIT+NWFEN5/mmRIvv8BU1Kwwt6/o60whk=; b=m/QmNFgyamIut0Xheoj7Y+E7p0EKuRVyFHfhrtPBXtDHXe0/4a5hYjjFNPew/fZzhnh4 hl8gXy5ahZEeVgyUvfZWTTM+1IjG063nE9MbX6yucSNZUCvP+R/vS81Ebsv56ZxZKZZk0 cIR6W0L1QD6HQvvcvY37ELT1jv2Ngf2kfQaq+7kyaDzP5aelwwUma9c5nfuyvtfglSCmw H49cMAZgdBph2JFEmzA/njkonDaF2DNvm3DVdVBlnZTtOiECONp78P/TGubtErktVJS6K RsUGiphiSDwgaGvAZzIGHPz5pm1AFdzG6aN3PuBsOPefZbNsal7mYRC1ZZKTv9bualA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aKzYX7M9; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=Gcjgl1A5; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C26CB606A319 for ; Tue, 20 Oct 2026 21:54:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C26CB606A319 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aKzYX7M9; dkim=pass (2048-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=Gcjgl1A5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792533297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3OTPHtHhVUMIT+NWFEN5/mmRIvv8BU1Kwwt6/o60whk=; b=aKzYX7M99L0yFrToQqARF3RK3BNFcHrCVYZ15spLTUPClw1k6W/qnV87TYqW+qLSGYYjAZ Pb/SRjoOfV+QSLaTvNgo74xCvaxjUBWHYZDW+Ty+Fpd43s6NQBKOz1H1wtTemW5EK3az3A pkK2bo/fOFm3t54VOfeYPYYK1CCKEKo= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-rysweI09PXmGdalZYQlAhA-1; Tue, 20 Oct 2026 17:54:56 -0400 X-MC-Unique: rysweI09PXmGdalZYQlAhA-1 X-Mimecast-MFC-AGG-ID: rysweI09PXmGdalZYQlAhA_1792533295 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-93cb93c874bso224892085a.0 for ; Tue, 20 Oct 2026 14:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1792533295; x=1793138095; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=3OTPHtHhVUMIT+NWFEN5/mmRIvv8BU1Kwwt6/o60whk=; b=Gcjgl1A55dgDc+s92wAaserrFNuCgm3EHQoS9i2gzuJuJaficop87K9qagGWa5AlVc y6iLiIgNRUTRjvBYq0yzDFbMMm2RpUTjAUBDyMvl/8FHbjIkkkmoyUBKqOm/ekSv/6V7 Ad/QSpdUjStd+TgVnTJVSnCfyqeM7qfHxyqbFuKpHZzn1G69CHa9CqTNcNsNdBVY2e6T FCEjPzY4266aMpg3seb6gU878ATICn7U/ONDCTJj4MSFGaPstTjj/vdaY5OtsxbozTRf K50SbJ3mV+eU2BfMOlFcvqQPqwAZE5ZGwrf+haHFMSNueNpG955kLiEr+a4gZ+KN3haX SafQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792533295; x=1793138095; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3OTPHtHhVUMIT+NWFEN5/mmRIvv8BU1Kwwt6/o60whk=; b=EB2x10aV8HaU6HYEeT5InPPg0msQu0W+xkUfLopQeugK/H4htSgAlqHOuqLINz1/Kd Vj4ySy56xxuDxR4USbKd3EIvvidSZpC+CvdRepQR7/RDiKUKDHKeXZvXgGoJWtQkU4hc Cx0GZYfH9SFWufAH97Ku4ZUH8ZlMWA2O00vxeacaZ7sS4yICQh7Kvbrfox3MGiFSSdIy XcR/RAUG36sxdT+NtGfo65BEgNKlSS7wuK6t3d42EzOUMfcFUgFQvgdzn9rzH9ZjWyk0 ifHraZZ8CPS3zPIVCX7t5e7zmgkJQUh0vwjDmTbLw0hLEqVqhgqivuq4Jf02KSLHf1cQ z2yg== X-Forwarded-Encrypted: i=1; AKwUvBzDWWrQQZ6wGVt4lIbRO9Fge+2xtXLEBA6YpMDmarieZWVJlapR8mA2yIzonSOKHrjRrcZ9vXSFQaJyRgM=@vger.kernel.org X-Gm-Message-State: AFq9FYIHtDO00s+fz4kK/ZGpZHuAp2cniHTYxlAfFCM12UgKQnSAGQP5 P6j6Ztnjjd4wIolDL7aGfl42fDAvHcRU9Wv0TQh73JUi2umoUR/rFVJ65Kf0cPfdDGjPwsoPcnH mG13rXqBItDirHHgald6TgYeRnfCWxaUSvXCBvTaZH9JmDv1fRvy/DamLh/psM8kKiIWBxclpQg == X-Gm-Gg: AYBFou144zOk3X0Hwjl9G/cIM2ewXT7iGAnPVmAlpwtsginfwkBjXc2WMooH1lc+i1Z K8UhZmoxaAN1AymRMTjV0ewkhlxjYHgA+03obmRsPC34X2yhYAwnL2Ubp0qX3L0KEm2fdMW8JvP VVbwwZhHOjYS1ThHfkKrDuo9YMydWwhcmY/1snzsBkYltun4joK5ISbKyfDKuSFSUrF0vpZKXZT cWHLAfrkTYKpcUsgNUkWhx1BlX6XX51YJ/GsN5DHR+E8TSmszbSHkD7VFUGnoG+hhXOvn4uVlI8 7o4y0/vTXozDiom/x5mXNMBBaBJPfL6X79Uwy+2FFqcZn2opCbgR/K/hHaap61mY6WtaulODEdM H4FY1Ft1JaTGMcLNvObBKluq5aloBKnjFX/r3 X-Received: by 2002:a05:620a:45aa:b0:93e:c173:f694 with SMTP id af79cd13be357-93f57fbb83dmr96058785a.40.1792533295399; Tue, 20 Oct 2026 14:54:55 -0700 (PDT) X-Received: by 2002:a05:620a:45aa:b0:93e:c173:f694 with SMTP id af79cd13be357-93f57fbb83dmr96056085a.40.1792533294955; Tue, 20 Oct 2026 14:54:54 -0700 (PDT) Received: from loberman-thinkpadp16gen3.rmtusma.csb ([2600:6c65:2440:d8c:aa2b:ddff:fe88:da74]) by smtp.gmail.com with ESMTPSA id af79cd13be357-93f56df222dsm87495785a.26.2026.10.20.14.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2026 14:54:54 -0700 (PDT) Message-ID: Subject: Re: [PATCH] scsi: mpt3sas: Register devices during SANITIZE From: Laurence Oberman To: vince@palmit.com.au, linux-scsi@vger.kernel.org Cc: sathya.prakash@broadcom.com, sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com, ranjan.kumar@broadcom.com, James.Bottomley@HansenPartnership.com, mkp@kernel.org, MPT-FusionLinux.pdl@broadcom.com, linux-kernel@vger.kernel.org Date: Tue, 20 Oct 2026 17:54:53 -0400 In-Reply-To: <20261020210856.42835-1-vince@palmit.com.au> References: <20261020210856.42835-1-vince@palmit.com.au> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-2.fc44) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 On Wed, 2026-10-21 at 07:08 +1000, vince@palmit.com.au wrote: > A SAS disk being sanitized responds to TEST UNIT READY with NOT > READY, ASC 0x04, ASCQ 0x1b. mpt3sas discovery maps this sense to > DEVICE_START_UNIT and issues START UNIT repeatedly. The drive stays > NOT READY until the sanitize operation completes, causing discovery > to exhaust its retry budget and decline SCSI device registration. >=20 > Allow registration only for the SANITIZE IN PROGRESS sense, so sd/sg > can expose the target while retaining its actual NOT READY state. > All other sense dispositions are unchanged. >=20 > On an LSI SAS3008 with an HGST HUH728080AL4200, unpatched Linux > 7.2.11 retried discovery 145 times without registering the device. > Linux 6.18.55 registered the same sanitizing drive. With the > equivalent 7.2.11 fix the disk registered as /dev/sda (0 B) and > /dev/sg0 while TEST UNIT READY still reported 02/04/1b and 47.32% > SANITIZE progress. Another SAS drive continued to enumerate. >=20 > This updated variant uses the named 0x041b sense constant introduced > in newer kernels. It passed static review on the current SCSI > for-next branch but has not been independently boot-tested there. >=20 > Fixes: aee682fad6cd ("scsi: mpt3sas: Improve device discovery and > readiness handling for slow devices") > Assisted-by: LLM > Signed-off-by: Vincent YUE > --- > =C2=A0drivers/scsi/mpt3sas/mpt3sas_scsih.c | 4 +++- > =C2=A01 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c > b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > index 085d4672d..a77bbc3d2 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > @@ -7700,7 +7700,9 @@ _scsih_determine_disposition(struct > MPT3SAS_ADAPTER *ioc, > =C2=A0 u16 scode =3D > scsi_sense_code(sense_info.asc, > =C2=A0 =C2=A0=C2=A0=C2=A0 > sense_info.ascq); > =C2=A0 > - if (scode =3D=3D > + if (scode =3D=3D > LU_NOT_READY_SANITIZE_IN_PROGRESS) > + rc =3D DEVICE_READY; > + else if (scode =3D=3D > =C2=A0 =C2=A0=C2=A0=C2=A0 > LU_NOT_READY_MANUAL_INTERVENTION_REQUIRED || > =C2=A0 =C2=A0=C2=A0=C2=A0 scode =3D=3D > =C2=A0 =C2=A0=C2=A0=C2=A0 > LU_NOT_ACCESSIBLE_TARGET_PORT_IN_STANDBY_STATE || > -- > 2.56.0 >=20 >=20 Hello The patch looks good. I am curious, though, how the drive got into the sanitize state before it was registered. Was SANITIZE issued while the drive was registered under 6.18 (or via mpt3sas passthrough), followed by a reboot into 7.2.11? Or did the drive come up already sanitizing, for example after a power cycle part way through an operation started elsewhere? Since a sanitize persists across power-on, the second case would mean a drive in this state is simply invisible on the unpatched kernel, which strengthens the case for the fix. Reviewed-by: Laurence Oberman loberman@redhat.com