From: Doug Ledford <dledford@redhat.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Christian Benvenuti <benve@cisco.com>,
Dave Goodell <dgoodell@cisco.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] IB/usnic: Remove unused DMA attributes
Date: Mon, 6 Jun 2016 19:28:14 -0400 [thread overview]
Message-ID: <d533cca2-94e1-182a-4ea7-06e02f68104b@redhat.com> (raw)
In-Reply-To: <1464860701-11376-1-git-send-email-k.kozlowski@samsung.com>
[-- Attachment #1.1: Type: text/plain, Size: 1080 bytes --]
On 6/2/2016 5:45 AM, Krzysztof Kozlowski wrote:
> The DMA attributes are set but never used.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/infiniband/hw/usnic/usnic_uiom.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/infiniband/hw/usnic/usnic_uiom.c b/drivers/infiniband/hw/usnic/usnic_uiom.c
> index 7209fbc03ccb..a0b6ebee4d8a 100644
> --- a/drivers/infiniband/hw/usnic/usnic_uiom.c
> +++ b/drivers/infiniband/hw/usnic/usnic_uiom.c
> @@ -36,7 +36,6 @@
> #include <linux/dma-mapping.h>
> #include <linux/sched.h>
> #include <linux/hugetlb.h>
> -#include <linux/dma-attrs.h>
> #include <linux/iommu.h>
> #include <linux/workqueue.h>
> #include <linux/list.h>
> @@ -112,10 +111,6 @@ static int usnic_uiom_get_pages(unsigned long addr, size_t size, int writable,
> int i;
> int flags;
> dma_addr_t pa;
> - DEFINE_DMA_ATTRS(attrs);
> -
> - if (dmasync)
> - dma_set_attr(DMA_ATTR_WRITE_BARRIER, &attrs);
>
> if (!can_do_mlock())
> return -EPERM;
>
Thanks, applied.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
prev parent reply other threads:[~2016-06-06 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 9:45 Krzysztof Kozlowski
2016-06-06 23:28 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d533cca2-94e1-182a-4ea7-06e02f68104b@redhat.com \
--to=dledford@redhat.com \
--cc=b.zolnierkie@samsung.com \
--cc=benve@cisco.com \
--cc=dgoodell@cisco.com \
--cc=hal.rosenstock@gmail.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®