From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757528AbdLQU1e (ORCPT ); Sun, 17 Dec 2017 15:27:34 -0500 Received: from mout.web.de ([212.227.15.4]:50580 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757336AbdLQU1d (ORCPT ); Sun, 17 Dec 2017 15:27:33 -0500 To: linux-pm@vger.kernel.org, Sebastian Reichel Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] bq24735-charger: Delete an error message for a failed memory allocation in two functions Message-ID: Date: Sun, 17 Dec 2017 21:27:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:MgkuR/fDKgcM9KW6YiLcGuqVNHnfRtvIgpY0+MgqI6DgghiLCKr QCFOlXwM6ZlJfG19CfUeofc0+4Oil0IU7BXNgXSrQhbCMjs3PMsw1mzx0X/KdypIIaAFyx5 14TjqboXuUJlpS++C7wmqmZyxtAzsgNVo5eAoEUkLkvuAxTjP926c6ueNViXoE1xCr9HHsI cX0pbu/buaWZGakWRdq2Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:uvNkzYEz/6o=:V7Tm+Mlk+wZ8kNhVa9bz2L 8moQmF/cy8im94IT+5qPL/StUwG7UNfQTcknNS1Z0h+RAlwnfszvZ46o4dWKih+p4EXp8EKnW N2TYegj1vZPa6+4hrF6isFIANBeUsBx0WnXxf286DFLzCMdjXqXVts5I3RZtapCWSC/oyaXq8 25sm+DyZsPzJl4VZ7RwInpsXX4EWODpUEQN/Rv5X9A6bK40HUodM9kol51WFo2VkwBjvcztS8 nDnDJP2JpKy+EbzO0Qby6vhpJjJ33i+bwpNvytgU4cj76iqXSNCAJQOrmFw/o2cPrHx1NlIX4 Cas9YOHqegwzFVvbdh8Yoh++QMsvdFkBn1rNhNXZPkARWLMHUXzYoCJGydtIHKF0iJ5ilKG+w X3aStRTdHrQNpuRnWjsarG8Sx0VbBZBE69dPI8CdtWkZd8LfrHoIWfzCeeJxQWoAoYNtumi+5 9I2ta7VAXTKTyAETI+5MSHbSX/7r4bs7nRDkvXc0pdj9p9ih1pgaNtfsRNpzquzC3B7gCsc7k haA4yh8YmxYSOslJsI9vPuQuc1FFvN37iiJG5jEmMSo887ZKXvQw5DkSwR41OdtBmRDVSTwei 2fyWSUUiMpJP0JudduSelsn85A/UKYT+zEmjAa7JA2+MtKb+Id5bsJ4kD1Z27ejQB5WdGERqc x9mwOM5h5qbC3N02/arJEOgYhM2DIFrZJfxRaIZVDDMdCWr4fXdwFAzXiM/mbJsUz3TcBKFP+ Kz7tDVSXdz5f7ZeAy3ZgVVHJtG9Z4VVizW2JRbvIiWClxrec+HhcM4VjpeeSzFikfDqI1dXBk 135J1On6y/rh7j2xbK07B5brdCwZKiisfA9BDNIo8u58unCy3g= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 17 Dec 2017 21:23:23 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/power/supply/bq24735-charger.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/power/supply/bq24735-charger.c b/drivers/power/supply/bq24735-charger.c index 6931e1d826f5..c9fd9275dfae 100644 --- a/drivers/power/supply/bq24735-charger.c +++ b/drivers/power/supply/bq24735-charger.c @@ -326,11 +326,8 @@ static struct bq24735_platform *bq24735_parse_dt_data(struct i2c_client *client) int ret; pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL); - if (!pdata) { - dev_err(&client->dev, - "Memory alloc for bq24735 pdata failed\n"); + if (!pdata) return NULL; - } ret = of_property_read_u32(np, "ti,charge-current", &val); if (!ret) @@ -379,10 +376,8 @@ static int bq24735_charger_probe(struct i2c_client *client, name = devm_kasprintf(&client->dev, GFP_KERNEL, "bq24735@%s", dev_name(&client->dev)); - if (!name) { - dev_err(&client->dev, "Failed to alloc device name\n"); + if (!name) return -ENOMEM; - } } charger->client = client; -- 2.15.1