From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65040C5519F for ; Mon, 30 Nov 2020 07:56:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E98620709 for ; Mon, 30 Nov 2020 07:56:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UDyYpxcP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727162AbgK3H4K (ORCPT ); Mon, 30 Nov 2020 02:56:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726929AbgK3H4J (ORCPT ); Mon, 30 Nov 2020 02:56:09 -0500 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86112C0613D2 for ; Sun, 29 Nov 2020 23:55:29 -0800 (PST) Received: by mail-ej1-x643.google.com with SMTP id jx16so19249650ejb.10 for ; Sun, 29 Nov 2020 23:55:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lLjwMaRlmFk8cdjb61byqEUPHvd5mHzz+PPVHsNni1U=; b=UDyYpxcPlLMlL1aNJW1x9AbN37aqd+AIG23FKB/f+lnfQ0qFsXhz0n5R899QDDTucz eqvrGTDaiYSV4tw8hpzB/zmYFgfnqjn2I6NdydMxXrS2OsdAKAHzq5Gr5TOORlBV90zC T9Zkn07E+KbPQ0Jj6TLrIOqsCYuBxr1ZbCZX7hg8ofhCmMDpGupMr/fgKHtPvAat56Xq hpX86eryIGBvmVnPELmXSL2QS4yDMKcQrYtK0IfgB4tTYPnGuwbGxNusDuqRRYoIKqcJ gr03oLSxJLPuurAsGBO72Tzk/SUn7PyYz9e2HrSRLXClT+RtjGAlITc88ixzV3iBd4n0 WHfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lLjwMaRlmFk8cdjb61byqEUPHvd5mHzz+PPVHsNni1U=; b=HNU6u4nmJB781nemvmjfkMNhSAQ3/XMMtE0RVc0ss1Sp+2GKcenjppItYSTXSjD8EU Gnm4Nq8d0ehpGsoIvIIe1s/o8crIG/2vUh+sX7dOWKdONHV0v9+3Eqyj1zKLj1fhNjnA RJbmpQX+tWzzBYwQE+nTa2JiQoCkpE0tTckeHz5dF+eFH1cx1ff3iSnKt4tHYWcNjTnV HDHnrdqgeQG5nRYFF/EndNr+EXRqNexWWXqKne829cmGKz8aVYDv01phyZ8nj10DmBLo v2D0X6WC/413DS2WHUVcKgVThHrm1xi002lqGOh9RgOXUQukbL5oPy3eNPb9ZXOBcxhH 66AQ== X-Gm-Message-State: AOAM5326WPkGZRbNx6ZYuSEw/F9kYadnBZSVoAoKI+BmIDveTJ11o+Hv ssqdJqboU8jlpE82O8vp/OMXPA== X-Google-Smtp-Source: ABdhPJzcj32N0IZjwASJ4Qy9YUq174cNRzne/2mX0AbEhr+sbor3LD60k6ZMpPOQFunFRPnEyjnrNw== X-Received: by 2002:a17:906:af83:: with SMTP id mj3mr12580359ejb.243.1606722928131; Sun, 29 Nov 2020 23:55:28 -0800 (PST) Received: from [192.168.0.3] (hst-221-70.medicom.bg. [84.238.221.70]) by smtp.googlemail.com with ESMTPSA id b5sm549899edw.69.2020.11.29.23.55.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Nov 2020 23:55:27 -0800 (PST) Subject: Re: [PATCH v2 0/8] Venus stateful encoder compliance To: Fritz Koenig Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Vikash Garodia , Alexandre Courbot References: <20201111143755.24541-1-stanimir.varbanov@linaro.org> From: Stanimir Varbanov Message-ID: Date: Mon, 30 Nov 2020 09:55:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fritz, On 11/29/20 9:17 PM, Fritz Koenig wrote: > Since this patchset adds support for V4L2_ENC_CMD_STOP and > VENUS_ENC_STATE_ENCODING it should also add support for > VIDIOC_TRY_ENCODER_CMD so that those commands are discoverable. I've 6/8 is adding it: + .vidioc_try_encoder_cmd = v4l2_m2m_ioctl_try_encoder_cmd, > made an attempt at that here: > https://www.spinics.net/lists/linux-media/msg182319.html > > On Wed, Nov 11, 2020 at 6:38 AM Stanimir Varbanov > wrote: >> >> Hello, >> >> Here is v2 of the subject patchset. >> >> The patchset starts with few small preparation and fix patches, 1/8 to 5/8. >> 6/8 is redesigned Dikshita's patch and 7/8 add Reset encoder state handling. >> The last 8/8 just delete not needed helper function. >> >> The major changes are: >> * An attempt to reuse m2m helpers for drain and reset state in 6/8 and 7/8. >> * Use null encoder buffer to signal end-of-stream in 6/8. >> >> Comments are welcome! >> >> regards, >> Stan >> >> Dikshita Agarwal (1): >> venus: venc: add handling for VIDIOC_ENCODER_CMD >> >> Stanimir Varbanov (7): >> venus: hfi: Use correct state in unload resources >> venus: helpers: Add a new helper for buffer processing >> venus: hfi_cmds: Allow null buffer address on encoder input >> venus: helpers: Calculate properly compressed buffer size >> venus: pm_helpers: Check instance state when calculate instance >> frequency >> venus: venc: Handle reset encoder state >> venus: helpers: Delete unused stop streaming helper >> >> drivers/media/platform/qcom/venus/helpers.c | 65 ++--- >> drivers/media/platform/qcom/venus/helpers.h | 2 +- >> drivers/media/platform/qcom/venus/hfi.c | 2 +- >> drivers/media/platform/qcom/venus/hfi.h | 1 - >> drivers/media/platform/qcom/venus/hfi_cmds.c | 2 +- >> .../media/platform/qcom/venus/pm_helpers.c | 3 + >> drivers/media/platform/qcom/venus/venc.c | 232 +++++++++++++++--- >> 7 files changed, 226 insertions(+), 81 deletions(-) >> >> -- >> 2.17.1 >> -- regards, Stan