From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EEC448A2A5 for ; Tue, 14 Jul 2026 18:59:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784055575; cv=none; b=RbmF4vFiMcCP501OaIFSVFgkv+81tmBwX6SG29xajLlfXog/Em+Hwj+idXtAWMmYmQksbcFTxd19j6ZFbaMV6etz4nXnLwnpMXEpF7lWXQFiFo2ddzrrsCEopuejZfOE2xKBKcGqqc7yrKx6gZSZboipFPaGoGFq5/hDlVVBqvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784055575; c=relaxed/simple; bh=IXq0FAAc78TyoGp8uuzsKGSHedyyXLGyo6ddmHn1t0E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YZmzOsM+Zi2n/jFAMiqKETEzbLNFsX+KirqHNr0WkfNsLw8Rrx9lRF3iPRMop2wOt9ioEFMXLjKpdcBT7B+YLwKTjUlsc2r/8/7T9OkD4aiG9FM5KIz4R9c7ysbI9FVml9lci2G0pxgPRv+J8Ee+7YV+kJ8xN582hbW9+4aAEU4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu; spf=fail smtp.mailfrom=g.harvard.edu; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b=Ow3NhSXa; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=g.harvard.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b="Ow3NhSXa" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-92e6391b114so104706685a.3 for ; Tue, 14 Jul 2026 11:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rowland.harvard.edu; s=google; t=1784055572; x=1784660372; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wxrPhgZ0OOHJaTMRlc00Cx8sHx2fcggJ803FMg34cxY=; b=Ow3NhSXajijAQQObnCRu7MM0BDy5J8W0miJUaXmxeYEdAf3SoxXG94/iMv43IV6D7+ rU2+hngDfkfzp1phMfGenZTi/0aGZT5WyRBbuy6s2fJE17fQ4WcAcmH+Ue3Ovf7Ve4Rq B3Kc1rIR7jgc/ANTbZ2KsW68IqL5y7jvUDznWSRsHEhq6xI1zc5L+LrdVlCzgpMSQ03x OgeyqlCpmeOg2uuyji+Wb70t0jkWTiZRP24ptFy8WmQxciHWzSCIl3qaXuA2PvYdYWFS PJ6C229PxH2Qs6U1mQvhUwCaFQUUJpGi+75AgD3YNUgaZdxj4wmly1XCsWp7fzNmH3zf PDtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784055572; x=1784660372; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wxrPhgZ0OOHJaTMRlc00Cx8sHx2fcggJ803FMg34cxY=; b=F83ol1G9wARIDxesEIMvCxrnS2ka88GjS7esesDXaikQ9oTzORjuYjpXRKkscLRmaE i7v4qtdZQXEI6s4EYWeITRDqk9g+AYoXMJ5BmALA2TDUGT60+F+JPfxW6wFz9C7dOHHw TmXdb4QJ6GHrlb/MyUH1lG5+kwaYWivDhV2T+uLL84w44x1GpSnaA5QGw3IZRHRXYNYI GBCwH5h627BB6SfQLmuMoYtemq2gUhha9A1hMtsdGzmGPykACh9rjKkKw+a7d59OdjsB 6USTFxmLurHYYwXplaMU0F5Mk/1VeqMXUCJzh/2iFlk5v0P5zz0OP/HI9MuxN6rjui34 fllw== X-Forwarded-Encrypted: i=1; AHgh+Ro5BPpeetOSvfAgciQbEYEhev/igGZYkib00s61ljfYEOW4cUqvMHl3wdmaYQJBjk9TsrTltWStWvkebkY=@vger.kernel.org X-Gm-Message-State: AOJu0YwgnUX9S8PTWn/tTDyU/eT1R8q8v8h0TTodSZ2KYQpqLi7wbrjI 42+b9B8caga/vewFzwkFAFywrELPG0lpmVyJSLlFmu6FcxO9DvkZ0nJ69iwQeslrJQ== X-Gm-Gg: AfdE7clFlKE97qczAgJjYcE5QqEJemk+f8AmZQkgntf4uvGjjo9jE2SKpFOqmHnUbTN Ln1JYz9XBzn3Nvyps5WU+1T/ZngPKJ8Q8SdxHyLFxhfzpClXXpNLaawlh40Za32Xc4JiwvsytOl Je/6Q3PPffAIJiRSK91SrlvaKqoDBo1goFhGuEcRu153GNuUDRYk+SHEGvTxlyaUF4qASQxbJi1 YKbiHNV73s6MdKzyB5jplbQufz5zR/AqvbOEk4dyNYZom/rKA9POfsNGK0t7Kx+RGjv7UaJ0RrC N4UbiRmEHsteP4GPhakSL6p+inVxt1PIkDiteY2yX438bF+jgiDjnleuAkw9kDAmYe8AZp5fhr9 UIi0Urx7g6Mi604ofrJoAorbjXEdLUGCwYOa6dUMW15sg6EJbmvubUEjP+4lONwJ4sHB3i9vYwV X/RrABzxhc1g2F+ZVIB2cPjPkC X-Received: by 2002:a05:620a:2713:b0:92e:c28c:9dff with SMTP id af79cd13be357-92ef2aebfebmr1620216185a.6.1784055572021; Tue, 14 Jul 2026 11:59:32 -0700 (PDT) Received: from rowland.harvard.edu ([2601:19b:d01:d210::883a]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92ee5b8eebbsm1553938085a.17.2026.07.14.11.59.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 11:59:31 -0700 (PDT) Date: Tue, 14 Jul 2026 14:59:29 -0400 From: Alan Stern To: Oliver Neukum Cc: Griffin Kroah-Hartman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: core: Strengthen error handling in hub_hub_status() Message-ID: References: <20260714-usb_core_patches_2-v1-1-4229a368a633@kroah.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jul 14, 2026 at 07:48:14PM +0200, Oliver Neukum wrote: > On 14.07.26 18:32, Alan Stern wrote: > > > > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c > > > index 5262e11c12cd..0d2166b8923a 100644 > > > --- a/drivers/usb/core/hub.c > > > +++ b/drivers/usb/core/hub.c > > > @@ -991,10 +991,12 @@ static int hub_hub_status(struct usb_hub *hub, > > > mutex_lock(&hub->status_mutex); > > > ret = get_hub_status(hub->hdev, &hub->status->hub); > > > - if (ret < 0) { > > > + if (ret < sizeof(hub->status->hub)) { > > > if (ret != -ENODEV) > > > dev_err(hub->intfdev, > > > "%s failed (err = %d)\n", __func__, ret); > > > + if (ret >= 0) > > > + ret = -EIO; > > > > It would be better to put these two lines above the preceding test. > > That way it won't print confusing things like "hub_hub_status failed > > (err = 2)". > I am afraid I have to disagree. We would in effect say that get_hub_status() > has returned -EIO. That is simply not true. On the contrary: The message would say that hub_hub_status is returning -EIO, which _is_ true. Of course, the error message could instead be changed in the way you suggest: dev_err(hub->intfev, "get_hub_status failed (%d)\n", ret); Either my change or yours would be okay with me, but I don't like what the patch does. (Another question is whether this message deserves to be dev_err(). There isn't anything the user can do about it when it happens, so maybe it should be dev_dbg() instead.) Alan Stern