From: Randy Dunlap <rdunlap@infradead.org>
To: Nicolas Schier <nicolas@fjasle.eu>
Cc: linux-kernel@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kbuild@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] scripts/config: allow "O=config-dir" option
Date: Tue, 2 Nov 2021 15:38:29 -0700 [thread overview]
Message-ID: <d547ccdd-6d87-504f-ebc3-0802341fe55c@infradead.org> (raw)
In-Reply-To: <YYFbYac/iU21vYiu@fjasle.eu>
On 11/2/21 8:38 AM, Nicolas Schier wrote:
> On Sat, Oct 30, 2021 at 11:33:22PM -0700, Randy Dunlap wrote:
>> Support "O=config-dir" as the location of the .config file
>> like (some) other kernel build (make) tools do.
>>
>> Someone asked for this "feature" a few months ago but I don't
>> recall who it was.
>>
>> Also check for the existence of the config-dir/config-file
>> and report if there is no such file instead of letting grep
>> report that there is no such file.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Masahiro Yamada <masahiroy@kernel.org>
>> Cc: Nick Desaulniers <ndesaulniers@google.com>
>> Cc: linux-kbuild@vger.kernel.org
>> Cc: Andi Kleen <ak@linux.intel.com>
>> ---
>> scripts/config | 44 +++++++++++++++++++++++++++++++++++++++-----
>> 1 file changed, 39 insertions(+), 5 deletions(-)
>>
> I do like that feature!
>
> With quotes round $FN:
> Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Thanks, I'll do those changes and resend it.
--
~Randy
prev parent reply other threads:[~2021-11-02 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-31 6:33 Randy Dunlap
2021-11-02 15:38 ` Nicolas Schier
2021-11-02 22:38 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d547ccdd-6d87-504f-ebc3-0802341fe55c@infradead.org \
--to=rdunlap@infradead.org \
--cc=ak@linux.intel.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®