From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50AA03BE173 for ; Fri, 27 Mar 2026 06:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774593679; cv=none; b=Hqjiwv3P9sdmPWEenVAIchBfnkwNIOIOZHrchkRhx1/lFHswL9bn660F43WsLDt/k71Bk5VOCe+YbKQoY4CK3em5hozFEr7IV4IxvlflJewLyW2CVNdHgl0lhM+4zoSnJ6c5AmzpJAwaonU3KyIS6gMrQB9L8q1JMAg31JITOmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774593679; c=relaxed/simple; bh=4UrGci0dPrujH6qxGs2ymX7tGI2uhwgO969dLATDVy8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=duoT2pDDKVpbOWfy+ZV2eR4QLxpaj6TM8g1V3rxIpCaX7zNl4YomXVdww7UlVvUFkZ3Wrb7KQwzbzUbwkpAOBJd4jDe9nOsVlrRIgFw6moyKPmus3XZSKctcV1V5jIitiYMWHFME0uz25LONXyKX/BqbG9ssEGb3xMfMGrxjYfY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UH0M5XGV; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UH0M5XGV" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-12a693cdf29so2385778c88.0 for ; Thu, 26 Mar 2026 23:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774593670; x=1775198470; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=nduYtSKfpopTmuw3oAsPQi4fyD7F6EEZi1ICkUx6Cyc=; b=UH0M5XGVmEnvCP5VstfwbKY38VqkuRadq92WE1olijKEypoUZRL6AwAVQUmx9PMG5C H9a8yp17os0pgEFxK/u7zR/vW+anN2W75Axi0cUxmeFgHsXPEMTv26JBGr8JbwIARgxB GscAzY+7E3tYpUGm9V4a/mEQLzJRdtEOZJI78oqfSW/Urv3QhZ7ddGJVxHLzHX9q5pTE qb653d73gxjuyyx0qiLtVRKPIZKhtas/o9m394RjNP9YsTL/IiwMmsNKJGka7YoYsnBf fyohwFzkgB6EiYPdF1T6LLFS54I+ERyFf7JqlcmHjd6vj/2JET4cmP+NM7lLJXqPDmBk we7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774593670; x=1775198470; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nduYtSKfpopTmuw3oAsPQi4fyD7F6EEZi1ICkUx6Cyc=; b=rvL9a20q/Lxt+C4SprNBgxyxs9jztDxzH20UeEIvLQledkSq1jqwKCVf2PnTfgDVNb iOr4PTcQwfjvUmcltZZh/mhHJeaAdeD/TxiGjvVpatAi4jllJRyGio2kKUHtGYBDzd7Q 8ZsWcK2GljqZyfAnO8HWtU5+91VwKl3bv4YpFCK63SDxRTmyPuwEWQNnNCOSX7z/2mow kvnpYRZ58n80Ckzv/JDMRGyPpjw8BgY3By75lfCWLaqszBmQ6m2FKtracowHmD6SOynh HzgQw35lNmPmsDb62iKzY+y5ftDdMiGZiPLvJE3b4VlY5lMgQ8DSStwMx9FJPXSeLGg1 1pLA== X-Forwarded-Encrypted: i=1; AJvYcCVobKxo/F/MUbnzuwezJQbt44Guk+QUPvtS6Mt1IfKS3muB45C99EPmPZKWD+V98NLSF4GjHDuX5XGtgQM=@vger.kernel.org X-Gm-Message-State: AOJu0Yym5bVF4XptzrVo7lN1L56tCTgJ+LQ1wi9rvSr57Vso/tTziKOf /Ou7jK+5X3zpHVYpip7tzFwpChP8Xcsq7FVVyNllO5W179Z0ywYEIHOj X-Gm-Gg: ATEYQzzYCAMKd5a0yYnmpNuyG0O5k1Kss+E4qQKjwQq6vA6oxorWv23Qa0YRy3jHyEg wxZjzUQ80k1eLVYDAkqvEd66KYTEaysFBhdD6eFdku/5abEji14Y/kZJg2QMh0daf5YSeT+5Fr6 lWbQI5qZgT18stA26zD044tqo8JUj1DBfNNu7wCjIR8wOgjQf0Bbw2e4QyX07WpZMrP0GYwkKGI p2Q4yN5SbiXV7fWwRvU/zyguYreRlww3tnAKsnbaunkYmQhQrrfLloZbrL9d7xeiRAtb459p3uv rA1/uUA52r6DYvDbyqK5enZIdMkEnID5ukfWvkEvNV9RdoHYoBQrcbs8bmANM1GZge2QG6zezge bdb8k3lRF12J+Kx6EiEr9EmUtbiwwH2vMtRvrpghUuxz6h0WkuQqusD50iK6W4vE4adDsTYeD6e fpdS1DYc1bzZjq33F0U3w345vZXapOcjP0JvbSXEQ01r3ezg6+lfjV3gO8GsJErtDn82rD5MFU X-Received: by 2002:a05:7022:48e:b0:128:bae0:89b7 with SMTP id a92af1059eb24-12ab2fa1e4bmr488963c88.3.1774593669739; Thu, 26 Mar 2026 23:41:09 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12aa6e5beb2sm6654016c88.1.2026.03.26.23.41.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 23:41:08 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Thu, 26 Mar 2026 23:41:06 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/slab: align kmalloc to cacheline when DMA API debugging is active To: Mikhail Gavrilov , vbabka@kernel.org, harry.yoo@oracle.com, akpm@linux-foundation.org Cc: hao.li@linux.dev, cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, stern@rowland.harvard.edu, andy.shevchenko@gmail.com, hch@lst.de, Jeff.kirsher@gmail.com References: <20260327055846.248829-1-mikhail.v.gavrilov@gmail.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260327055846.248829-1-mikhail.v.gavrilov@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/26/26 22:58, Mikhail Gavrilov wrote: > When CONFIG_DMA_API_DEBUG is enabled, the DMA debug infrastructure > tracks active mappings per cacheline and warns if two different DMA > mappings share the same cacheline ("cacheline tracking EEXIST, > overlapping mappings aren't supported"). > > On x86_64, ARCH_KMALLOC_MINALIGN defaults to 8, so small kmalloc > allocations (e.g. the 8-byte hub->buffer and hub->status in the USB > hub driver) frequently land in the same 64-byte cacheline. When both > are DMA-mapped, this triggers a false positive warning. > > This has been reported repeatedly since v5.14 (when the EEXIST check > was added) across various USB host controllers and devices including > xhci_hcd with USB hubs, USB audio devices, and USB ethernet adapters. > > Raise ARCH_KMALLOC_MINALIGN to L1_CACHE_BYTES when CONFIG_DMA_API_DEBUG > is enabled, ensuring each kmalloc allocation occupies its own cacheline > and eliminating the false positive. > > Verified with a kernel module reproducer that performs two kmalloc(8) > allocations back-to-back and DMA-maps both: > > Before: allocations share a cacheline, EEXIST fires within ~50 pairs > After: 64 pairs allocated, all in separate cachelines, no warning > > Fixes: 2b4bbc6231d7 ("dma-debug: report -EEXIST errors in add_dma_entry") > Link: https://bugzilla.kernel.org/show_bug.cgi?id=215740 > Suggested-by: Alan Stern > Suggested-by: Guenter Roeck > Tested-by: Jeff Kirsher > Tested-by: Mikhail Gavrilov > Signed-off-by: Mikhail Gavrilov Thanks a lot for taking care of this! FWIW: Reviewed-by: Guenter Roeck > --- > > Reproducer module that triggers the bug reliably: > https://bugzilla.kernel.org/attachment.cgi?id=309769 > > include/linux/slab.h | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 15a60b501b95..f044956e17c1 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -536,6 +536,19 @@ static inline bool kmem_dump_obj(void *object) { return false; } > #endif > #endif > > +/* > + * Align memory allocations to cache lines if DMA API debugging is active > + * to avoid false positive DMA overlapping error messages. > + */ > +#ifdef CONFIG_DMA_API_DEBUG > +#ifndef ARCH_KMALLOC_MINALIGN > +#define ARCH_KMALLOC_MINALIGN L1_CACHE_BYTES > +#elif ARCH_KMALLOC_MINALIGN < L1_CACHE_BYTES > +#undef ARCH_KMALLOC_MINALIGN > +#define ARCH_KMALLOC_MINALIGN L1_CACHE_BYTES > +#endif > +#endif > + > #ifndef ARCH_KMALLOC_MINALIGN > #define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long) > #elif ARCH_KMALLOC_MINALIGN > 8