mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: "Andreas Färber" <afaerber@suse.de>,
	"Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: Sven Van Asbroeck <thesven73@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Lee Jones <lee.jones@linaro.org>,
	mark.rutland@arm.com, treding@nvidia.com,
	David Lechner <david@lechnology.com>,
	noralf@tronnes.org, johan@kernel.org,
	Michal Simek <monstr@monstr.eu>,
	michal.vokac@ysoft.com, Arnd Bergmann <arnd@arndb.de>,
	Greg KH <gregkh@linuxfoundation.org>,
	john.garry@huawei.com, geert+renesas@glider.be,
	robin.murphy@arm.com,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	sebastien.bourdelin@savoirfairelinux.com, icenowy@aosc.io,
	Stuart Yoder <stuyoder@gmail.com>,
	"J. Kiszka" <jan.kiszka@siemens.com>,
	maxime.ripard@bootlin.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v10 0/7] Add Fieldbus subsystem + support HMS Profinet card
Date: Wed, 24 Apr 2019 13:48:31 +0200	[thread overview]
Message-ID: <d54b294e-d641-bb14-84ed-39d9a9079dc7@hartkopp.net> (raw)
In-Reply-To: <c1b783b0-9773-17f5-d043-35e28f7797f0@suse.de>

On 24.04.19 13:00, Andreas Färber wrote:
> Am 24.04.19 um 12:26 schrieb Oliver Hartkopp:

>> The Controller Area Network also belongs to the class of field busses
>> and has its own networking subsystem in linux/net/can.
>>
>> So using a 'class' of communication protocols as naming scheme doesn't
>> fit IMHO.
> 
> And - again - NACK. Calling a subsystem just iec61158 is going to hide
> what it is and stand in the way of development of this niche system. I
> asked Enrico to come up with a better naming proposal such as having
> iec61158 as subfolder to human-readable fieldbus, but I did not see him
> coming up with any such new proposals apart from repeating this name.
> 
> Also please read Sven's comment again: It you don't like the current
> naming you'll need to post follow-up patches, as v11 of this subsystem
> has been merged into staging. No complaint about piggy-backing on v10 is
> going to change that fact now!
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/fieldbus?h=staging-next
> 
> And since we're at it, Enrico's response to me just threw around a bunch
> of acronyms instead of explaining which ones have an _actual_ conflict
> with this subsystem - my point precisely was that if they use sockets or
> ttys then there's no real conflict apart from lots of things classifying
> as "fieldbus".

Ok, I either tried to get through the fieldbus code and the 
documentation from above.

I hopefully got it right by: You implemented a standardized chardev ABI 
that enables a data exchange between userspace and kernel, where other 
drivers can register 'from inside the kernel', that feel like being a 
fieldbus controller?!?

When checking out the Anybus website the first hit for serial fieldbus 
is https://www.anybus.com/technologies/fieldbus-serial/can-canopen .

CANopen is CAN based - and the CAN network drivers and CAN controllers 
definitely do not expose sysfs entries like

	/sys/class/fieldbus_dev/fieldbus_devX/write_area_size

How can this fit together for me and what would be the plan to cover 
CANopen or EtherCAT in the fieldbus subsystem? Does it need some kind of 
CANopen protocol driver that registers to your ABI and speaks to CAN 
interfaces on the other side?

If this would have been outlined more clearly I wouldn't have stumbled 
over the fieldbus naming scheme.

Regards,
Oliver

  reply	other threads:[~2019-04-24 11:50 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09 14:42 Sven Van Asbroeck
2019-04-09 14:42 ` [PATCH v10 1/7] fieldbus_dev: add Fieldbus Device subsystem Sven Van Asbroeck
2019-04-16 11:13   ` Greg KH
2019-04-09 14:42 ` [PATCH v10 2/7] anybus-s: support HMS Anybus-S bus Sven Van Asbroeck
2019-04-09 14:42 ` [PATCH v10 3/7] anybus-s: support the Arcx anybus controller Sven Van Asbroeck
2019-04-09 14:42 ` [PATCH v10 4/7] dt-bindings: anybus-controller: document devicetree binding Sven Van Asbroeck
2019-04-09 15:50   ` Rob Herring
2019-04-09 17:16     ` Sven Van Asbroeck
2019-04-09 17:31       ` Sven Van Asbroeck
2019-04-09 21:09         ` Rob Herring
2019-04-10 13:11           ` Sven Van Asbroeck
2019-04-16 11:11             ` Greg KH
2019-04-09 14:42 ` [PATCH v10 5/7] dt-bindings: Add vendor prefix for arcx / Archronix Sven Van Asbroeck
2019-04-09 14:42 ` [PATCH v10 6/7] fieldbus_dev: support HMS Profinet IRT industrial controller Sven Van Asbroeck
2019-04-09 14:42 ` [PATCH v10 7/7] staging: fieldbus_dev: add TODO Sven Van Asbroeck
2019-04-15 17:41 ` [PATCH v10 0/7] Add Fieldbus subsystem + support HMS Profinet card Enrico Weigelt, metux IT consult
2019-04-15 18:31   ` Sven Van Asbroeck
2019-04-16 16:49     ` Enrico Weigelt, metux IT consult
2019-04-16 18:56       ` Sven Van Asbroeck
2019-04-16 21:18         ` Enrico Weigelt, metux IT consult
2019-04-16 21:49           ` Sven Van Asbroeck
2019-04-16 22:12           ` Sven Van Asbroeck
2019-04-18  8:32             ` Enrico Weigelt, metux IT consult
2019-04-18 17:34               ` Sven Van Asbroeck
2019-04-24  9:40                 ` Enrico Weigelt, metux IT consult
2019-04-24 10:26                   ` Oliver Hartkopp
2019-04-24 11:00                     ` Andreas Färber
2019-04-24 11:48                       ` Oliver Hartkopp [this message]
2019-04-24 15:10                         ` Sven Van Asbroeck
2019-04-29 13:54                           ` Enrico Weigelt, metux IT consult
2019-04-17 14:37           ` Sven Van Asbroeck
2019-04-17 17:04       ` Andreas Färber
2019-04-17 20:13         ` Enrico Weigelt, metux IT consult
2019-04-25  8:26 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d54b294e-d641-bb14-84ed-39d9a9079dc7@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=afaerber@suse.de \
    --cc=arnd@arndb.de \
    --cc=david@lechnology.com \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=icenowy@aosc.io \
    --cc=jan.kiszka@siemens.com \
    --cc=johan@kernel.org \
    --cc=john.garry@huawei.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@metux.net \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=michal.vokac@ysoft.com \
    --cc=monstr@monstr.eu \
    --cc=netdev@vger.kernel.org \
    --cc=noralf@tronnes.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=robin.murphy@arm.com \
    --cc=sebastien.bourdelin@savoirfairelinux.com \
    --cc=stuyoder@gmail.com \
    --cc=thesven73@gmail.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®