From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C22812E62C4 for ; Mon, 29 Jun 2026 13:47:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782740841; cv=none; b=j7PTXpseDPkOVk4Rtml1i8G+heR2Mbd6HHN2S3w5UJFFgXzVk0LUJOfbpaZECaZniIls7zpMBlbyYZyHbSK9fk1V5hUV8oJIBE8Q+YwwUo+KmI2T2YS2OulZY669JTtd39R7m9QYD0CPnnAmJ0+99aNmIBEF/uV35YKXzmIMv40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782740841; c=relaxed/simple; bh=cWLGHl+YEJAm1rNw68MYlvwx1Sqs4J/IHHCWaT05NBk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ze6HF8Zg8mkHBZAANmHtDlnl3P3SiWDX+3oVU5hy6OXF0maEvYD/PFJvrJkXGnBP9PcJSiljykDFtPJgo8w1882BMP5HwSMJVeHccURuTp6B2s2dDpXfkMPw4ppIXKms9vqpUP5Os4l47MBSNZ1b+FzHRECswzPBNubeRH9cjl0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UvnZI2In; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JZIboC+b; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UvnZI2In"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JZIboC+b" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65TATEsD2579129 for ; Mon, 29 Jun 2026 13:47:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ty5H6lwxHqC7d0OKhOvBgcwXdI83azrYSAb+xRBzZow=; b=UvnZI2In3GfAemsY O/sVXun6jAWn4X4HHgvgR/KJjR6zloJQip0NU8DhGsrgjBgfLjhqzNEYwW1VpgMY gtoJtMvxJauQHRdj9Fi7cqeHO8U2j9AVJuhmG8pwmiGZODliQDZbdYxMmOfhaior LJeywYaZy+DvJpleggIyFuJD5jbUBdxgPkCcUVft6Im0ZhVwDBqPovdTVQZhfI6V tUp22CO9M/LgWTvDF2lcFMD+3Mp1KiTF4D1z5AudUv+iyiPpxdyhsMXJdnqX2JsH w/ByA1iqVeyv4t67aOlfHV65T1R8zNPtaAt76D0n2RI/xb42UA9W3XxhvjSwiCDj go3REQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3kp7hm65-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 13:47:18 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c069f73e4so1081691cf.1 for ; Mon, 29 Jun 2026 06:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782740837; x=1783345637; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ty5H6lwxHqC7d0OKhOvBgcwXdI83azrYSAb+xRBzZow=; b=JZIboC+bW+ZXdU0sKOWJomFPLYyhQH/sOUfYHobbj073cbMsDWApk8Opr4ANwWVgdm eFhgyUBYFsdc9hyr9gKCjVqogWzL1b5MRSLEB7mQP4CILBBWkGIHNXzcPz7b6xHWwL5F aOz/XgScZar5K6d9qWILXYlcSbG0U5DLEfW10M7cTy/hHcPYJ6Z/ORLqcyWT/2OWrHuE yNdQxy/lIicqx8YYR7k1fIezWT5hWcl3FruwRSPafG24QRnM/Sw2s5omB81j7xHhhRG9 4Apu4Prh8gFAYOKRSVb/6gMiklF+hWBxa3A5fgaVxcdGitpLTS9tAdyKFff0GRgGgUpx cSDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782740837; x=1783345637; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ty5H6lwxHqC7d0OKhOvBgcwXdI83azrYSAb+xRBzZow=; b=eV5PI3DUwbwrfVqHSRRCuMvbeBdODS37oW8dQRZGRbHOHmIQrGFnBPfJn6VvztRV/z 7SPbUyKadAEjBUvuFJUNEgl/xopAHWYFLcOo0aFMPZA4j4kruJqv9Z5Inhx+UHKP8HNs TFj7voW5G3ElZtAMa9qV8TwImXywjuT7va6Z+CJQhlUalG8bC4WyHjLPDn8wGRRXECTr +K41l+iP8KhZiRJ5qOvanSJxAuiBGjcLi9fV4NYNHKWN0WoCQSmdKXN+0gH5uHlTW8CN jYCO7MqaboMh73tR4vo87KxhB6vbtgnbWCRa7Gz/4+YgR1DZ1x4eaC9B5FYzBGZOfeXC fzfQ== X-Forwarded-Encrypted: i=1; AFNElJ95S6uia9HWp2sqFZXk1QMusOEYJJsJTUlH9HopBIC3PelhMeXCGJOq+o8YDXu2GYsQ06c6amRkpkmc+Fw=@vger.kernel.org X-Gm-Message-State: AOJu0YxCrThx8EbeNqo9xZYfPwjDmeVU8qHs/otyxwnqKvqXaPgPHbGQ dOjooPm8Vt7tqTm2FKWm7zxXIZxHwnchc6gZpYoESiCU43ks/bs8SUTMxEm7KBmEehv1YElohNM AR88UPNqaXJq4iAqd4In8oxvjve8wLW3iN6/ZDfdjXHAOBBxZdEpNIgYzE1VUodGyZwA= X-Gm-Gg: AfdE7cnITGU+s72EQQkkJ3F8/tIUvmetJatuSjUsBa82R2th1TjFbaEY9VmOT3R1/sh SjmwmbRR1Gpq+x/JZNPNoIWBzfyHn0Tk/NkfCvX7USq+pIvi0Ehy6ocV6+7pJyGG6K2WTxS5P9g KE8oOo2dggYe/xwuZ7V1YE9XGXdet3pXiOI/XvnVNMiWCSHGRAFfEZh+o3BIQ3VVa2dUIXCIDdC lbR63mNSqXpPvEgQ3wwVp4hZFntzruF6MRYqZDObrGsj86dpd4328RF7RvUpjcACDrQjU/fnBOM o5K5eBjAIUoqnonpIREtmqewrOmNRUsnypWnLRMwoMEZGyf7HtZ1fRrhDCDrT311uInhqiiGwiv 2srA9BgeoibIvPhF7w7ZObwZwA1IeKmvxhNY= X-Received: by 2002:ac8:7f13:0:b0:51a:8c9b:64a5 with SMTP id d75a77b69052e-51a8c9b9539mr97100131cf.9.1782740836910; Mon, 29 Jun 2026 06:47:16 -0700 (PDT) X-Received: by 2002:ac8:7f13:0:b0:51a:8c9b:64a5 with SMTP id d75a77b69052e-51a8c9b9539mr97099261cf.9.1782740835898; Mon, 29 Jun 2026 06:47:15 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c11fbec37dfsm785750166b.56.2026.06.29.06.47.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 06:47:14 -0700 (PDT) Message-ID: Date: Mon, 29 Jun 2026 15:47:12 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/8] clk: qcom: tcsrcc-glymur: Add Mahua QREF regulator support To: Qiang Yu Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, krishna.chundru@oss.qualcomm.com References: <20260621-tcsr_qref_0622-v6-0-c939c22ded0c@oss.qualcomm.com> <20260621-tcsr_qref_0622-v6-5-c939c22ded0c@oss.qualcomm.com> <5f32d4c2-f90d-4f66-96b1-c9c7987ac18e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDExNCBTYWx0ZWRfXyIke/iYNsy+V 47L0sRPxUvoBzOuc4oytuesdZrlOrNZQUm8uaGrldVOD4eKe0HS1zXk0YxfMNswOSzYeCwvn65V QVgvR4M2F7UQConp4GdNg71F9kY0Jek= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDExNCBTYWx0ZWRfXyu39PKjDAw+c BqvKvLCJOfxn1RD7F8WDmDd36Gvb88+r/i4pqmUswBuzqsOImndC5zx0gG+klh5NQB0qz8YE84c 9s+oqj6Og3X7jQtj6rlvDV74tQprgKC8Av28PaeDBzxaP1nlgDRiOPy9Bph6rUNjI8ciLafdVxu 65h8246wXbuNPjrfPnlfqLvuU+5ImsV6YVH0d09WadlyuT8lwYk4DBSvb2JlkMotUXYlWNp38pN aEI4nGhzju3uUOm80eapP8l/UNEaTkxrkD842AdBT+TxvHDCVl3fKFpGmPOZdDGdrX83ZHW8mHv CNYihd7gnpYo+hNh9z4Y+3oawWHoLgZ+Jg5Y2Xia4CGBtVoipmq0Sr9cmTPdN/3bMgasThHO2/x xWV8JHOJaEPraRX2uN3n8rr2wCN1+KzgeeeRlXEfvf7Xuwa/s7yEGAT+QVH1TTD4O4nzBF43SSL Ob6hquIZQOHx+W7m0Jg== X-Proofpoint-ORIG-GUID: dZfJTt6Ai4o8c6-c7ShsqOs1KbC9KoFg X-Authority-Analysis: v=2.4 cv=MZJcfZ/f c=1 sm=1 tr=0 ts=6a427766 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=ffaXYdf2Q3_1duncg2EA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: dZfJTt6Ai4o8c6-c7ShsqOs1KbC9KoFg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 clxscore=1015 phishscore=0 bulkscore=0 impostorscore=0 spamscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290114 On 6/29/26 3:32 PM, Qiang Yu wrote: > On Mon, Jun 29, 2026 at 12:30:37PM +0200, Konrad Dybcio wrote: >> On 6/26/26 5:53 AM, Qiang Yu wrote: >>> On Mon, Jun 22, 2026 at 03:03:39PM +0200, Konrad Dybcio wrote: >>>> On 6/22/26 2:49 PM, Qiang Yu wrote: >>>>> On Mon, Jun 22, 2026 at 01:35:45PM +0200, Konrad Dybcio wrote: >>>>>> On 6/22/26 7:11 AM, Qiang Yu wrote: >>>>>>> Mahua is based on Glymur but uses a different QREF topology, requiring >>>>>>> distinct regulator lists and clock descriptors for its PCIe clock >>>>>>> references. >>>>>>> >>>>>>> Add mahua-specific regulator arrays and clk descriptor table, and use >>>>>>> match_data to select the correct descriptor table per compatible string at >>>>>>> probe time. >>>>>>> >>>>>>> Signed-off-by: Qiang Yu >>>>>>> --- >>>> >>>> [...] >>>> >>>>>> You're also missing PCIe_1_CLKREF_EN (+0x48) (for PCIe5) >>>>>> which goes through CXO1_>TX->RPT0->RPT1->RPT2->RX2 >>>>> >>>>> I have removed PCIe_1_CLKREF_EN in dts node because PCIe5 PHY doesn't >>>>> require QREF. So I didn't provide its structure here. >>>> >>>> I don't quite get what you mean. I see that it is there in the graph >>> >>> I double-checked with the HW team — QREF is not required for CXO0. In TCSR >>> HPG, I think the QREF components you are seeing are in an old version >>> diagram, but it says the QREF for CXO0 will be removed. In the updated >>> diagram, PCIe5, USB2_0, USB2_1, USB4_0 and USB4_1 PHYs get refclk directly >>> from CXO0. >>> >>> In theory, we don't need to vote clkref_en and QREF LDOs for these PHY >>> instances, and I got confirmation from the PCIe HW team for PCIe5 PHY. >>> >>> I also compared the description of the TCSR_CLKREF_EN register between >>> glymur and mahua on ipcatlog. Unfortunately, only >>> TCSR_USB4_1_CLKREF_EN_USB4_ENABLE is marked as "not in use". I believe >>> this is because these registers are not documented well in ipcatlog. >>> >>> So I think part of the regulator lists you commented for USB instances is >>> not required, and their dts node also can to be changed to use CXO as >>> refclk instead of TCSR_CLKREF_EN. But the mapping between the USB instance >>> names in the QREF diagram and the TCSR_CLKREF_EN registers is not clear — >>> I cannot find TCSR_USB4_0_CLKREF_EN_USB4_ENABLE, but there is a USB4_0 PHY >>> in the diagram. Can we leave the USB regulator list as NULL or we just >>> add them as it is harmless? >> >> I believe the internal discussions we had indeed point to the TX/RPT >> elements having been removed somewhere in the chip dev process, so >> the regulators can go, in my understanding. >> >> As for the refclk toggles themselves, my understanding is that they are >> still meaningful. Although, we should be able to just smoketest that - set >> all of these registers to 0 and see if the related IPs still work normally >> > > As internal discussion, the TCSR_USBn_CLKREF_EN to digram instance mapping > is: > > TCSR_USB2_1_CLKREF_EN -> usb2_hs > TCSR_USB2_2_CLKREF_EN -> usb2_hs3 > TCSR_USB2_3_CLKREF_EN -> usb2_hs6 > TCSR_USB2_4_CLKREF_EN -> usb2_2 > TCSR_USB3_0_CLKREF_EN -> usb3_ss3 > TCSR_USB3_1_CLKREF_EN -> usb3_ss4 > TCSR_USB4_1_CLKREF_EN -> usb4_1 > TCSR_USB4_2_CLKREF_EN -> usb4_2 > > I will remove regulator list for TCSR_USB2_1_CLKREF_EN and > TCSR_USB4_1_CLKREF_EN. For the registers, we can leave them in the clk > array, the driver can still vote CXO as parent of tcsr_clkref_en and the > register setting in enable/disable is just a no-op if they are really not > required. sgtm Konrad