Re: [PATCH bluetooth-next v5 2/3] dt-bindings: net: bluetooth: Add AIC8800D80

[Krzysztof Kozlowski <krzk@kernel.org>]

On 24/09/2026 05:34, Yanli Yang wrote:
> Describe the AIC8800D80 Bluetooth SDIO firmware-loading function and
> UART HCI interface. Link the UART node to its SDIO firmware provider
> with the aic,firmware-sdio phandle.
> 
> The UART interface uses H4 at 1500000 baud with hardware flow control.
> Include an example showing both nodes and their association. Add the
> Bluetooth binding to MAINTAINERS.
> 
> Signed-off-by: Zhirun Liu <zhirunliu@aicsemi.com>
> Signed-off-by: Dijia Xu <dijiaxu@aicsemi.com>
> Signed-off-by: Chunqiu Liu <chunqiuliu@aicsemi.com>
> Signed-off-by: Liheng Wei <liheng.wei@bedmex.com>
> Signed-off-by: Yanli Yang <yanli.yang@bedmex.com>
> ---


So that's v5, thus where is the changelog?

Cover letter says nothing about v1-v3, only v4. And in that v4 nothing
about this and 1/3 patches.

>  .../net/bluetooth/aic,aic8800d80-bt.yaml      | 84 +++++++++++++++++++
>  MAINTAINERS                                   | 10 +++
>  2 files changed, 94 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/bluetooth/aic,aic8800d80-bt.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/aic,aic8800d80-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/aic,aic8800d80-bt.yaml
> new file mode 100644
> index 000000000000..76b94fd539e7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/bluetooth/aic,aic8800d80-bt.yaml
> @@ -0,0 +1,84 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/bluetooth/aic,aic8800d80-bt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AIC AIC8800D80 Bluetooth
> +
> +maintainers:
> +  - Zhirun Liu <zhirunliu@aicsemi.com>
> +  - Dijia Xu <dijiaxu@aicsemi.com>
> +  - Chunqiu Liu <chunqiuliu@aicsemi.com>
> +  - Liheng Wei <liheng.wei@bedmex.com>
> +  - Yanli Yang <yanli.yang@bedmex.com>
> +
> +description:
> +  The AIC8800D80 is a Wi-Fi and Bluetooth combination chip. The Bluetooth
> +  firmware is loaded through SDIO function 1, while Bluetooth HCI traffic uses
> +  the H4 protocol over a UART interface with hardware flow control.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - aic,aic8800d80-bt
> +      - aic,aic8800d80-bt-sdio

So same feedback as last time. Same device?


> +
> +  reg:
> +    maxItems: 1
> +
> +  max-speed: false
> +
> +  aic,firmware-sdio:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Phandle to the SDIO function used to load the Bluetooth firmware.

What is a SDIO function in DT? Phandles can only point to device nodes.

> +
> +required:
> +  - compatible
> +
> +allOf:
> +  - $ref: bluetooth-controller.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          const: aic,aic8800d80-bt-sdio
> +    then:
> +      properties:
> +        reg:
> +          items:
> +            - items:
> +                - const: 1
> +        aic,firmware-sdio: false
> +      required:
> +        - reg
> +    else:
> +      properties:
> +        reg: false
> +      required:
> +        - aic,firmware-sdio
> +      allOf:
> +        - $ref: /schemas/serial/serial-peripheral-props.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    mmc {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        bt_sdio: bluetooth@1 {
> +            compatible = "aic,aic8800d80-bt-sdio";
> +            reg = <1>;
> +        };
> +    };
> +
> +    serial {
> +        uart-has-rtscts;
> +
> +        bluetooth {
> +            compatible = "aic,aic8800d80-bt";
> +            aic,firmware-sdio = <&bt_sdio>;
> +        };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index af5a8b4b0bb5..20662fe78632 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -729,6 +729,16 @@ S:	Maintained
>  F:	drivers/scsi/aha152x*
>  F:	drivers/scsi/pcmcia/aha152x*
>  "managers" 
> +AIC BLUETOOTH DRIVER
> +M:	Zhirun Liu <zhirunliu@aicsemi.com>
> +M:	Dijia Xu <dijiaxu@aicsemi.com>
> +M:	Chunqiu Liu <chunqiuliu@aicsemi.com>
> +M:	Liheng Wei <liheng.wei@bedmex.com>
> +M:	Yanli Yang <yanli.yang@bedmex.com>

So all these 5 people are going to provide reviews?

Please confirm this explicitly, so we don't get entries for, for
example, managers which like to be notified.


Best regards,
Krzysztof