From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753652AbdEQL62 (ORCPT ); Wed, 17 May 2017 07:58:28 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:59502 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680AbdEQL6Y (ORCPT ); Wed, 17 May 2017 07:58:24 -0400 Subject: Re: [PATCH v5 16/17] tty: serdev-ttyport: return actual baudrate from ttyport_set_baudrate To: Rob Herring , "David S. Miller" , Greg Kroah-Hartman References: <1494406408-31760-1-git-send-email-stefan.wahren@i2se.com> <1494406408-31760-17-git-send-email-stefan.wahren@i2se.com> Cc: Mark Rutland , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, Lino Sanfilippo , Jakub Kicinski From: Stefan Wahren Message-ID: Date: Wed, 17 May 2017 13:58:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1494406408-31760-17-git-send-email-stefan.wahren@i2se.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:TFZS3xAhvTGtyNTcnpiAeNtAh6y4V3oi8NcrOWnJIYWEC/n/hVY H33QZ1FxXIjs+24JqC7u3peOWhgwPrVXOSwodEONOuWt44zy85KFSUUH90OSXFMcVhtK/WI W6UvnhJ7ZcsQ/YY2hBHxYvyXcCeXAzsOhauQvfNzmRzy2ZCFcop+bDSfoBFtwtwqlzG0cxu BV1q5UmegM8Wae7quVijw== X-UI-Out-Filterresults: notjunk:1;V01:K0:TVG6XAjcVjU=:KchZ+emo5LDl930e7d/D3O tBWkSRFkxzM4g7WLcS5Fa5vj/0k08qMvBJygaGFLVXBNmGKGca7ES8292r2WqMDSwxaztv/Z1 3smOOKQh4fGTi2SDkpu9NYLH4geb+2q0VATki9WQX2z1rB13hyPWAKCwj63fV9NxRfhjETY8/ Jrb5RMsd7FyV8i61NOGmoERoJ0kXiJkEluPpfAuHHwqLUk+bsC09JrVpFo8931kclFgFcMORs BD/3RNs1KHhqTkPeDcjqXSF7dWBmrbeO7yKCdsxxXh5gnMS8xO3JvqzPE34vtBcDbWxPX1ocL EVG07+j30d/1ttIgUcKmb42TWrOHf12QNU/sL37brLHEi19tYMFdHFZRWBinQoAmNdkchYsE5 9vmbiCMsEndt3/mYEy7aGYBYCVCm/HBjX4l+eJrlj/3r1McqIcnvk05fV+478Kw4r9npnk8Uc k0lFHcpSqHFckhCHQPetWAtYoSXMTk5Cfitj7yJ4d8Gu+g25K/ZawYJRWx9OWf6dWMVUSWjHy Sh3A1SSI2gXujzmH5tP2dUgfb31z49iMitz7+U4fRUzG/dlFkT0Lgiu3ODvuszINSEVfvoMgS aMs8Di+DNdN8EszJ+yznaX31wJYN4Q8SMWBazFb3ju0z1BsIOzElIc1kkoSx1UUHCUu3W9EBr lh7vW5JAqEluoIlWxnd0LS3VO24kegwBInBdvs4XHyyRli4pPiZEQlrqPzlI6b3PJ+SxHT3uX iTXqdL2Cdhq22rTY Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, Am 10.05.2017 um 10:53 schrieb Stefan Wahren: > Instead of returning the requested baudrate, we better return the > actual one because it isn't always the same. > > Signed-off-by: Stefan Wahren > Acked-by: Rob Herring > --- > drivers/tty/serdev/serdev-ttyport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c > index 487c88f..2cfdf34 100644 > --- a/drivers/tty/serdev/serdev-ttyport.c > +++ b/drivers/tty/serdev/serdev-ttyport.c > @@ -151,7 +151,7 @@ static unsigned int ttyport_set_baudrate(struct serdev_controller *ctrl, unsigne > > /* tty_set_termios() return not checked as it is always 0 */ > tty_set_termios(tty, &ktermios); > - return speed; > + return ktermios.c_ospeed; > } > > static void ttyport_set_flow_control(struct serdev_controller *ctrl, bool enable) there is no dependency to this series. I would be happy if this could be applied, so i don't have to carry it for the next version. Thanks Stefan